From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id EE0F63858D28 for ; Thu, 6 Apr 2023 22:52:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE0F63858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 16A53302BB02; Fri, 7 Apr 2023 00:52:17 +0200 (CEST) Date: Fri, 7 Apr 2023 00:52:17 +0200 From: Mark Wielaard To: Youling Tang Cc: elfutils-devel@sourceware.org, Hengqi Chen , Liwei Ge Subject: Re: [PATCH] backends: add checks for _GLOBAL_OFFSET_TABLE_ on loongarch Message-ID: <20230406225217.GF18331@gnu.wildebeest.org> References: <1680319133-22776-1-git-send-email-tangyouling@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1680319133-22776-1-git-send-email-tangyouling@loongson.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3030.6 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Sat, Apr 01, 2023 at 11:18:53AM +0800, Youling Tang wrote: > Add handling of _GLOBAL_OFFSET_TABLE_. > > Before applying the patch: > $ ./src/elflint --gnu-ld ./src/elflint > section [35] '.symtab': _GLOBAL_OFFSET_TABLE_ symbol value 0x68548 > does not match .got.plt section address 0x68238 > > After applying the patch: > $ ./src/elflint --gnu-ld ./src/elflint > No errors Thanks, code looks correct. I agree that the other issue mentioned (_DYNAMIC symbol size 0) is a separate issue. Pushed, Mark