From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Cc: Mark Wielaard <mark@klomp.org>
Subject: [COMMITTED] tests: Really split run-copymany-sections.sh into separate tests
Date: Sat, 17 Jun 2023 15:01:08 +0200 [thread overview]
Message-ID: <20230617130108.572810-1-mark@klomp.org> (raw)
The previous commit 4fac1627c "tests: Split run-copymany-sections.sh
into separate tests" duplicated the tests because they were still
also done in the new test-copymany-subr.sh. Remove them really this
time. Also don't source test-subr.sh twice, test-copymany-subr.sh
already sources it, so the subtests don't have to also do it again.
* tests/test-copymany-subr.sh: Remove actual tests.
* tests/run-copymany-be32.sh: Remove . $srcdir/test-subr.sh.
* tests/run-copymany-be64.sh: Likewise.
* tests/run-copymany-le32.sh: Likewise.
* tests/run-copymany-le64.sh: Likewise.
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
tests/run-copymany-be32.sh | 1 -
tests/run-copymany-be64.sh | 1 -
tests/run-copymany-le32.sh | 1 -
tests/run-copymany-le64.sh | 1 -
tests/test-copymany-subr.sh | 44 +++----------------------------------
5 files changed, 3 insertions(+), 45 deletions(-)
diff --git a/tests/run-copymany-be32.sh b/tests/run-copymany-be32.sh
index 8fdbfbf6..dc32e7a9 100755
--- a/tests/run-copymany-be32.sh
+++ b/tests/run-copymany-be32.sh
@@ -1,7 +1,6 @@
#! /bin/sh
. $srcdir/test-copymany-subr.sh
-. $srcdir/test-subr.sh
# 32bit, big endian, rel
testfiles testfile29
diff --git a/tests/run-copymany-be64.sh b/tests/run-copymany-be64.sh
index bd7e50a4..1f06e077 100755
--- a/tests/run-copymany-be64.sh
+++ b/tests/run-copymany-be64.sh
@@ -1,7 +1,6 @@
#! /bin/sh
. $srcdir/test-copymany-subr.sh
-. $srcdir/test-subr.sh
# 64bit, big endian, rel
testfiles testfile23
diff --git a/tests/run-copymany-le32.sh b/tests/run-copymany-le32.sh
index 82957d6c..d47a90ed 100755
--- a/tests/run-copymany-le32.sh
+++ b/tests/run-copymany-le32.sh
@@ -1,7 +1,6 @@
#! /bin/sh
. $srcdir/test-copymany-subr.sh
-. $srcdir/test-subr.sh
# 32bit, little endian, rel
testfiles testfile9
diff --git a/tests/run-copymany-le64.sh b/tests/run-copymany-le64.sh
index a2d7c2ea..b563d9de 100755
--- a/tests/run-copymany-le64.sh
+++ b/tests/run-copymany-le64.sh
@@ -1,7 +1,6 @@
#! /bin/sh
. $srcdir/test-copymany-subr.sh
-. $srcdir/test-subr.sh
# 64bit, little endian, rel
testfiles testfile38
diff --git a/tests/test-copymany-subr.sh b/tests/test-copymany-subr.sh
index 4b65d80e..054103b4 100755
--- a/tests/test-copymany-subr.sh
+++ b/tests/test-copymany-subr.sh
@@ -57,44 +57,6 @@ test_copy_and_add ()
# and non-ET_REL (with phdrs)/ET_REL (without phdrs).
# Try to add 0x0fff sections twice.
-# 32bit, big endian, rel
-testfiles testfile29
-test_copy_and_add testfile29
-test_copy_and_add testfile29.copy
-
-# 64bit, big endian, rel
-testfiles testfile23
-test_copy_and_add testfile23
-test_copy_and_add testfile23.copy
-
-# 32bit, little endian, rel
-testfiles testfile9
-test_copy_and_add testfile9
-test_copy_and_add testfile9.copy
-
-# 64bit, little endian, rel
-testfiles testfile38
-test_copy_and_add testfile38
-test_copy_and_add testfile38.copy
-
-# 32bit, big endian, non-rel
-testfiles testfile26
-test_copy_and_add testfile26
-test_copy_and_add testfile26.copy
-
-# 64bit, big endian, non-rel
-testfiles testfile27
-test_copy_and_add testfile27
-test_copy_and_add testfile27.copy
-
-# 32bit, little endian, non-rel
-testfiles testfile
-test_copy_and_add testfile
-test_copy_and_add testfile.copy
-
-# 64bit, little endian, non-rel
-testfiles testfile10
-test_copy_and_add testfile10
-test_copy_and_add testfile10.copy
-
-exit 0
+# Separated out into subtests
+# run-copymany-be32.sh run-copymany-be64.sh
+# run-copymany-le32.sh run-copymany-le64.sh
--
2.39.3
reply other threads:[~2023-06-17 13:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230617130108.572810-1-mark@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).