From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=mIHn=EJ=klomp.org=mark@sourceware.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
	by sourceware.org (Postfix) with ESMTPS id 0C4353858C53
	for <elfutils-devel@sourceware.org>; Thu, 24 Aug 2023 19:51:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C4353858C53
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: by gnu.wildebeest.org (Postfix, from userid 1000)
	id ED9B8302BBEC; Thu, 24 Aug 2023 21:51:54 +0200 (CEST)
Date: Thu, 24 Aug 2023 21:51:54 +0200
From: Mark Wielaard <mark@klomp.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] libelf, readelf, elflint: Add RELR support
Message-ID: <20230824195154.GA14128@gnu.wildebeest.org>
References: <20230823220211.1942430-1-mark@klomp.org>
 <ZOeyI/ZhoNCJQnfF@telecaster>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZOeyI/ZhoNCJQnfF@telecaster>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <elfutils-devel.sourceware.org>

Hi Omar,

On Thu, Aug 24, 2023 at 12:40:19PM -0700, Omar Sandoval wrote:
> On Thu, Aug 24, 2023 at 12:02:11AM +0200, Mark Wielaard wrote:
> >
> > 	* libelf/gelf.h (Gelf_Relr): New typedef for Elf64_Relr.
> >  
> > +/* Relative relocation entry (in section of type SHT_RELR).  */
> > +typedef Elf64_Relr Gelf_Relr;
> 
> Should this be GElf_Relr (with an uppercase E in GElf like the other
> typedefs)?

Oops. Yes, it should. Thanks for spotting that.

Cheers,

Mark