From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 3F2113858D28 for ; Tue, 29 Aug 2023 19:26:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F2113858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 4D73C30067AE; Tue, 29 Aug 2023 21:26:58 +0200 (CEST) Date: Tue, 29 Aug 2023 21:26:58 +0200 From: Mark Wielaard To: "Frank Ch. Eigler" Cc: lilydjwg , elfutils-devel@sourceware.org Subject: Re: PR30809, was Re: [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T Message-ID: <20230829192658.GL8061@gnu.wildebeest.org> References: <20230329150237.896092-1-lilydjwg@gmail.com> <20230329150237.896092-2-lilydjwg@gmail.com> <20230329191443.GB30778@redhat.com> <20230330172413.GG30778@redhat.com> <20230829183307.GE24480@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829183307.GE24480@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Frank, On Tue, Aug 29, 2023 at 02:33:07PM -0400, Frank Ch. Eigler wrote: > commit 3ef3fab0d64c89a52dd6e2ce0d01dd5e713d7b5a > Author: Frank Ch. Eigler > Date: Tue Aug 29 14:08:04 2023 -0400 > > PR30809: improve debuginfod client progress-callback parameters > > * debuginfod-client.c (debuginfod_query_server): Use fstat(3) > of the file handle being downloaded into as the preferred > source of download progress. > > Tested by hand, as the testsuite doesn't have enough machinery to > simulate compressed vs. uncompressed service. Hand testing with > (unmodified) fedora-38 gdb and debuginfod-find shows dramatically > improved progress displays: all have quantitative figures when > fetching from real (unmodified) upstream servers. > > Signed-off-by: Frank Ch. Eigler Very nice and simple. Looks good. Thanks, Mark