From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 98C573858D1E for ; Sun, 1 Oct 2023 14:02:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98C573858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696168969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3vhPV8UcaXIzpdCWcoC6G+Poozt/80opyUSjYRnvh9w=; b=R++XgmFgDOn+n4AJhGMBT85b0GwZziZGOpdlkGidWd5P2XANsdBkc5kWK66gYYF9jw48wI LUuW6gFGS/De9aPrTMaEYgJUD0gT4aMiHPB5FmZLSPcvcyn2blodWMhSxF1yX+Ds7LHsCK QtIYmIAfyfh+nOyyGcl8nZDHx3Z3dVA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-107-yJ2JW0HmOjOnxq1P4-ahMw-1; Sun, 01 Oct 2023 10:02:47 -0400 X-MC-Unique: yJ2JW0HmOjOnxq1P4-ahMw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7599C811E7D; Sun, 1 Oct 2023 14:02:47 +0000 (UTC) Received: from redhat.com (unknown [10.22.8.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6515F170EE; Sun, 1 Oct 2023 14:02:47 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1qmx1y-0000cg-MI; Sun, 01 Oct 2023 10:02:46 -0400 Date: Sun, 1 Oct 2023 10:02:46 -0400 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: "Frank Ch. Eigler" , elfutils-devel@sourceware.org Subject: Re: [PATCH] PR30879: debuginfod intermittent terminate() Message-ID: <20231001140246.GB13419@redhat.com> References: <20231001135756.GC32765@gnu.wildebeest.org> MIME-Version: 1.0 In-Reply-To: <20231001135756.GC32765@gnu.wildebeest.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi - > The new terminate_handler seems really useful, I wonder why something > like this isn't the default behaviour. Yeah. > I think I understand the idea behind wrapping scan () to catch the > reportable_exception. Yup. > The sqlite_checkpoint_pb looks simpler now. But I must admit I don't > fully understand if the lifetime of the object. The sqlite_ps had a > destructor that called finalize, which I assume isn't necessary? In the new case, we're calling "sqlite3_execute" directly, which does not need finalization. > The code looks good to me. Thanks! > Did you already catch (haha, pun intended) where/what caused that odd > sparc uncaught exception? Nope. :( In the cases I saw, the error occurred right during the object ctor, but was not able to trigger it by hand or get a core dump to analyze further. - FChE