From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Cc: Mark Wielaard <mark@klomp.org>
Subject: [PATCH] readelf: Don't print average number of tests when no tests are done
Date: Wed, 15 Nov 2023 17:41:11 +0100 [thread overview]
Message-ID: <20231115164111.657025-1-mark@klomp.org> (raw)
If the symbol hash table only contains lenght zero chains, no lookup
tests need to be done and eu-readelf -I would print out bogus numbers
for the number of tests that were successful/unsuccessful.
e.g. for an "empty" program like
int main() {}
eu-readelf -I would print:
Histogram for bucket list length in section [ 5] '.gnu.hash' (total of 1 bucket):
Addr: 0x00000000004003c0 Offset: 0x0003c0 Link to section: [ 6] '.dynsym'
Symbol Bias: 1
Bitmask Size: 8 bytes 0% bits set 2nd hash shift: 0
Length Number % of total Coverage
0 1 100.0%
Average number of tests: successful lookup: -nan
unsuccessful lookup: 0.000000
Only print out the Average number of tests when there were actual
tests to do.
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
src/readelf.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/readelf.c b/src/readelf.c
index decfaf15..802f8ede 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -3644,11 +3644,12 @@ print_hash_info (Ebl *ebl, Elf_Scn *scn, GElf_Shdr *shdr, size_t shstrndx,
success += counts[cnt] * acc;
}
- printf (_("\
+ if (nzero_counts > 0)
+ printf (_("\
Average number of tests: successful lookup: %f\n\
unsuccessful lookup: %f\n"),
- (double) success / (double) nzero_counts,
- (double) nzero_counts / (double) nbucket);
+ (double) success / (double) nzero_counts,
+ (double) nzero_counts / (double) nbucket);
}
free (counts);
--
2.41.0
next reply other threads:[~2023-11-15 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 16:41 Mark Wielaard [this message]
2023-11-20 17:30 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115164111.657025-1-mark@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).