From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id F146A385842D for ; Thu, 14 Dec 2023 19:22:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F146A385842D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F146A385842D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702581741; cv=none; b=kMIKE/0lVef/Cbwc0Ca3qkdeI9Ljvibchn0C/KOkVwDpvcNq8hsfjrn1fA5WtfuueSEpcIcxaUmiurs+RAfi7LOstS7wE4z1zKEqAbd6Za/1mUFobGEAFY4uqCyi1eXAKpQHGzfCkG7SaT7kz8YC0Llc04nJfiWEipboBJZeGro= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702581741; c=relaxed/simple; bh=y/Dq5XFo1yNQ7q+Gbz+BKOqQ9gH9Snqnvow0ANyVS/Q=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=hdchb/1PdTs9NcABBj4+/8CtkC09AszHo3ILcqyX2+BBO/m6sGgcruK8AdPikyrbtfIaqv3G5RCMSvWs7cTWwooWjJLTUOuza3xDJCteplB/LUf2u+k57mwMYBQfDay1Y3Cio8MTpvX7O9aa3Svx7mkYA1cOKmUx/361B7e6jAc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 0C290302BB02; Thu, 14 Dec 2023 20:22:19 +0100 (CET) Date: Thu, 14 Dec 2023 20:22:19 +0100 From: Mark Wielaard To: Khem Raj Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Add helper function for basename Message-ID: <20231214192219.GB12145@gnu.wildebeest.org> References: <20231210202033.151578-1-raj.khem@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Khem, On Thu, Dec 14, 2023 at 10:15:00AM -0800, Khem Raj wrote: > Overall, this looks a good improvement on top of my patch so good to go. > I will also try it in my local distro builds and see how it goes. Thanks. I didn't actually test it against musl. So if you could and report whether or not it works as intended that would be really appreciated. Cheers, Mark