Re: [PATCH] PR 30991: srcfiles tarball feature

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

Hi,

On Mon, Feb 05, 2024 at 07:24:33PM -0500, Aaron Merey wrote:
> > diff --git a/NEWS b/NEWS
> > index 0420d3b8..3391d6a1 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -1,3 +1,8 @@
> > +Version 0.191 (after 0.189)
> > +
> > +srcfiles: Can now fetch the source files of a DWARF/ELF file and
> > +          place them into a zip.
> > +
> >  Version 0.190 "Woke!"
> >
> >  CONTRIBUTING: Switch from real name policy to known identity policy.
> > @@ -9,6 +14,9 @@ libelf: Add RELR support.
> >
> >  libdw: Recognize .debug_[ct]u_index sections
> >
> > +srcfiles: added srcfiles tool that lists all the source files of a given
> > +          DWARF/ELF file.
> > +
> >  readelf: Support readelf -Ds, --use-dynamic --symbol.
> >           Support .gdb_index version 9
> >

This looks like a merge issue after the 0.190 release. I updated the
version at the top and removed the duplicate entry under 0.190.

> > diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
> > index 524be948..6b21f46f 100644
> > --- a/debuginfod/debuginfod.cxx
> > +++ b/debuginfod/debuginfod.cxx
> > @@ -2996,8 +2996,6 @@ dwarf_extract_source_paths (Elf *elf, set<string>& debug_sourcefiles)
> >
> >        if (comp_dir[0] == '\0' && cuname[0] != '/')
> >          {
> > -          // This is a common symptom for dwz-compressed debug files,
> > -          // where the altdebug file cannot be resolved.
> >            if (verbose > 3)
> >              obatched(clog) << "skipping cu=" << cuname << " due to empty comp_dir" << endl;
> >            continue;

Was it intended to remove this comment?

Cheers,

Mark

[-- Attachment #2: 0001-NEWS-Update-version-number-and-remove-duplicate-0.19.patch --]
[-- Type: text/plain, Size: 853 bytes --]

From 71794afb54fd9668a02a361134f15180ce85f3ad Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Tue, 6 Feb 2024 12:53:54 +0100
Subject: [PATCH] NEWS: Update version number and remove duplicate 0.190 entry

---
 NEWS | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/NEWS b/NEWS
index e2393e77..98dc78f5 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-Version 0.191 (after 0.189)
+Version 0.191 (after 0.190)
 
 srcfiles: Can now fetch the source files of a DWARF/ELF file and
           place them into a zip.
@@ -14,9 +14,6 @@ libelf: Add RELR support.
 
 libdw: Recognize .debug_[ct]u_index sections
 
-srcfiles: added srcfiles tool that lists all the source files of a given
-          DWARF/ELF file.
-
 readelf: Support readelf -Ds, --use-dynamic --symbol.
          Support .gdb_index version 9
 
-- 
2.39.3