From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 95F5F3858D38 for ; Tue, 6 Feb 2024 12:03:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95F5F3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 95F5F3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707220983; cv=none; b=BkUs708QxqK/zaxrM7+TDkk1vzAfN6k9wjZE2LdOOzKJ9lngSB/O0hu0ItnmiufT3orG5hVyLxF0ftfW19smbhqjuqUQypJMvRw/gPVmJuyf2RhLPWSBSLjRXY5A1/QqA2OSqcUNqETvJUpVpdUr3qhkTsn47jBeqrxvojWmgKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707220983; c=relaxed/simple; bh=vfEAWuta99+MNGpagPLbk15eTE2946P+I5t2Ln0NhKI=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=dexV91DmduUcaPYxQh8dGyfRLmkbmuIEHaxPdtkh0z5tPAwdyadGuHs4rpqaoxIHqd9RFc/+stWl0ur/9ir58ALlBFMfS+arJmqN9C/qiWmqVsc2O9oDbO+x1eDT9x6GZOAz5qxUVaXig7z3Rpz6kOdvi0Ofv+Hm35k6ujewroE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 9C2A43000673; Tue, 6 Feb 2024 13:03:00 +0100 (CET) Date: Tue, 6 Feb 2024 13:03:00 +0100 From: Mark Wielaard To: Aaron Merey Cc: halamour@redhat.com, elfutils-devel@sourceware.org Subject: Re: [PATCH] PR 30991: srcfiles tarball feature Message-ID: <20240206120300.GB25554@gnu.wildebeest.org> References: <20240202154953.587686-1-halamour@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Mon, Feb 05, 2024 at 07:24:33PM -0500, Aaron Merey wrote: > > diff --git a/NEWS b/NEWS > > index 0420d3b8..3391d6a1 100644 > > --- a/NEWS > > +++ b/NEWS > > @@ -1,3 +1,8 @@ > > +Version 0.191 (after 0.189) > > + > > +srcfiles: Can now fetch the source files of a DWARF/ELF file and > > + place them into a zip. > > + > > Version 0.190 "Woke!" > > > > CONTRIBUTING: Switch from real name policy to known identity policy. > > @@ -9,6 +14,9 @@ libelf: Add RELR support. > > > > libdw: Recognize .debug_[ct]u_index sections > > > > +srcfiles: added srcfiles tool that lists all the source files of a given > > + DWARF/ELF file. > > + > > readelf: Support readelf -Ds, --use-dynamic --symbol. > > Support .gdb_index version 9 > > This looks like a merge issue after the 0.190 release. I updated the version at the top and removed the duplicate entry under 0.190. > > diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx > > index 524be948..6b21f46f 100644 > > --- a/debuginfod/debuginfod.cxx > > +++ b/debuginfod/debuginfod.cxx > > @@ -2996,8 +2996,6 @@ dwarf_extract_source_paths (Elf *elf, set& debug_sourcefiles) > > > > if (comp_dir[0] == '\0' && cuname[0] != '/') > > { > > - // This is a common symptom for dwz-compressed debug files, > > - // where the altdebug file cannot be resolved. > > if (verbose > 3) > > obatched(clog) << "skipping cu=" << cuname << " due to empty comp_dir" << endl; > > continue; Was it intended to remove this comment? Cheers, Mark --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-NEWS-Update-version-number-and-remove-duplicate-0.19.patch" >From 71794afb54fd9668a02a361134f15180ce85f3ad Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Tue, 6 Feb 2024 12:53:54 +0100 Subject: [PATCH] NEWS: Update version number and remove duplicate 0.190 entry --- NEWS | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/NEWS b/NEWS index e2393e77..98dc78f5 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -Version 0.191 (after 0.189) +Version 0.191 (after 0.190) srcfiles: Can now fetch the source files of a DWARF/ELF file and place them into a zip. @@ -14,9 +14,6 @@ libelf: Add RELR support. libdw: Recognize .debug_[ct]u_index sections -srcfiles: added srcfiles tool that lists all the source files of a given - DWARF/ELF file. - readelf: Support readelf -Ds, --use-dynamic --symbol. Support .gdb_index version 9 -- 2.39.3 --AhhlLboLdkugWU4S--