From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 7F4243858D38 for ; Sat, 10 Feb 2024 00:20:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F4243858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F4243858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707524422; cv=none; b=jBip7HO/bzR/XH2yTtnqnLhxGJRlbmFYOMgVxqXnhXB6jy/lC+IQR4gHgOvYpFnh4b7IUHHOdCIT4pkA+V9ghLKO/oAC3G7c/PnuiSr90/YsaMzhUljJipfnYX3xMqC/06ksLvI9t1mrclOVDCrfNAqr2m31M62mMDB7dSELrTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707524422; c=relaxed/simple; bh=wBkzORDURgEvbNezVKRdyx56wc0x1fR99ObDWDaQREg=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=KC816ffFXMh3gIGpK1hI7Ofr6LDjd6JldpsTIo0Qle1fYc+bfvCwn0J9Nrawa8hs/92SNrZ9Ujhq6Ch415vmNr7tKJ5qL3A9mUEPncrMUs76PdTCJrGHu+GJ18GYt27wPMEtk/WCCTRM3zQrM4znjdG7hg6wcnjwfFH5+iCuwtg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 7EF403000673; Sat, 10 Feb 2024 01:20:18 +0100 (CET) Date: Sat, 10 Feb 2024 01:20:18 +0100 From: Mark Wielaard To: Ying Huang , elfutils-devel@sourceware.org Cc: yunqiang.su@oss.cipunited.com Subject: Re: [PATCH v2 1/5] strip: Adapt src/strip -o -f on mips Message-ID: <20240210002018.GB21691@gnu.wildebeest.org> References: <20231102065602.3128526-1-ying.huang@oss.cipunited.com> <20231102065602.3128526-2-ying.huang@oss.cipunited.com> <6ed6da0bf43349ad36a41da2fd05a8cd858261f9.camel@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ed6da0bf43349ad36a41da2fd05a8cd858261f9.camel@klomp.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ying, Sorry I keep postponing this. I don't have access to a mips64le box, the cfarm only has 64bit big endian mips machines. But the part I am struggling with is the relocation data conversion needed in the mips64le case. On Fri, Nov 03, 2023 at 01:18:12PM +0100, Mark Wielaard wrote: > On Thu, 2023-11-02 at 14:55 +0800, Ying Huang wrote: > > In mips64 little-endian, r_info consists of four byte fields(contains > > three reloc types) and a 32-bit symbol index. In order to adapt > > GELF_R_SYM and GELF_R_TYPE, need convert raw data to get correct symbol > > index and type. > > This part and the new backends hooks look OK. So to make progress could you split this part? Just a patch that adds the initial mips backend (and the libebl and libelfP.h parts). And another that introduces the libelf/elf_update and elf_getdata parts? Also could you take a look at CONTRIBUTING https://sourceware.org/cgit/elfutils/tree/CONTRIBUTING And provide a Signed-off-by line if you can/agree with that? Which MIPS variant(s) have you tested this against? Is it supposed to only work for mips64le? Or also maps64[be] and/or mips32 bits? Thanks, Mark