From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id CB5783858D34 for ; Sat, 24 Feb 2024 13:30:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB5783858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB5783858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708781437; cv=none; b=gHQpb4cIXYPiRGHAphEsh4mla/FCX92ZNiItO+HaHkRcXKJZCQqlal8u267LPCi2XkwjUT89P4Ic4UqHZZ9r3qcDRuOcvKXIHMkuSuZM1+bEvunt5k7L/HidchTxEk32loP3UxqrLOCwP3Uoijvhu1r4OnZFvJ1zBxQBJW4n08Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708781437; c=relaxed/simple; bh=jGRvkKc14j7MHy3a3/dgW2x4OYjCY2ZcBS0u//m61AA=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=chmk0DteTZpRsSouW5UkqKnhDJ+wIfiymzUWglbZ4XIGsolCNM+jnOdJ5Z9wem7RO3jCv0swhdHJZXK787pPTxIT/M5wo8fZYFnVxoUJAcmD9uYPgBByXQfk3GwkaDM1pF6LzoHXAGTI3g00oPkWobt2+uaROqtjzs6txCDXwpg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id C4B6F3000400; Sat, 24 Feb 2024 14:30:34 +0100 (CET) Date: Sat, 24 Feb 2024 14:30:34 +0100 From: Mark Wielaard To: Omar Sandoval Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH v2 3/4] libdw: Apply DWARF package file section offsets where appropriate Message-ID: <20240224133034.GA1353@gnu.wildebeest.org> References: <824d09edb009fd7cf3befcd871742f8089793c5e.1701854319.git.osandov@fb.com> <2f2aedc63120761bd82663442cef6a5330c80cd6.camel@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Omar, On Thu, Feb 22, 2024 at 04:53:19PM -0800, Omar Sandoval wrote: > On Fri, Feb 16, 2024 at 04:00:47PM +0100, Mark Wielaard wrote: > > The code and tests look good. run-varlocs.sh seems good, which seems to > > confirm DW_SECT_LOCLISTS is handled correctly (but why doesn't it need > > a hack similar to ranges in __libdw_formptr?). > > I think it's because ranges have the uniquely weird behavior in DWARF 4 > GNU Debug Fission that DW_AT_GNU_ranges_base is in the skeleton file but > used to interpret the split file. This was cleaned up for DWARF 5 (as I > documented in commit c9c9ffae725009b192b40e2d89035f353ae7055f), and > there was no base attribute for location lists in DWARF 4, so it's not > applicable. Thanks. I forgot about commit c9c9ffae7 "libdw: Handle DW_AT_ranges in split DWARF 5 skeleton in dwarf_ranges". That documents it nicely. Cheers, Mark