From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id ED1BF385840C for ; Thu, 29 Feb 2024 21:51:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED1BF385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED1BF385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709243464; cv=none; b=V2hPcLjqwgMoXO/CgPBr/TLmDDHxpQqa4/15UnHTohbPZYCiNoNX7CXoKUJu0AOaV4VKSqzgKjd0kX+vH4MAJyr79dCQ/HyHbFDo9y3yDUD7o91RBjVXpm2qgAUCdY1PhmZofcUjlJSgpYgSMQ4RLT02Ovqf0uwQ7gV96DxbDJI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709243464; c=relaxed/simple; bh=nm9d0aTSZKuSFx6AlG/A0tUYg7f3XJuDsmBZ8pBZaPU=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=HgtNjMf4uISMLpm+cYraUsT1XeXPbR4VqcOZBUKhUyGvVEdCxoldMBtjY/SknabPpGaQeMjrjN0PuZPE5jMYLz2xpbSmaDsYuyEaa04Sdil2pDwwZFQnCdVvYzTI0wiKgNUCA7kcCwC5JNq8xViWAPzRfGRVKXEwGt2ae3Tw9m0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 0A9263000400; Thu, 29 Feb 2024 22:51:01 +0100 (CET) Date: Thu, 29 Feb 2024 22:51:01 +0100 From: Mark Wielaard To: Aaron Merey Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH v2] Add __libdw_getdieranges Message-ID: <20240229215101.GC4502@gnu.wildebeest.org> References: <20240228011139.299975-1-amerey@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228011139.299975-1-amerey@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Aaron, On Tue, Feb 27, 2024 at 08:11:39PM -0500, Aaron Merey wrote: > __libdw_getdieranges builds an aranges list by iterating over each > CU and recording each address range. > > This function is an alternative to dwarf_getaranges. dwarf_getaranges > attempts to read address ranges from .debug_aranges, which might be > absent or incomplete. > > This patch replaces dwarf_getaranges with __libdw_getdieranges in > dwarf_addrdie and dwfl_module_addrdie. The existing tests in > run-getsrc-die.sh are also rerun with .debug_aranges removed from > the testfiles. > > https://sourceware.org/bugzilla/show_bug.cgi?id=22288 > https://sourceware.org/bugzilla/show_bug.cgi?id=30948 > > Signed-off-by: Aaron Merey > --- > > v2 addresses feedback from Mark's review: > https://sourceware.org/pipermail/elfutils-devel/2024q1/006853.html > > Avoid calling free on arangelist when it's possibly corrupt. > Run tests in run-getsrc-die.sh twice, once with .debug_aranges > present in the testfile and once with the section removed. This looks good to me. Please also add a NEWS entry about this. Thanks, Mark