From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 430453858C31 for ; Sun, 3 Mar 2024 00:05:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 430453858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 430453858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709424306; cv=none; b=shov++Gwmjxs3NVzxiz9ffMIEBM3HYUHNn/wnUdnqAFRtZb4pekIWeKn5vU9PEkrqa3gH1e3go1vbU3B5jgkHm77aONT8VjyOjqbiBqB2hooIv1Cp/MyoKOLsgdDaeAMmVtn/E196HmdyDr5+HHp8ZeeuDd5f+o3JSzuhUzR5yc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709424306; c=relaxed/simple; bh=vFOH1guOQiivru1oxpItbg5UZkSWD4Eof+pDy8ncWQg=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=Dw2ysE2AHxVn1WVWtyOlGml5VpFH5KzsYkLqqAkiCcdITS80SCml89g2JemgjXGU0uYhMDYf3D7QomY+ueNdrWR3hPi0wZcljg+ziDT7c5yaOlgoVrqBryx7nQHbCSPFiAFAPwqJGdf6JtKCNpEvfVkdwpNJblGzT4jMiyYeavU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 160323000648; Sun, 3 Mar 2024 01:05:04 +0100 (CET) Date: Sun, 3 Mar 2024 01:05:04 +0100 From: Mark Wielaard To: Martin Rodriguez Reboredo Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Setter for Dwfl's offline_next_address Message-ID: <20240303000504.GH13156@gnu.wildebeest.org> References: <20240301200405.87966-1-yakoyoku@gmail.com> <20240302204714.GG13156@gnu.wildebeest.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Martin, On Sat, Mar 02, 2024 at 07:43:38PM -0300, Martin Rodriguez Reboredo wrote: > On 3/2/24 17:47, Mark Wielaard wrote: > >On Fri, Mar 01, 2024 at 05:04:05PM -0300, Martin Rodriguez Reboredo wrote: > >>Added a new function dwfl_set_offline_next_addres which will set said > >>field from the Dwfl struct. This is a requirement for listing functions > >>from their addresses when using libdwfl offline, otherwise wrong symbols > >>are going to be returned. > > > >Could you give an example or testcase for this? > > This is intended for the Linux kernel perf tool so you might see it in > action when I publish the changes. In regards to testing I thought that > it was not needed due to the patch being a simple setter, but as > requested I can think something in the lines of. It would be interesting to see the perf tool patch. I don't understand the use case. So I assume perf currently does something which is wrong and with your patch calling this new dwfl_set_offline_next_addres it will do the right thing. That is what I was thinking of when asking for an example or testcase. I agree that on itself such a simple setter doesn't need a dedicated testcase. But maybe we can come up with a testcase given the right context. Cheers, Mark