From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 1F9DB3858C98 for ; Thu, 28 Mar 2024 13:45:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F9DB3858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F9DB3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711633541; cv=none; b=k7O+tjYpHy/wlcPf3BNcS1xEyhT8ERdoiggfqw4XNUI/WvsfmOj1FhtIWkGgqVVghefdm4m3E0sgs90OFekeJ/iItxikn51b+JOg0hlR3qGnJmCBJG1u9dTMcayemmrI4+Ty/99WJSgAS5c0KsbmgsKd8f3bxmJ2r7QzcZFuXwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711633541; c=relaxed/simple; bh=ZQ6YLFGaUbipbKcjrXJoaSKMiLbM7zbSa1Ew1hoxQqA=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=eHaQk6zaMLHQomIKujLOekntElbIQIqCGMfccVeIjxdpUS5zyr7yDAq104V1fpEF3TB5kshh50cC9+ANnKrP5t62nTNVl4jAyTQqyVut6o+svZi94gCKUB4dxori2mnkYsJQLdooZrnW0mim+ek0r/C4BS7QUTik0gFRaD97Z5s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 20861300046F; Thu, 28 Mar 2024 14:45:39 +0100 (CET) Date: Thu, 28 Mar 2024 14:45:39 +0100 From: Mark Wielaard To: Matheus Tavares Bernardino Cc: elfutils-devel@sourceware.org, bcain@quicinc.com, sidneym@quicinc.com Subject: Re: [PATCH 0/2] Add initial support for Hexagon Message-ID: <20240328134539.GK9427@gnu.wildebeest.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Matheus, On Thu, Mar 21, 2024 at 06:09:08PM -0300, Matheus Tavares Bernardino wrote: > The patches were inspired by > https://sourceware.org/cgit/elfutils/commit?id=13a4d1279c5b7847049ca3045d04f2705c45ce31 > > Related to: > https://lore.kernel.org/all/6498586d7d0ed112e6c44be98d439abc549653c7.camel@klomp.org/t/#u > > Matheus Tavares Bernardino (2): > Add support for Hexagon > Hexagon: implement machine flag check In general this looks good. It is the minimal backend support to get eu-strip --reloc-debug-sections and opening ET_REL (kernel module) debug files with dwfl that are automatically relocated. The only issue is that we like to keep libelf/elf.h synced with glibc elf/elf.h. Would it be possible/make sense to submit the elf.h changes to libc-alpha? Otherwise we should keep the new constants in some other file (maybe libelf/elf-knowledge.h)? Is there a public psabi for Hexagon? Then including an URL to it would be helpful. If possible you might want to include some simple test file. See tests/run-strip-reloc-ko.sh Thanks, Mark