From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id C427D3858D1E for ; Thu, 28 Mar 2024 20:29:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C427D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C427D3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::234 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711657771; cv=none; b=XgGs1BFOi3wZ/aSUDHtYTvPZOybPH9UoYC2po7Tm2RKD+ePqfzhqvn56XdvrLHKRIpjncS5KiGF/yNI/gTh1ypfVvLSWi9fxmz4RPFhm4W+XeYJi9CNt5CbcImKWMLljSuRKv807sArx+aBLOItgtOtrW/TFgFJtruMOdFmfdlg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711657771; c=relaxed/simple; bh=PEjrEV5DexPBkLEi7LATay9Jwf81YKubatCnhalBoKA=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=ntTNldf0JTz41rElSFE4u4VZgOBg0X7JQmXii0+/r8IZQEe6pDXGDGSSFF9fQGAC/99xFwr3cnT7bdPAiy2Kvy3ZSyWe5fXb/VW4Mxy9bM4lSLXwvY4eLWUl3SY6DUYIdEy6R0a7bYE5BDv+yhBB+kbi5eCbwUkqJqRIOiweNsc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2d23114b19dso18937091fa.3 for ; Thu, 28 Mar 2024 13:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711657768; x=1712262568; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fznGxCFYq2pCKV1Hi0YrmUvZCCKP/StUu6MEa4nVuNI=; b=Y4tjDrd7CSuZ5Z9VjmaqV9YRlf6C9fnQbUlGWOZ11oXXbjG5OcLGlmZN77J0K3UWra nOcrbOB0g9cbCpzunmq7xfnU/L1flYmqHo1xG+fkeGtYh+FAOQbsZ8iKuaRqUNZkOE9S DNZKP/UZ5tYr8gSeosnhPKugPIHSMIgwDHiJ3rVjOhHJx2w9rxKdyBXOA3s1LVKHCnFy zCakQy+SLwJjFPzkxC3WaCMIuAUKkWHX1UDySvcSwZfaZgqCAcalc1qGgJ6rdzap2T6t A4kyIwnh0JVfDhjGr+4doN6SGpchSYNudJa8Vppd371zRCsjeVDnTo4EF4ncQ0jJ4pYe rhIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711657768; x=1712262568; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fznGxCFYq2pCKV1Hi0YrmUvZCCKP/StUu6MEa4nVuNI=; b=wLZjvoesBnWu2tOhihOzfhPBjVmrTUhFW8idPA84xskotrlAnDZpH2OAtepA2XL3Dm DpkbZ4LHlbNzWV5vLRJx9SAQbtSBDDAd5pDnI2Po5RvRo+FIo3uoxnbZweX5QdtVNSdX Q6fgmBKcRcw2ByBjUI0VuxeJOEXQYT19txVPlvKzLNPcQ5FI+ggSg00yqRoPHeKV8JUv nFdqFo94oTxbq/4MwI+wpE8H2hpy0ILp44fy17qtk36+yHxyWWZiZso5+14GE/CY7Qql QNURVEvGM7pqesUavhE3Mtt2yO/ATMhC7OqEDOdN6y4N3ko0CkVtVk9/X63L9m14fkk9 /FDg== X-Gm-Message-State: AOJu0YxckZxW7J7nL1Syu5gFtfQL3iBAbjUkmyL36A5djrbDu2+KYWlB zkXr/+D14ePscBMc3B1X31UjRlLz+or3LJXawkj22Dw1cgr5pMGuUiw18JE+ X-Google-Smtp-Source: AGHT+IH9SaFE4YiXGCKql66wIyHHcjunGJQfndaT1+UGcBn3NQvF6wrP6pIM8RXNFV7vBDmArMFrCw== X-Received: by 2002:a19:a40b:0:b0:513:aa05:9fb0 with SMTP id q11-20020a19a40b000000b00513aa059fb0mr290258lfc.69.1711657767358; Thu, 28 Mar 2024 13:29:27 -0700 (PDT) Received: from mishin.sarov.local (95-37-71-41.dynamic.mts-nn.ru. [95.37.71.41]) by smtp.gmail.com with ESMTPSA id j9-20020a056512398900b00515a87e1288sm51806lfu.123.2024.03.28.13.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 13:29:26 -0700 (PDT) From: Maks Mishin X-Google-Original-From: Maks Mishin To: elfutils-devel@sourceware.org Cc: Maks Mishin Subject: [PATCH] segment: Fix dangling pointer Date: Thu, 28 Mar 2024 23:29:22 +0300 Message-Id: <20240328202922.7025-1-maks.mishinFZ@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pointer 'lookup_module' which is a field of the structure 'Dwfl' freed at segment.c:88 is not overwritten, but it is usually overwritten after free. Found by RASU JSC. Signed-off-by: Maks Mishin --- libdwfl/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libdwfl/segment.c b/libdwfl/segment.c index f6a3e84e..af76f2f8 100644 --- a/libdwfl/segment.c +++ b/libdwfl/segment.c @@ -86,6 +86,7 @@ insert (Dwfl *dwfl, size_t i, GElf_Addr start, GElf_Addr end, int segndx) if (unlikely (dwfl->lookup_module == NULL)) { free (old); + old = NULL; return true; } } -- 2.30.2