From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 536EC3858C31 for ; Fri, 5 Apr 2024 10:01:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 536EC3858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 536EC3858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712311316; cv=none; b=trJcXi7OO6SOFy2dDH8vx+EjCz+ZAKXbtbS2+ac4C8PI5Hzmr7n17Or0SzoFuTsi5xVRqX61fYcwXiP57r1SUlwTLVjTcbxZiHKdBr+9KYLP9y9s6UzIDZKJOY5/T2YX9v3mL6l0QwhwhV2pj5doNFL3SqsAcoHJPTV/uAsDslk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712311316; c=relaxed/simple; bh=rUWoA2Yx55tkz7FmCyxZ3By2K/2iOvYgBDtXz4lq8G8=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=hvrevt6MA1GM9IAgn3GP5tHRSBI5M/DU5BifmoELUFFYOQh4KbjtuPfkyvZXmPy7E2FYkTlrfo/+QnBm57afxpWd6qLgGbYa3ovqWvcPywDy8hjgLXU2PgnbcLmYDPrilrLxR4a2DOFJrV69rLuB/3RWbJnIA5AkP5U12OJLZAk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 48BF33000590; Fri, 5 Apr 2024 12:01:54 +0200 (CEST) Date: Fri, 5 Apr 2024 12:01:54 +0200 From: Mark Wielaard To: Ying Huang Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH v3 5/6] stack: Fix stack unwind failure on mips Message-ID: <20240405100154.GE1292@gnu.wildebeest.org> References: <20240305095122.889077-6-ying.huang@oss.cipunited.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305095122.889077-6-ying.huang@oss.cipunited.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ying, On Tue, Mar 05, 2024 at 05:51:21PM +0800, Ying Huang wrote: > From: Ying Huang > > Add abi_cfi, set_initial_registers_tid, unwind on mips. Sorry for reviewing out of order. But this one looked easy enough. The new abi_cfi, unwind and set_initial_registers_tid implementations looks correct (even though I don't really known MIPS). Pushed with the following ChangeLog entry added to the commit message. * backends/Makefile.am (mips_SRCS): Add mips_initreg.c, mips_cfi.c and mips_unwind.c. * backends/mips_init.c (mips_init): HOOK abi_cfi, unwind and set_initial_registers_tid. Set frame_nregs to 71. * backends/mips_cfi.c: New file. * backends/mips_initreg.c: Likewise. * backends/mips_unwind.c: Likewise. It would be helpful to see if you could come up with a testcase similar to the ones in tests/run-backtrace-core-.sh with tests/tests/backtrace..{exec,core}.bz2 so it can be tested from a non-MIPS setup (as opposed to the tests/run-backtrace-native.sh and tests/run-backtrace-native-core.sh tests). Thanks, Mark