From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id D38943858D34 for ; Fri, 5 Apr 2024 18:53:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D38943858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D38943858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712343197; cv=none; b=JnfPsB5uz2hFRFW7nXVMB+CoF699gAr7PShH9luyrJ8hTEQ+o30eS1pYV74cqiJJ3wlLwOTxIeuJkQykDg2PjgIruR3a2PYGBim6OIGhvzf7c+slqQn3KTD0JE3V8is449TvUOPGuAq5d6wBam+vLcsuQ1v2UUIYZZ5W3gWYKfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712343197; c=relaxed/simple; bh=m6OHB5o4Gn8Ju/5tB7J6yUr7nSZoay5zt2q3CJSDrOc=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=EmdugptRNa4wirmTt+JeE2yX7oHdYaKIG1Ey5eyBxfVe8gMisqAlbRLOEkRSQXg3mtZz9cmoAEsD42gsPa5HvXDjUmhLF8UR219lhXfxEMe5Vy2jnPDfv/YjjDvxHHWoNZLA5RYvgVBYEIMXrqJOC+vR5P5v/GXhkRBL46eia5I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2d87450361fso2186941fa.2 for ; Fri, 05 Apr 2024 11:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712343194; x=1712947994; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eyWyuHzsqymVwAGhldh1b2U/uSDHpN85Jx8SbRFCv24=; b=GOB23X3rrEh6wimaqdODnEJXW7GeEjfVJ2JfY1Dhl/c/gHMA23idH05ljvlCl1LiDn dTG2zzURctk9qxzUqy8JuTL66C8tyhb694HlKMEhp+EM9W9dsPR/JX0tAkILVcQo89Ra OWiOKq4y01QMeKfl+MknOYs5hAaTRGh69E1D42i+G5gGt8kk10G4a6lgTod7mxaBZRqj m74ilT6PMK+WujLwOLkguJMiRfKP+xKJwNfpjQXVkMQbim23RFHuGa4lGlt2JyOKTwuM hvnZ6+8Wq08XdGFZVUrqnipgs7i20TNU78EMyiMwDJg17Csrx+Eu8HtGhCzsGuv8Ur12 mBEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712343194; x=1712947994; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eyWyuHzsqymVwAGhldh1b2U/uSDHpN85Jx8SbRFCv24=; b=rQ6jusWXMdegnOauJ5CwOOIndzBPoI+WTL/Tp4aEWSxjsaOdT6xCRpFXWvizYc8oCU dyN+Dqf0QQopFuDv74sXdgbMS2jdo/D/LYMKDeHzf/ApAOlahE1WredbZoHJf98menFP H4aWSUNxIYk9Q4zykX2hFvv6tXE8uUZbhj7jovPD3jFu4hgueufYu8JJN4mHIRc2cRKi Uu65JNGaT88qNy4QS6+vbPZ6nx1YjxTYnPjrgChE46T0gk86ElMoxxVp6nR5kpAlRNVC zVi+npOuH4txEn2b4GPTN683dqeZ9Nef9Sa/6oSrQ7PLUDF5gtr+wO/pgPA+pmuUdBc7 74nQ== X-Gm-Message-State: AOJu0Yy+zSEswJuo3GmVj0dw2956/yFFs1C+8kq9cGxAUlCBR6rFbeAt 3AXJm5frTXMaxaOR0508JS8IfvtUKuCvFrHOmN19M+PvMPsqP4SG3vG1DT/e7UA= X-Google-Smtp-Source: AGHT+IHqAsmyeDs0V4nfcQ3nZ1e/9BGMC7Zo8jXCJ8cAjlg4Tqptgf0dJkVBtu+AWUczTTEoceVBMg== X-Received: by 2002:a2e:240e:0:b0:2d8:3eaf:86d2 with SMTP id k14-20020a2e240e000000b002d83eaf86d2mr1600282ljk.47.1712343192696; Fri, 05 Apr 2024 11:53:12 -0700 (PDT) Received: from mishin.sarov.local (95-37-71-41.dynamic.mts-nn.ru. [95.37.71.41]) by smtp.gmail.com with ESMTPSA id s24-20020a2ea718000000b002d8254a5f7dsm254476lje.71.2024.04.05.11.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 11:53:12 -0700 (PDT) From: Maks Mishin X-Google-Original-From: Maks Mishin To: elfutils-devel@sourceware.org Cc: Maks Mishin Subject: [PATCH] strip: Add check for elf_begin() result Date: Fri, 5 Apr 2024 21:53:03 +0300 Message-Id: <20240405185304.13584-1-maks.mishinFZ@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Return value of a function 'elf_begin' is dereferenced at strip.c:1166 without checking for NULL, but it is usually checked for this function. Found by RASU JSC. Signed-off-by: Maks Mishin --- src/strip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/strip.c b/src/strip.c index 6436443d..ebab4866 100644 --- a/src/strip.c +++ b/src/strip.c @@ -1153,7 +1153,9 @@ handle_elf (int fd, Elf *elf, const char *prefix, const char *fname, { /* Also create an ELF descriptor for the debug file */ debugelf = elf_begin (debug_fd, ELF_C_WRITE, NULL); - if (unlikely (gelf_newehdr (debugelf, gelf_getclass (elf)) == 0)) + ELF_CHECK (debugelf != NULL, _("cannot create ELF descriptor: %s")); + + if (unlikely (gelf_newehdr (debugelf, gelf_getclass (elf)) == 0)) { error (0, 0, _("cannot create new ehdr for file '%s': %s"), debug_fname, elf_errmsg (-1)); -- 2.30.2