From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0066F385840E for ; Thu, 9 May 2024 23:24:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0066F385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0066F385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715297091; cv=none; b=CI1xtLxfH5XP7e2qwokTVWHg4jSrPTjBkrBMlSbe+eQgI+9L7YqPCH+BfaUnfWdpLDRbL63VoyrIdKxSprnAtVnDgxqEFPHDd4+1UhnFDoGhKqN8jDzdci25X9UFHYksI6oqobBLbANwEwGKkXoK5q8sSWptBzp4TU2EPNrsKmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715297091; c=relaxed/simple; bh=tFKsRcHdftjiFbuhNGmsXx/XIMFrq7bi6vRKoQpPJEQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eKl+10SZAwfEDilbh3a4Dcivw2bGMh/5SVGJprWv+ddL/2mhtdxanYjxrh9XLSu2oV0gllNEd60Mly3g1JPlBnhar/pEq1k79Z3Ym6TlSDyIQMZhqk/cgaFIW7Bv+3o8vgS5JzCNaaFlovVYIUhMw5NC42OHRGag7Pd5Du8Cn4o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715297089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ivb1sqVxgfRq9wPj/UaqeD4ENCnCBpNkktYJ9M+CAEA=; b=T9jTaAiWzCW2q5l/eaeMtZOJBI69olmc+7CFjBnc4lJfodsueFK0QAOTeTjKsTEsL97vd1 4vg10bMCs9Xfm+4sG6stK7OjB2IJeVHcG60rDDgWuKDW7wTUhl3U6tGFEVHcVMAao07ikw Qw5Le9hSf8Rw5/90KLnWXQmZ52wXw2M= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-GQbFVD6FP_-8p66LxQ4SRg-1; Thu, 09 May 2024 19:24:45 -0400 X-MC-Unique: GQbFVD6FP_-8p66LxQ4SRg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED40F3806709; Thu, 9 May 2024 23:24:44 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.16.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52F8AC0D6B0; Thu, 9 May 2024 23:24:44 +0000 (UTC) From: Aaron Merey To: ldv@altlinux.org Cc: fche@redhat.com, elfutils-devel@sourceware.org, Aaron Merey Subject: [COMMITTED] Makefile.am: Avoid code duplication Date: Thu, 9 May 2024 19:24:26 -0400 Message-ID: <20240509232428.608482-1-amerey@redhat.com> In-Reply-To: <20240509225924.GA17241@altlinux.org> References: <20240509225924.GA17241@altlinux.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 9, 2024 at 6:59 PM Dmitry V. Levin wrote: > > On Thu, May 09, 2024 at 06:08:05PM -0400, Frank Ch. Eigler wrote: > > Hi - > > > > On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > > > Pushed as commit ca8ad4648197 > > > > > > What's the purpose of sending proposed patches to the mailing list > > > if reviews are silently ignored? > > > > Please be collegial and don't exaggerate. > > The fact is that the review was silently ignored, which is, from my point > of view, an extraordinary event, and I hereby raise the question why it > was ignored, and request that the issue pointed out in the review to be > properly addressed. Apologies Dmitry, your review was mistakenly caught in my mail client's spam filter and I did not see it until now. I agree that we can avoid some code duplication here. I'm going to push the following patch as obvious: --- Makefile.am | 33 ++++++--------------------------- 1 file changed, 6 insertions(+), 27 deletions(-) diff --git a/Makefile.am b/Makefile.am index a1f0b0c3..69af63ac 100644 --- a/Makefile.am +++ b/Makefile.am @@ -78,24 +78,16 @@ coverage: $(COVERAGE_OUTPUT_INDEX_HTML) @echo 'file://$(abs_builddir)/$(COVERAGE_OUTPUT_INDEX_HTML)' if LCOV_OLD -$(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE) - LC_ALL=C $(GENHTML) \ - --legend \ - --show-details \ - --rc=genhtml_branch_coverage=1 \ - --title='$(COVERAGE_TITLE)' \ - --prefix='$(abspath $(abs_srcdir))' \ - --prefix='$(realpath $(abs_srcdir))' \ - --prefix='$(abspath $(abs_builddir)/..)' \ - --prefix='$(realpath $(abs_builddir)/..)' \ - --output-directory='$(COVERAGE_OUTPUT_DIRECTORY)' \ - $< +ignore_errors = else +ignore_errors = --ignore-errors empty,negative +endif + $(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE) LC_ALL=C $(GENHTML) \ --legend \ --show-details \ - --ignore-errors empty,negative \ + $(ignore_errors) \ --rc=genhtml_branch_coverage=1 \ --title='$(COVERAGE_TITLE)' \ --prefix='$(abspath $(abs_srcdir))' \ @@ -104,30 +96,17 @@ $(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE) --prefix='$(realpath $(abs_builddir)/..)' \ --output-directory='$(COVERAGE_OUTPUT_DIRECTORY)' \ $< -endif -if LCOV_OLD $(COVERAGE_OUTPUT_FILE): $(LCOV) \ --capture \ --no-external \ --no-checksum \ + $(ignore_errors) \ --rc=lcov_branch_coverage=1 \ --gcov-tool='$(GCOV)' \ --output-file='$@' \ $(LCOV_DIRS_ARGS) -else -$(COVERAGE_OUTPUT_FILE): - $(LCOV) \ - --capture \ - --no-external \ - --no-checksum \ - --ignore-errors empty,negative \ - --rc=lcov_branch_coverage=1 \ - --gcov-tool='$(GCOV)' \ - --output-file='$@' \ - $(LCOV_DIRS_ARGS) -endif endif # Tell version 3.79 and up of GNU make to not build goals in this -- 2.43.0