From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Aaron Merey <amerey@redhat.com>
Cc: fche@redhat.com, elfutils-devel@sourceware.org
Subject: Re: [COMMITTED] Makefile.am: Avoid code duplication
Date: Fri, 10 May 2024 02:36:18 +0300 [thread overview]
Message-ID: <20240509233618.GB17241@altlinux.org> (raw)
In-Reply-To: <20240509232428.608482-1-amerey@redhat.com>
On Thu, May 09, 2024 at 07:24:26PM -0400, Aaron Merey wrote:
> On Thu, May 9, 2024 at 6:59 PM Dmitry V. Levin <ldv@altlinux.org> wrote:
> > On Thu, May 09, 2024 at 06:08:05PM -0400, Frank Ch. Eigler wrote:
> > > On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote:
> > > > > Pushed as commit ca8ad4648197
> > > >
> > > > What's the purpose of sending proposed patches to the mailing list
> > > > if reviews are silently ignored?
> > >
> > > Please be collegial and don't exaggerate.
> >
> > The fact is that the review was silently ignored, which is, from my point
> > of view, an extraordinary event, and I hereby raise the question why it
> > was ignored, and request that the issue pointed out in the review to be
> > properly addressed.
>
> Apologies Dmitry, your review was mistakenly caught in my mail client's
> spam filter and I did not see it until now.
>
> I agree that we can avoid some code duplication here. I'm going to push
> the following patch as obvious:
>
> ---
> Makefile.am | 33 ++++++---------------------------
> 1 file changed, 6 insertions(+), 27 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index a1f0b0c3..69af63ac 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -78,24 +78,16 @@ coverage: $(COVERAGE_OUTPUT_INDEX_HTML)
> @echo 'file://$(abs_builddir)/$(COVERAGE_OUTPUT_INDEX_HTML)'
>
> if LCOV_OLD
> -$(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE)
> - LC_ALL=C $(GENHTML) \
> - --legend \
> - --show-details \
> - --rc=genhtml_branch_coverage=1 \
> - --title='$(COVERAGE_TITLE)' \
> - --prefix='$(abspath $(abs_srcdir))' \
> - --prefix='$(realpath $(abs_srcdir))' \
> - --prefix='$(abspath $(abs_builddir)/..)' \
> - --prefix='$(realpath $(abs_builddir)/..)' \
> - --output-directory='$(COVERAGE_OUTPUT_DIRECTORY)' \
> - $<
> +ignore_errors =
> else
> +ignore_errors = --ignore-errors empty,negative
> +endif
> +
> $(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE)
> LC_ALL=C $(GENHTML) \
> --legend \
> --show-details \
> - --ignore-errors empty,negative \
> + $(ignore_errors) \
> --rc=genhtml_branch_coverage=1 \
> --title='$(COVERAGE_TITLE)' \
> --prefix='$(abspath $(abs_srcdir))' \
> @@ -104,30 +96,17 @@ $(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE)
> --prefix='$(realpath $(abs_builddir)/..)' \
> --output-directory='$(COVERAGE_OUTPUT_DIRECTORY)' \
> $<
> -endif
>
> -if LCOV_OLD
> $(COVERAGE_OUTPUT_FILE):
> $(LCOV) \
> --capture \
> --no-external \
> --no-checksum \
> + $(ignore_errors) \
> --rc=lcov_branch_coverage=1 \
> --gcov-tool='$(GCOV)' \
> --output-file='$@' \
> $(LCOV_DIRS_ARGS)
> -else
> -$(COVERAGE_OUTPUT_FILE):
> - $(LCOV) \
> - --capture \
> - --no-external \
> - --no-checksum \
> - --ignore-errors empty,negative \
> - --rc=lcov_branch_coverage=1 \
> - --gcov-tool='$(GCOV)' \
> - --output-file='$@' \
> - $(LCOV_DIRS_ARGS)
> -endif
> endif
>
> # Tell version 3.79 and up of GNU make to not build goals in this
That's much better, thanks!
--
ldv
prev parent reply other threads:[~2024-05-09 23:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 20:45 [PATCH] Fix 'make coverage' when used with lcov version 2.0+ Aaron Merey
2024-05-06 23:35 ` Dmitry V. Levin
2024-05-08 16:28 ` Aaron Merey
2024-05-09 21:53 ` Dmitry V. Levin
2024-05-09 22:08 ` Frank Ch. Eigler
2024-05-09 22:59 ` Dmitry V. Levin
2024-05-09 23:03 ` Frank Ch. Eigler
2024-05-10 0:16 ` Dmitry V. Levin
2024-05-10 1:37 ` Frank Ch. Eigler
2024-05-14 15:39 ` Mark Wielaard
2024-05-09 23:24 ` [COMMITTED] Makefile.am: Avoid code duplication Aaron Merey
2024-05-09 23:36 ` Dmitry V. Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509233618.GB17241@altlinux.org \
--to=ldv@altlinux.org \
--cc=amerey@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).