From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id D0E7B385840E for ; Thu, 9 May 2024 23:36:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0E7B385840E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=altlinux.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D0E7B385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.107.17.57 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715297780; cv=none; b=LgOOYf5r+5vgFDih7zGFWM12px/RfjmlGJaerYktL+YYnErE64GKUroF5Vff22pSHuwWrnF3KAgtMm8CQEcDG7lT/venkjRm2OSSTHqOSAijWbDOSguqj5Ia/7NaOHgbYia4QmwR3895o5rb76tMCBFAse5opVvIdtVLkfD0nng= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715297780; c=relaxed/simple; bh=pn4NpmStvhkh2oXQ/ncDTxmLGhLQSXww1GSYLe3JVZY=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=EWKQ8I+07vMOAeASZnvvarARWhUPtbgxNRmmqCtWr3ydsrMiHYn7swqo5maJz741ISfUEkx2pGEAFbF8Vhi4FxCtFshUu74eEN98brZfVXW87CaygXuvX7RlYcO1hmkC6w74FZ3NIK+v4sCCSAVbA67B1WQmin+f0q0VaSro+5I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 498AD72C90B; Fri, 10 May 2024 02:36:18 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 2D9CB7CCB3A; Fri, 10 May 2024 02:36:18 +0300 (IDT) Date: Fri, 10 May 2024 02:36:18 +0300 From: "Dmitry V. Levin" To: Aaron Merey Cc: fche@redhat.com, elfutils-devel@sourceware.org Subject: Re: [COMMITTED] Makefile.am: Avoid code duplication Message-ID: <20240509233618.GB17241@altlinux.org> References: <20240509225924.GA17241@altlinux.org> <20240509232428.608482-1-amerey@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240509232428.608482-1-amerey@redhat.com> X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 09, 2024 at 07:24:26PM -0400, Aaron Merey wrote: > On Thu, May 9, 2024 at 6:59 PM Dmitry V. Levin wrote: > > On Thu, May 09, 2024 at 06:08:05PM -0400, Frank Ch. Eigler wrote: > > > On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > > > > Pushed as commit ca8ad4648197 > > > > > > > > What's the purpose of sending proposed patches to the mailing list > > > > if reviews are silently ignored? > > > > > > Please be collegial and don't exaggerate. > > > > The fact is that the review was silently ignored, which is, from my point > > of view, an extraordinary event, and I hereby raise the question why it > > was ignored, and request that the issue pointed out in the review to be > > properly addressed. > > Apologies Dmitry, your review was mistakenly caught in my mail client's > spam filter and I did not see it until now. > > I agree that we can avoid some code duplication here. I'm going to push > the following patch as obvious: > > --- > Makefile.am | 33 ++++++--------------------------- > 1 file changed, 6 insertions(+), 27 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index a1f0b0c3..69af63ac 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -78,24 +78,16 @@ coverage: $(COVERAGE_OUTPUT_INDEX_HTML) > @echo 'file://$(abs_builddir)/$(COVERAGE_OUTPUT_INDEX_HTML)' > > if LCOV_OLD > -$(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE) > - LC_ALL=C $(GENHTML) \ > - --legend \ > - --show-details \ > - --rc=genhtml_branch_coverage=1 \ > - --title='$(COVERAGE_TITLE)' \ > - --prefix='$(abspath $(abs_srcdir))' \ > - --prefix='$(realpath $(abs_srcdir))' \ > - --prefix='$(abspath $(abs_builddir)/..)' \ > - --prefix='$(realpath $(abs_builddir)/..)' \ > - --output-directory='$(COVERAGE_OUTPUT_DIRECTORY)' \ > - $< > +ignore_errors = > else > +ignore_errors = --ignore-errors empty,negative > +endif > + > $(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE) > LC_ALL=C $(GENHTML) \ > --legend \ > --show-details \ > - --ignore-errors empty,negative \ > + $(ignore_errors) \ > --rc=genhtml_branch_coverage=1 \ > --title='$(COVERAGE_TITLE)' \ > --prefix='$(abspath $(abs_srcdir))' \ > @@ -104,30 +96,17 @@ $(COVERAGE_OUTPUT_INDEX_HTML): $(COVERAGE_OUTPUT_FILE) > --prefix='$(realpath $(abs_builddir)/..)' \ > --output-directory='$(COVERAGE_OUTPUT_DIRECTORY)' \ > $< > -endif > > -if LCOV_OLD > $(COVERAGE_OUTPUT_FILE): > $(LCOV) \ > --capture \ > --no-external \ > --no-checksum \ > + $(ignore_errors) \ > --rc=lcov_branch_coverage=1 \ > --gcov-tool='$(GCOV)' \ > --output-file='$@' \ > $(LCOV_DIRS_ARGS) > -else > -$(COVERAGE_OUTPUT_FILE): > - $(LCOV) \ > - --capture \ > - --no-external \ > - --no-checksum \ > - --ignore-errors empty,negative \ > - --rc=lcov_branch_coverage=1 \ > - --gcov-tool='$(GCOV)' \ > - --output-file='$@' \ > - $(LCOV_DIRS_ARGS) > -endif > endif > > # Tell version 3.79 and up of GNU make to not build goals in this That's much better, thanks! -- ldv