Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

["Dmitry V. Levin" <ldv@altlinux.org>]

Hi Frank,

On Thu, May 09, 2024 at 07:03:47PM -0400, Frank Ch. Eigler wrote:
> Hi -
> 
> > > > What's the purpose of sending proposed patches to the mailing list
> > > > if reviews are silently ignored?
> > > 
> > > Please be collegial and don't exaggerate.
> > 
> > The fact is that the review was silently ignored, which is, from my point
> > of view, an extraordinary event, 
> 
> The review *singular*.  And you can't know whether it was ignored, or
> never received or missed or considered.

Well, even if it happened unintentionally, it was ignored just the same
as if it happened on purpose.  I hope the technical reasons for that
are now fixed, and won't cause any problems next time.

> > [...] and request that the issue pointed out in the review to be
> > properly addressed.
> 
> May I suggest asking for that in a less accusatory and exaggerated
> fashion next time.  Note also that being "properly addressed" is up to
> the discretion of the maintainers - one of whom is Aaron.

Please note that elfutils is a community project, and the code in question
was contributed a few years ago by myself, see commit
2a16a0fc7e353f8fcfc27a57710e008840297847.
I'm glad the code duplication issue is now resolved.

Frank, please reconsider your approach.  Your comments are not just
unhelpful and unproductive, they can actually discourage contributors
which is the last thing one wants in a free software project.


-- 
ldv