From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] debuginfod: Check result of calling MHD_add_response_header.
Date: Wed, 01 Dec 2021 13:24:07 +0100 [thread overview]
Message-ID: <2073a7a76be1c0c04bbb88d2b442e4a7a975d466.camel@klomp.org> (raw)
In-Reply-To: <20211201120205.GD17988@redhat.com>
H Frank,
On Wed, 2021-12-01 at 07:02 -0500, Frank Ch. Eigler wrote:
> Although unlikely the MHD_add_response_header can fail for
> > various reasons. If it fails something odd is going on.
> > So check we can actually add a response header before using
> > the response.
>
> ISTM it is okay to send the response object (the body), even if
> something goes wrong with adding optional headers later.
OK, so log error, but proceed sending the response with the data
already added. I'll update my patch to do that instead. I don't really
think this will really fail often (or at all). But if it does, it would
be good to be able to catch it.
Thanks,
Mark
prev parent reply other threads:[~2021-12-01 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 11:38 Mark Wielaard
2021-12-01 12:02 ` Frank Ch. Eigler
2021-12-01 12:24 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2073a7a76be1c0c04bbb88d2b442e4a7a975d466.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).