From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id B3BDC3858012 for ; Fri, 13 Nov 2020 14:09:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B3BDC3858012 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-1YO8zauVMe2pEb9AeU0wXw-1; Fri, 13 Nov 2020 09:09:43 -0500 X-MC-Unique: 1YO8zauVMe2pEb9AeU0wXw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1881918C9F41; Fri, 13 Nov 2020 14:09:42 +0000 (UTC) Received: from [10.36.113.32] (ovpn-113-32.ams2.redhat.com [10.36.113.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56D4C19C66; Fri, 13 Nov 2020 14:09:41 +0000 (UTC) Subject: Re: Removing gnu99 constructs from elfutils To: Mark Wielaard , elfutils-devel@sourceware.org References: <20201112150412.2137981-1-tbaeder@redhat.com> From: =?UTF-8?Q?Timm_B=c3=a4der?= Message-ID: <2175f679-4c78-7fb9-ef2e-1904ea57005e@redhat.com> Date: Fri, 13 Nov 2020 15:09:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 14:09:47 -0000 On 13/11/2020 13:38, Mark Wielaard wrote: > OK. The mail subject is a little misleading, this is far from turning > the code base into ISO C99. gnu99 is much more than those two features: > https://gcc.gnu.org/onlinedocs/gcc/C-Extensions.html Right, I wasn't trying to get rid of all the gnu99 features used in the code base. > > Personally I think it would be nicer if compilers that claim to support > gnu99 implemented them all instead of just cherry-picking some. I agree, but even if clang stops claiming it supports gnu99, we still need to stop using those features if elfutils should be compile-able with clang. > Thanks for splitting this up into easily reviewable patches. I'll go > over them next week. I haven't immediately seen anything objectionable, > so I think your approach is good. > > Maybe you can work together with Navin to untangle his large patch in a > similar way. I have a local working build now and around 45 patches. I did run into the test suite failures Navin described however and am now looking at what exactly is wrong there. Next week sounds fine with me, I'll wait for feedback on the general approach before posting the rest of the patches. Thanks, Timm -- Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander