From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 2C9753857C60 for ; Fri, 27 Aug 2021 15:11:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C9753857C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7EF1E3000ADC; Fri, 27 Aug 2021 17:11:28 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 0590D413CE32; Fri, 27 Aug 2021 17:11:27 +0200 (CEST) Message-ID: <2289ae593536fd3570a63f023a859e86fdbeb8f7.camel@klomp.org> Subject: Re: [PATCH] lib: remove usage of `sys/cdefs.h` From: Mark Wielaard To: Saleem Abdulrasool , =?ISO-8859-1?Q?=C9rico?= Nogueira Cc: elfutils-devel@sourceware.org Date: Fri, 27 Aug 2021 17:11:26 +0200 In-Reply-To: References: <20210820182008.2841402-1-abdulras@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 15:11:31 -0000 Hi Saleem, On Mon, 2021-08-23 at 08:23 -0700, Saleem Abdulrasool via Elfutils- devel wrote: > Yes, it seems that `STROF` can be removed as well. However, I'd > prefer to do that in a separate change. This way the change is a > separate clean up rather than just happens to come along with the > sys/cdefs.h removal. Please do post a followup patch. I added a ChangeLog entry (yes, we still do those, although it seems very little people share my enthusiasm for them, so maybe we should drop them, at least as separate file entries) and pushed your patch as: commit d390548df1942e98a1d836269a5e41ba52e121f1 Author: Saleem Abdulrasool Date: Fri Aug 20 18:20:08 2021 +0000 lib: remove usage of `sys/cdefs.h` =20 This header is a BSD header that is also available in glibc. However, this is a not a standard C header and was used for `__CONCAT`. Because this is not a standard header, not all libc implementations provide the header. Remove the usage of the header and always use the previously fallback path. This is needed in order to build with musl. =20 Signed-off-by: Saleem Abdulrasool Thanks, Mark P.S. You might want to use git send-email --from=3D... to add an extra >From author line. Sadly the mailinglist mangles the original From in some cases causing git am to apply a patch with the mailinglist as author (sorry about that).