From: Mark Wielaard <mark@klomp.org>
To: Jonathon Anderson <jma14@rice.edu>
Cc: elfutils-devel@sourceware.org, Srdan Milakovic <sm108@rice.edu>
Subject: Re: [PATCH] lib + libdw: Add and use a concurrent version of the dynamic-size hash table.
Date: Thu, 07 Nov 2019 11:07:00 -0000 [thread overview]
Message-ID: <27820824019c4966ca81c7d65d6c68581633aa60.camel@klomp.org> (raw)
In-Reply-To: <20191104163932.21891-1-jma14@rice.edu>
Hi,
On Mon, 2019-11-04 at 10:39 -0600, Jonathon Anderson wrote:
> Apologies, I talked with Srdan in person and forgot to relay the
> message. He gave me an updated version of the hash table that handles
> that issue (and another previously harmless typo).
This looks good. I am about to commit this, but would like to confirm
that the fixes in this change are as intended.
Looking at the difference between the previous version and this one, it
incorporates my simplification of FIND and lookup functions. And fixes
it by making insert_helper consistently return -1 when the value was
already inserted (hash == hval). And it fixes an issue where we were
using the the table entry val_ptr instead of the hashval as hash (was
that the typo? it didn't look harmless).
Sorry for being pedantic about this. But it is really tricky code, so I
want to be 100% sure all the above changes were intended.
Thanks,
Mark
next prev parent reply other threads:[~2019-11-07 11:07 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 19:24 [PATCH] libdw: add thread-safety to dwarf_getabbrev() Jonathon Anderson
2019-08-21 11:16 ` Mark Wielaard
2019-08-21 14:21 ` Jonathon Anderson
2019-08-23 21:22 ` Mark Wielaard
[not found] ` <1566396518.5389.0@smtp.mail.rice.edu>
2019-08-23 18:25 ` Mark Wielaard
2019-08-23 22:36 ` Jonathon Anderson
2019-08-21 21:50 ` Mark Wielaard
2019-08-21 22:01 ` Mark Wielaard
2019-08-21 22:21 ` Jonathon Anderson
2019-08-23 21:26 ` Mark Wielaard
2019-08-24 23:24 ` Mark Wielaard
2019-08-25 1:11 ` Jonathon Anderson
2019-08-25 10:05 ` Mark Wielaard
2019-08-26 1:25 ` Jonathon Anderson
2019-08-26 13:18 ` Mark Wielaard
2019-08-26 13:37 ` Jonathon Anderson
2019-08-27 3:52 ` Jonathon Anderson
2019-08-29 13:16 ` Mark Wielaard
2019-08-29 13:16 ` [PATCH 2/3] libdw: Rewrite the memory handler to be thread-safe Mark Wielaard
2019-10-21 16:13 ` Mark Wielaard
2019-10-21 16:28 ` Jonathon Anderson
2019-10-21 18:00 ` Mark Wielaard
2019-10-24 16:47 ` Mark Wielaard
2019-08-29 13:16 ` [PATCH 3/3] lib + libdw: Add and use a concurrent version of the dynamic-size hash table Mark Wielaard
2019-10-25 23:50 ` Mark Wielaard
2019-10-26 4:11 ` Jonathon Anderson
2019-10-27 16:13 ` Mark Wielaard
2019-10-27 17:49 ` Jonathon Anderson
2019-10-28 14:08 ` Mark Wielaard
2019-10-28 20:12 ` Mark Wielaard
2019-11-04 16:21 ` Mark Wielaard
2019-11-04 16:19 ` Mark Wielaard
2019-11-04 17:03 ` [PATCH] " Jonathon Anderson
2019-11-07 11:07 ` Mark Wielaard [this message]
2019-11-07 15:25 ` Jonathon Anderson
2019-11-08 14:07 ` Mark Wielaard
2019-11-08 15:29 ` Jonathon Anderson
2019-11-10 23:24 ` Mark Wielaard
2019-11-11 23:38 ` Jonathon Anderson
2019-11-12 21:45 ` Mark Wielaard
2019-08-29 13:16 ` [PATCH 1/3] Add some supporting framework for C11-style atomics Mark Wielaard
2019-10-22 16:31 ` Mark Wielaard
2019-10-26 10:54 ` [PATCH] libdw: add thread-safety to dwarf_getabbrev() Florian Weimer
2019-10-26 12:06 ` Mark Wielaard
2019-10-26 16:14 ` Florian Weimer
2019-10-26 16:45 ` Jonathon Anderson
2019-10-26 16:50 ` Florian Weimer
2019-10-26 22:53 ` Mark Wielaard
2019-10-27 8:59 ` Florian Weimer
2019-10-27 18:11 ` Jonathon Anderson
2019-10-27 18:44 ` Florian Weimer
2019-10-26 22:50 ` Mark Wielaard
2019-10-27 0:56 ` Jonathon Anderson
2019-10-28 13:26 ` Mark Wielaard
2019-10-28 15:32 ` Jonathon Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27820824019c4966ca81c7d65d6c68581633aa60.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=jma14@rice.edu \
--cc=sm108@rice.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).