From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 4A05538532C0 for ; Fri, 25 Nov 2022 13:06:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A05538532C0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4D31F21AE2; Fri, 25 Nov 2022 13:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1669381561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T/YIYmkMa0S/335hywpM/eZsAiiwkMN7cVAjhyVp+Ys=; b=UkU+M3b3ft1G40Y6V/YNv8Vb5lwncCe7n5awQTnxDZ9w0JBMIJW81rktIwVaZv3WpjQge/ Vcyd+zfdHGpRGjtXYlJGXeRZzUK8HbRDnzqJJbUyLMcYkz4+tgr/0VUHIlZ/E7tcb2x05c GJ9vVhUPIFUSRCkvHFwyaIcEaoYN0ZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1669381561; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T/YIYmkMa0S/335hywpM/eZsAiiwkMN7cVAjhyVp+Ys=; b=KamshZZZc0U9OeXtfQx+5K0J/9eD9GJ/Oo0nQ4O8TTbHP8UHpEg2VieOBBm34G+u+j3wVk HvAPsJ/Y/dcqPKBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3AAFE13A08; Fri, 25 Nov 2022 13:06:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hUopDbm9gGOrQQAAMHmgww (envelope-from ); Fri, 25 Nov 2022 13:06:01 +0000 Message-ID: <28991dcc-34eb-a6c5-b753-39c24933dded@suse.cz> Date: Fri, 25 Nov 2022 14:06:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] libebl: Do not require EI_OSABI for IFUNC. Content-Language: en-US To: Mark Wielaard , elfutils-devel@sourceware.org References: <87cbeb0f-a329-ed9f-2d8b-35277cd0e5e6@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/24/22 13:33, Mark Wielaard wrote: > Hi Martin, > > On Thu, 2022-11-24 at 13:23 +0100, Martin Liška wrote: >> Similar fix to: >> https://sourceware.org/bugzilla/show_bug.cgi?id=29718 >> >> Ready for master? > > Assuming runtime, glibc/ld.so, accepts this without EI_OSABI set to > ELFOSABI_LINUX, it seems ok to print it as GNU_IFUNC. > >> else if (symbol == STT_GNU_IFUNC >> && ebl != NULL >> - && (ident = elf_getident (ebl->elf, NULL)) != NULL >> - && ident[EI_OSABI] == ELFOSABI_LINUX) >> - return "GNU_IFUNC"; >> + && (ident = elf_getident (ebl->elf, NULL)) != NULL) >> + return "GNU_IFUNC"; /* Ignore EI_OSABI >> + as STT_GNU_IFUNC is a reserved name. */ > > Note that you technically also don't need the elf_getident call > anymore, except as sanity check that the ELF header can be read > properly. > > OK, with and without that change. Sorry, I decided to scratch this as it violates the standard: https://sourceware.org/bugzilla/show_bug.cgi?id=29718#c6 Cheers, Martin > > Cheers, > > Mark