From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6143 invoked by alias); 21 Aug 2019 21:50:48 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 6132 invoked by uid 89); 21 Aug 2019 21:50:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-19.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-19.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 21:50:46 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 751C3300073F; Wed, 21 Aug 2019 23:50:42 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 2EB39400E8B8; Wed, 21 Aug 2019 23:50:42 +0200 (CEST) Message-ID: <2bc341cf5c29db5120c5d0420a16fa337b8bfc0e.camel@klomp.org> Subject: Re: [PATCH] libdw: add thread-safety to dwarf_getabbrev() From: Mark Wielaard To: Jonathon Anderson , elfutils-devel@sourceware.org Cc: Srdan Milakovic Date: Wed, 21 Aug 2019 21:50:00 -0000 In-Reply-To: <1565983469.1826.0@smtp.mail.rice.edu> References: <1565983469.1826.0@smtp.mail.rice.edu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00121.txt.bz2 On Fri, 2019-08-16 at 14:24 -0500, Jonathon Anderson wrote: > diff --git a/ChangeLog b/ChangeLog > index bed3999f..93907ddd 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2019-08-15 Jonathon Anderson > + > + * configure.ac: Add new --enable-valgrind-annotations > + * configure.ac: Add new --with-valgrind (headers only) > + > 2019-08-13 Mark Wielaard >=20 > * configure.ac: Set version to 0.177. > diff --git a/configure.ac b/configure.ac > index c443fa3b..c5406b44 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -323,6 +323,35 @@ if test "$use_valgrind" =3D yes; then > fi > AM_CONDITIONAL(USE_VALGRIND, test "$use_valgrind" =3D yes) >=20 > +AC_ARG_WITH([valgrind], > +AS_HELP_STRING([--with-valgrind],[include directory for Valgrind=20 > headers]), > +[with_valgrind_headers=3D$withval], [with_valgrind_headers=3Dno]) > +if test "x$with_valgrind_headers" !=3D xno; then > + save_CFLAGS=3D"$CFLAGS" > + CFLAGS=3D"$CFLAGS -I$with_valgrind_headers" > + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ > + #include > + int main() { return 0; } > + ]])], [ HAVE_VALGRIND_HEADERS=3D"yes" > + CFLAGS=3D"$save_CFLAGS -I$with_valgrind_headers" ], > + [ AC_MSG_ERROR([invalid valgrind include directory:=20 > $with_valgrind_headers]) ]) > +fi > + > +AC_ARG_ENABLE([valgrind-annotations], > +AS_HELP_STRING([--enable-valgrind-annotations],[insert extra=20 > annotations for better valgrind support]), > +[use_vg_annotations=3D$enableval], [use_vg_annotations=3Dno]) > +if test "$use_vg_annotations" =3D yes; then > + if test "x$HAVE_VALGRIND_HEADERS" !=3D "xyes"; then > + AC_MSG_CHECKING([whether Valgrind headers are available]) > + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ > + #include > + int main() { return 0; } > + ]])], [ AC_MSG_RESULT([yes]) ], > + [ AC_MSG_ERROR([valgrind annotations requested but no=20 > headers are available]) ]) > + fi > +fi > +AM_CONDITIONAL(USE_VG_ANNOTATIONS, test "$use_vg_annotations" =3D yes) > + > AC_ARG_ENABLE([install-elfh], > AS_HELP_STRING([--enable-install-elfh],[install elf.h in include dir]), > [install_elfh=3D$enableval], [install_elfh=3Dno]) > @@ -668,6 +697,7 @@ AC_MSG_NOTICE([ > OTHER FEATURES > Deterministic archives by default : ${default_ar_deterministic} > Native language support : ${USE_NLS} > + Extra Valgrind annotations : ${use_vg_annotations} >=20 > EXTRA TEST FEATURES (used with make check) > have bunzip2 installed (required) : ${HAVE_BUNZIP2} This part sets up things so we can include extra valgrind annotations, but then doesn't seem to be used. It sounds useful though, because valgrind/helgrind won't know about any of the atomics. Is this something you added, but then removed? Thanks, Mark P.S. It looks like something decided to add some line breaks in the patch so that it doesn't easily apply. It isn't hard to fixup, but you might want to consider submitting using git send-email or attaching the result of git format-patch instead of putting the patch in the message body.