public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] config: Add a versioned requires on libs for elfutils-debuginfod-client
@ 2022-04-07 13:29 Mark Wielaard
  2022-04-12 13:24 ` Mark Wielaard
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2022-04-07 13:29 UTC (permalink / raw)
  To: elfutils-devel; +Cc: Mark Wielaard

elfutils-debuginfod-client contains the debuginfod-client binary
which is uses libelf and libdw. Add an explicit versioned requires
on elfutils-libs so they will always be in sync like done with all
other inter sub package dependencies.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 config/ChangeLog        | 5 +++++
 config/elfutils.spec.in | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/config/ChangeLog b/config/ChangeLog
index acbaaa88..be27373f 100644
--- a/config/ChangeLog
+++ b/config/ChangeLog
@@ -1,3 +1,8 @@
+2022-04-07  Mark Wielaard  <mark@klomp.org>
+
+	* elfutils.spec.in (debuginfod-client): Add an explicit requires
+	on elfutils-libs.
+
 2021-11-10  Mark Wielaard  <mark@klomp.org>
 
 	* elfutils.spec.in: Update for 0.186.
diff --git a/config/elfutils.spec.in b/config/elfutils.spec.in
index aac0dffc..f4b26f03 100644
--- a/config/elfutils.spec.in
+++ b/config/elfutils.spec.in
@@ -141,6 +141,8 @@ profiling) of processes.
 %package debuginfod-client
 Summary: Library and command line client for build-id HTTP ELF/DWARF server
 License: GPLv3+ and (GPLv2+ or LGPLv3+)
+# For debuginfod-find binary
+Requires: elfutils-libs = %{version}-%{release}
 
 %package debuginfod-client-devel
 Summary: Libraries and headers to build debuginfod client applications
-- 
2.18.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] config: Add a versioned requires on libs for elfutils-debuginfod-client
  2022-04-07 13:29 [PATCH] config: Add a versioned requires on libs for elfutils-debuginfod-client Mark Wielaard
@ 2022-04-12 13:24 ` Mark Wielaard
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2022-04-12 13:24 UTC (permalink / raw)
  To: elfutils-devel

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

On Thu, 2022-04-07 at 15:29 +0200, Mark Wielaard wrote:
> elfutils-debuginfod-client contains the debuginfod-client binary
> which is uses libelf and libdw. Add an explicit versioned requires
> on elfutils-libs so they will always be in sync like done with all
> other inter sub package dependencies.

I pushed a slight variant of this that also adds an explicit versioned
requirement on elfutils-libelf. Which isn't strictly necessary because
that is already a versioned requires of elfutils-libs. But tools like
rpminspect check for these direct dependencies only.

See attached.

Cheers,

Mark

[-- Attachment #2: 0001-config-Add-versioned-requires-on-libs-libelf-for-deb.patch --]
[-- Type: text/x-patch, Size: 1622 bytes --]

From 55e67ce44439f7b4a97d268cd7da261b9bda3277 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Thu, 7 Apr 2022 15:16:41 +0200
Subject: [PATCH] config: Add versioned requires on libs/libelf for
 debuginfod-client

elfutils-debuginfod-client contains the debuginfod-client binary
which is uses libelf and libdw. Add explicit versioned requires
on elfutils-libs and elfutils-libelf so they will always be in sync
like done with all other inter sub package dependencies.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 config/ChangeLog        | 5 +++++
 config/elfutils.spec.in | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/config/ChangeLog b/config/ChangeLog
index acbaaa88..d2d61c6c 100644
--- a/config/ChangeLog
+++ b/config/ChangeLog
@@ -1,3 +1,8 @@
+2022-04-07  Mark Wielaard  <mark@klomp.org>
+
+	* elfutils.spec.in (debuginfod-client): Add an explicit requires
+	on elfutils-libs and elfutils-libelf.
+
 2021-11-10  Mark Wielaard  <mark@klomp.org>
 
 	* elfutils.spec.in: Update for 0.186.
diff --git a/config/elfutils.spec.in b/config/elfutils.spec.in
index aac0dffc..49e5a016 100644
--- a/config/elfutils.spec.in
+++ b/config/elfutils.spec.in
@@ -141,6 +141,9 @@ profiling) of processes.
 %package debuginfod-client
 Summary: Library and command line client for build-id HTTP ELF/DWARF server
 License: GPLv3+ and (GPLv2+ or LGPLv3+)
+# For debuginfod-find binary
+Requires: elfutils-libs = %{version}-%{release}
+Requires: elfutils-libelf = %{version}-%{release}
 
 %package debuginfod-client-devel
 Summary: Libraries and headers to build debuginfod client applications
-- 
2.18.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-12 13:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 13:29 [PATCH] config: Add a versioned requires on libs for elfutils-debuginfod-client Mark Wielaard
2022-04-12 13:24 ` Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).