From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dd14210.kasserver.com (dd14210.kasserver.com [85.13.138.83]) by sourceware.org (Postfix) with ESMTPS id 9439E38582B0 for ; Thu, 7 Jul 2022 16:58:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9439E38582B0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=milianw.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=milianw.de Received: from milian-workstation.localnet (p54a1bbed.dip0.t-ipconnect.de [84.161.187.237]) by dd14210.kasserver.com (Postfix) with ESMTPSA id 4F7FD240679; Thu, 7 Jul 2022 18:58:57 +0200 (CEST) From: Milian Wolff To: Aaron Merey Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Introduce public dwfl_get_debuginfod_client API Date: Thu, 07 Jul 2022 18:58:52 +0200 Message-ID: <3483133.myl3dWKsmy@milian-workstation> In-Reply-To: References: <3003776.hSsdSGGBHf@milian-workstation> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart118373959.CyqrhBlz6A"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Spamd-Bar: ---- X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 16:59:01 -0000 --nextPart118373959.CyqrhBlz6A Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Milian Wolff To: Aaron Merey Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Introduce public dwfl_get_debuginfod_client API Date: Thu, 07 Jul 2022 18:58:52 +0200 Message-ID: <3483133.myl3dWKsmy@milian-workstation> MIME-Version: 1.0 On Donnerstag, 7. Juli 2022 18:40:05 CEST Aaron Merey wrote: > Hi Milian, > > On Thu, Jul 7, 2022 at 10:47 AM Milian Wolff wrote: > > Dwfl can use debuginfod internally, which was so far totally opaque > > to the outside. While the functionality is great for users of the > > dwfl API, the long wait times induced by downloading of data over > > debuginfod lead to complaints by endusers. To offer them a bit more > > insight into the internal ongoings, one can now use e.g. > > `debuginfod_set_progressfn` on the handle returned by > > `dwfl_get_debuginfod_client` to report download progress. > > > > Rename get_client to dwfl_get_debuginfod_client and make it public. > > Unconditionally compile debuginfod-client.c and stub the new public > > function and always return NULL when debuginfod integration was > > disabled. > > Thanks for the patch. This looks ok and I was able to successfully > run the testsuite with and without debuginfod enabled. > > > @@ -70,7 +70,7 @@ libdwfl_a_SOURCES = dwfl_begin.c dwfl_end.c dwfl_error.c > > dwfl_version.c \ > > Some line breaks may have accidentally snuck into the patch. I had to > manually remove the line break right after "dwfl_error.c" for git to > apply the patch without error. Ah yes sorry, I did not think about that when copy'n'pasting the git format- patch output into my mail client. Should I resend with the line breaks fixed? Cheers -- Milian Wolff mail@milianw.de http://milianw.de --nextPart118373959.CyqrhBlz6A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEezawi1aUvUGg3A1+8zYW/HGdOX8FAmLHEMwACgkQ8zYW/HGd OX/+oA/9G6MtT1ntUcXod61Jy8o7aFeanpcZmMbmRbMdBx1UQDHhx/aS7+UR/C5+ vTgZU0h6dDP2AkacGdckbj4f2uj4VMxhjo0aVKKm7UYZ/XmLEKT/7JGxePcZRXqF BQHR73QxeoaG1pjt7+KSvuOQhLxc49uGPIfEfmkfoiamsFtcBMZBGev5tvN3c60h Hdrk+hBUD65eceyBgozk1BD/7OOiQuArF1vkYZPJVyybDQ+qAjSCpZD2g7YVgtA9 CRDClczvLnF+Q6ytilsWMS/k4p9OkGw36Dvo52Rz4ShW9LV9L/B+tWAIzTttnweZ PNC8SVJGA42TKyZO/vDFGbC4FHQygJCXU68fjo/4HHIxXvpK8PhJHznQClgZzoZv f5XvD07+OGPXAbMNq2E/cyj+r5LqtSgHU3l3tAw04Itf+Eo66P3WYJu+N+zVqNyA iaKJr9T4QtkLLTH4dUlaeezyoe7ZCE1slu1McIbsiSO/TQmaetTrNUplPgLOCU6v FBOnl+gtz/6kHN/lrKvdb+QdjfJe2qnfDSiRKBE65/wN0URI/U3MVwStEYlccySm HG+njY6SrNbxZ9ndwwFjWHa7CmhTyvhAOJ1wssi9WrC+MV3gtjVCfYdj7qT/Nnyi MpiFrqZtt0aUSYNLy5UmkZf4S94/kjgg3PwLnWIrHOQIenj/IgU= =yfMn -----END PGP SIGNATURE----- --nextPart118373959.CyqrhBlz6A--