From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122955 invoked by alias); 28 Apr 2017 08:51:06 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 122935 invoked by uid 89); 28 Apr 2017 08:51:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=views X-Spam-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MG4kBEuLk4shrrhDJU+BtfYXdblvsxX/CQTsO79AUFI=; b=WiO6eY6M+1Otu5oEyxwZlRdGQi0SrlQRQ9Mzcm1hNspCCFSqaOlotKzyiUA+fD1l4DDnHXQJZ0KSoerDZKU73IW3aoJsSWu3dlUBnLh717IZqvj070aKakv+J0S3TrdMunFzk9G5xODlYEunJjMw+u4BeCAoFzElGgvw9+wj+sY= Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io; Subject: Re: [PATCH] On elf_update, remember when we mmap() To: Mark Wielaard References: <20170427222345.GF2061@stream> CC: From: Ulf Hermann Message-ID: <3615b20f-66d1-e911-04f9-a784765af67f@qt.io> Date: Fri, 28 Apr 2017 11:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170427222345.GF2061@stream> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: VI1PR0602CA0023.eurprd06.prod.outlook.com (2603:10a6:800:bc::33) To AMSPR02MB231.eurprd02.prod.outlook.com (2a01:111:e400:8022::22) X-MS-Office365-Filtering-Correlation-Id: e71a41fa-dca5-49aa-3446-08d48e13b3a7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:AMSPR02MB231; X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB231;3:DJy5QhzncN4pg8F797W7I/pG5Ago+psowDQ+T3qJ8AA02p+C5JasU3uPAl/9+jL5dktSPLw6DuOJfiiM+dr15o2CJ612MgwWDnVv1xbs2S+ANtMJI1m53PApg5flUIFgOF+rofmqFuxLd9inzkfWRSGYrEQ3y6D4U4kuChItI3W0bT/9Htwb2EIMY3TxQWTf+ipcR9b3MstG8PDeDVl1cPIwFlw4XMFfFVTQGSf75Ft0yC5BR4IGHPkX8mW3bBL2Lz+iUKTLmw+j0WlcM/pkvEVX8EDUrO/oIuJTwYLhuCudjMKoAFa+w/Lc6YYkz56cdbDgFFeLrGEA1HKpTMuuQg==;25:uQDPWnxaS8d2TKWdtXrJjan3ER/EqN2+ViWiVETsg7MdynYBpSlSqZW0C3J9J7EbIuGPjAL4I5Ely2LqXPc/84TVUJ8q7MEMyad9eCbkfrwaJ/CBpRWRMZX2xI82SFmoslWXL+iOG2u3bNZHCOSnI3zKGVn50X/LVQ5D6OMs7ejCn/ZkxAiqw8KGgit91+m5fr0JtJGaDdswCvgz6pz4FXJJrO7Pn/ajxwLt4IMQB7hJbs1co/+m3iQVv8hfY/XrNQWLoOWqvfIljP0I/ztdX86v4rI+/adaXKgKDJmK3nuE2xy/6a2NzgQmQeXRkBae59A2Yad0d3md0yHwTCHeNkCyhoGo8oS8t/aevTl/xTBXoMjKkZjoc4NPW8n6as7Cr5Knl/g9rAEan73jvLgNoe2Jv5MvLw1PFd5QGANq4DeA1eGZnOqlzPVM19xmcsMUCi1gYhSW5lzPybiYVtCcQQ== X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB231;31:12B4J4ApQdYVzC3HidcGfxntc99kzJSJBFp/TgsDZO/zuimFQ6FhzvwJzZ14mBtOWlRtpxbKVOGR62HWzOpNh0ESxHCX6P2ObZmCKkixUS5/vIpo0uay3kBc6N4BfIIAca9osdEx6KPhcaFPvg3fBfgOa/Vu6Z4e6a0ljfFI0qwzeM4k3d11j3034uHBKm4QO6HJrNbknnprnUkM4Tfw2LLoPwhSEOXHHo1vcouc7hCwEw4P79vrSJAOAYej4XUO7xKDJio/QLrL/HLTu/wI0IiJKNi5iiTGJc8DU9r2/4Y=;20:00eARJ80DueDpmLk4jCPERDzBs+JolonXzvigeDmXyvJTCK0E7Kpb2kDHWAMQteZvYUVFnrP7q/OQJoxMd++hauKU2wuZMCLovxLtqQf38ZUlXug+ab0LRTT9Fr9nwCnCPliCPc7Rg6mCJFfRPadZYpzcKQ1M2lzqQcbWYFsR987dsfQD1Vcwc7yZ+ab8SB1Rk7fOwxnx2zOz2LTC2FjaTpdI83KHBPPTTSUd6jfI9qKE53hMgP+Tw08qN/mY2UK X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148);SRVR:AMSPR02MB231;BCL:0;PCL:0;RULEID:;SRVR:AMSPR02MB231; X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB231;4:oy3fJ2fIB/2OPlFo4kTsOH+dGt4vILn+9eQsNkXLQWemvicnFsdj+BcGeRLbGWd3nrGhE1YNVHQTnsxCL+K+fpuuKAywNFnDaV/u7+2IZJFXGKPVLkAAKuSvZ/EC7ExHBGwTBi1wsUXeMoMqZFbw2E8obiblVu3tuCoOIAWcbteQdC8JnMd2iH2mdtpP2DhCj9EEAwMztbeYbJyJOwRNUZOG7qwaY4Mv530mlj7cjubAR+yPxPC41MxuLqmtEJzFQkkCg6UePW1PXWmFgtZsM5x3Kp7QmUfl7SecZ4KycbPieqxIAGi4JWSlM/mFLbJYgt40EL52/hxwu6yDZ+CBpIzV87UHSRpN8XSrVfiCsDUMtQUp2GV7iAbg9RvbQnG8bMRL6u3YgRmMO+oPHR1UT9SmlOtIDnfwY8082Y2p/sQjCq47zvZKd7f1TWfwZ/vkcNyLIitFQBP16ATdG98PWyezL0cWwK8XWQ95OVnlDPgu7/emtMzvQMLXlv/7eVirWIU1g9D/OiSkWkf4sdDEZu+FUROclpuUHb+Cq4aZ34jy5WDBHOVFepXrUnmbafCXEqS9cAN7EAq0pUjADrIktno/k9CU2iRUjWhtvHWVJDLZH0M/jb+yBE3+Zms/05Q1x6fPAIJwF8mNaqJQxU00foQbL1p+aIif9+PNktvQJG9ryrQMPSHTSW/FjJBHMbH7nCfYiwvbWTqgR0pTEUG6lPBY3LgLwrbjjf/JosaHNVNvm2o5hiGqPhkjRSAX7NcLHJYsOj1KPdJjDp+GDcS2XWT6Lj+l1uuS5UrQEqKB5Z0= X-Forefront-PRVS: 029174C036 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39450400003)(39410400002)(39400400002)(39830400002)(24454002)(377454003)(76176999)(50986999)(54356999)(66066001)(65956001)(74482002)(86362001)(31696002)(33646002)(36756003)(23676002)(47776003)(42186005)(38730400002)(110136004)(8676002)(6246003)(65826007)(5660300001)(81166006)(53936002)(6486002)(77096006)(7736002)(305945005)(3846002)(6116002)(2906002)(53546009)(4326008)(230700001)(25786009)(4001350100001)(189998001)(50466002)(83506001)(229853002)(2950100002)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:AMSPR02MB231;H:[10.9.78.56];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjAyTUIyMzE7MjM6VFdDNE1UcHNrS1gvM0R1SVNvc1JJMjM5N3BO?= =?utf-8?B?SUFRZnlDSzZ3Njl3c2Y5N1llRjRIR3M4b2pKYzBzazVxM2p1bC85ME5xemlS?= =?utf-8?B?aG5IbW9aWkVGWk84aStCdEQ1K0N5ZE5vZ3NhZGRCbi9LQ3pZR3RTRlVSMFhx?= =?utf-8?B?Q0FiWmplUFl1TituSUpxdzc0RkhqNWNwelgxdEp5YkQ3WnFKclQyU3dxdldL?= =?utf-8?B?Vjhrdmgwa25tdmM0b0ZnNUVmUG41RjIvTXl5K2FVbVM0dUhSRS92dFAyblhX?= =?utf-8?B?cUNhSVRhc0E5d1BqN0F0Nmx0a3JUNGZsZUpMbmF2cUJEWU5yaUdDdngxUmhi?= =?utf-8?B?Y0htWDJPTjJiNjhwRlRMYnZhbHpRczZ0TW5tWDNSRE9qZ2pvWXFyZUFDNXdX?= =?utf-8?B?T3BWOGJjckZ3TFB6Z0VBVlNsY21uaGtLODArNEdBWThVZzJ6R1o2NUVrNjcw?= =?utf-8?B?b3d5bkpEQUp0cFMwZnF0ZEIyYzA1cy9QaDZKTXN6QkdtTVZSbDNXWkVPTkZQ?= =?utf-8?B?R2M4NU5YaitITm1xL1ZkZFVMSGw4WjBVdzhqb0wwNmdmMVRUeFhHQXFYWk5L?= =?utf-8?B?LzFPMVgrTVNVbTA1UXRGQXFhNUMyMUM4MFVvVDdkMEdwaWwva09qOWRlL2Rj?= =?utf-8?B?TkR0R1E1bG5CaGM2VFQ3ZnJaM3h0eWdJeDNxV01LRU1iZmNWNTE2R0lKejBR?= =?utf-8?B?ZGFDZTBONG90SWlJSk5aRjdia09tcHowWmx3QXdjTTlrbEVLV24rckpPLyts?= =?utf-8?B?Tm05dVEvMkxhQzZXSWxNT0hqWEhXS1gyaisrTjk5NlVMTC8vSGZLdDcwbm16?= =?utf-8?B?MGF2aEUwRTA5RTZZaXdMdmNTVkhqeTV0VG9HRWlqc2x3cjlkcTQzNHAvazNC?= =?utf-8?B?UGg0dlI1TXdvakhTYUtYRmZVUjY4b0phU05Dd0VYdmlTVnBLM2JSNWRvZ005?= =?utf-8?B?V0gwdHRNOVpkTnRwY3JYRldRU2NLc1ZuOUh5ZWZabWRwT2R1Q0k0KzQrMjZY?= =?utf-8?B?R1FObUpRVll4SkVkdXRHbXdCOHhHOG83dDRyaFZxRFlXczF6dEZhSlZJK1Vp?= =?utf-8?B?RGoyRmI2OEc3TjJvb0JFMlhDcm1YUkFqZEM5UG1VQW84VFo5cjRQN1dZQ1hF?= =?utf-8?B?bUVhMG1LMlhzYjZ1VWFVVll3eGgwS2N1MndmRDFpb25heVpCcE5nMTdGcldj?= =?utf-8?B?SHVodVltT0g0SWVCMkFOWWNzWjJRSVI0Z0tyQnQ5b2lEVUZ6RCs2YlBWeEY4?= =?utf-8?B?UWZJZ3JLcjgybmo5WDdKbVJSN0tBM2picXI0THd5VFIwYU5idENLTVVUbmZE?= =?utf-8?B?a3JYbzdPbTNmKzA3NlkyL2MyZ29GcHQxY3p1d096SzU1ODZ0VzkyWHNxcXdW?= =?utf-8?B?QkgwYllLTEloNDBuQnh3QUxXOW1yemVnci9Dc2tjMFpsK0hrb0ZQNUtkYmlG?= =?utf-8?B?ZWNDU3dtbkswTGVQQ0Y2NkQ5Ri9ySUZscUpQTXZSakQ0N0hmVjV2eXRmcmdu?= =?utf-8?B?aURVTUJQN1UwaWhFaC9sS3hhbTFicXdLd2tjQjB6NURZc3JlSEI4VmV0MXhQ?= =?utf-8?B?UWNlQ3REN2tSKzRNK1l5THp0b1NuSFFCcnRqcHNCa2xhRkdKQThSK1pLRzgv?= =?utf-8?Q?8Hjd/u2Zfl/lyuxZrSC?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB231;6:PGWBVC6DLg1soSZHIRAB7WhYas3XSu0vu4AaEF29K1uhrXkpG3pPMeT/ln715Q6Jooi45egO/Cr6b3j7HaauT5amF7Ry7d+sSHOL8JCzOr1r3Aw/C5h+kMkHDoNnjGLDdLS8/VfI/nQJf3bxR4ARLmEyCbZ+kh+xgrX5CjFiFG/t5WKAzrTNqaVoI4PkMbAb2HgeCkkI685hcAD0mM9KxRT52Oy2/DL9uCfAhqqVt/P/uItdNFVA6VMiT0Zd0aMciJVY7a4DIo51Swy0ROqKqzOaPHwu65J3A8nS96iMTHfkmNX8lzSk76HqdP+tcLEfxzFZyotoS8b0RFTgVgVaA1DU4VyB8n6lFT08M696rjgFNXYKXrEA+VKUGSmsFE6xUXbjytxls9LOoAUZV3GaDGvak3nYOEWkcV2aXEYi2/1BRfjtJp3z0pLmqvrXb/MhQj6jpQGDDeLpFOimeO06v4WvM83rMkp5ifKezJOBsUR5LpD0MxyVQRA012Jc963W9eao3Iv7oFkuq+EQQzAVmw==;5:Wc+H4ij/cReUbB+VggFawTxYhPK7V+GuKQ4+qsX5T46MfB9kslRN9E5EKO6OZEKVqNywycPjdRp3rjrNLhmnKgq6oHdGmeK2+NYLlQzElIFWZtU/1MbmT5F+PWqyrLbDS2j2fmKgJhrThuYlemzHNQ==;24:KiHiz4tGJckHpsQMLAe4yb9ELf53Q46Gr0WhFjKt0AUhN0SCJaHV1ICjwmVTaV8Yw3mvpStYvfJlPkjtDugGrhaVpy/wC/nz1sPaq3dquMA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB231;7:I5jBGYjQpEPetWSUymRel9ZP2osdcUm/Mf8OFIKzDs6+LIp/euQPFruyJpfJbEhwng4vWNNTKrUq8LYR1xQ1mvR3COkSX2Xan13/D+NoEhBaXic4aSvoBamRJopJvbWi403CNGfeJUNl9sk2V/kkZFfDqri1Gpj0nWiCgBrsEsWX8HH7/IuZwZSnJ6kZwXKCkdgh3UjH/EfgpsL3kMfv4RZGhzgYsDE7dHxdQNRWdUBXEIqCS2DAsD1bD0Z5NSMLqmlWDZbf/sFfouihY9/5gkcrs1DMNNA9lSOjx1Z1VybGUuXEvSL8E1AccUEHGI0o2jZYWEanCIo+95GjxQVjfw== X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2017 08:51:03.1466 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR02MB231 X-SW-Source: 2017-q2/txt/msg00121.txt.bz2 On 04/28/2017 12:23 AM, Mark Wielaard wrote: > On Thu, Apr 20, 2017 at 04:57:41PM +0200, Ulf Hermann wrote: >> Otherwise we skip the munmap() later. This leaks resources. > > Oops. Good find. Applied to master. > > When configured --with-valgrind the tests are run under valgrind > and memory leaks will fail the tests. But since this is mmap > valgrind won't report it. How did you find it? On windows you cannot rename or unlink files if there are still open views on it (and the win32 view mechanism is how I implement mmap on windows). So, the test cases fail then because the directories are not empty. Ulf