From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH 1/2] libdw: Use correct CU to resolve file names in dwarf_decl_file.
Date: Tue, 12 May 2020 21:07:29 +0200 [thread overview]
Message-ID: <37af7f8f0d58e5fb5db8a6ddbc77c3624c1fe6b3.camel@klomp.org> (raw)
In-Reply-To: <20200508165034.12405-1-mark@klomp.org>
On Fri, 2020-05-08 at 18:50 +0200, Mark Wielaard wrote:
> dwarf_decl_file uses dwarf_attr_integrate to get the DW_AT_decl_file
> attribute. This means the attribute might come from a different DIE
> in a different CU. If so, we need to use the CU associated with the
> attribute, not the original DIE, to resolve the file name.
>
> Also add a bit more documentation to dwarf_attr_integrate explaining
> that the attribute returned might come from a different CU (and even
> different Dwarf).
Pushed to master.
prev parent reply other threads:[~2020-05-12 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 16:50 Mark Wielaard
2020-05-08 16:50 ` [PATCH 2/2] libdw: Skip imported compiler_units in libdw_visit_scopes walking DIE tree Mark Wielaard
2020-05-12 19:07 ` Mark Wielaard
2020-05-12 19:07 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37af7f8f0d58e5fb5db8a6ddbc77c3624c1fe6b3.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).