From: Milian Wolff <mail@milianw.de>
To: elfutils-devel@sourceware.org
Cc: Mark Wielaard <mark@klomp.org>, Ulf Hermann <ulf.hermann@qt.io>
Subject: Re: frame unwinding patches
Date: Mon, 03 Apr 2017 09:00:00 -0000 [thread overview]
Message-ID: <3915502.JGE1jdPxOT@milian-kdab2> (raw)
In-Reply-To: <1487201610-8381-1-git-send-email-mark@klomp.org>
On Thursday, February 16, 2017 12:33:27 AM CEST Mark Wielaard wrote:
> Hi,
>
> I put all three frame pointer unwinding fallback patches on
> the mjw/fp-unwind branch. I'll also sent them to the list using
> git send-mail --annotate taking out the binary file patches.
> Hopefully that will make them appear on the list, bypassing the
> spam filters.
>
> [PATCH 1/3] Add frame pointer unwinding as fallback on x86_64
> [PATCH 2/3] Add frame pointer unwinding as fallback on arm
> [PATCH 3/3] Add frame pointer unwinding for aarch64
>
> I had to hand apply a few things because of whitespace adjustments.
> Hopefully I did it right and this is how Ulf intended the patches.
> If not, my apologies, and please let me know what changes you did
> intend.
Ping? Any progress on merging this functionality upstream? It can make quite a
difference in unwinding.
I just got a report from a colleague. As-is, elfutils would fail to unwind
from the following location in his application:
0x1137ca4
With the x86_64 patch applied, he got a proper backtrace:
0x1137ca4
0xc45466
0xc4fffa
0xda76f3
0xd78181
0xd8069c
0xd846bd
0xd995b7
QOpenGLFunctions::glTexImage2D qopenglfunctions.h:1022
... <proper debug symbols available rom here on>
So, please consider reviewing and merging this.
Thanks
--
Milian Wolff
mail@milianw.de
http://milianw.de
next prev parent reply other threads:[~2017-04-03 9:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 23:34 Mark Wielaard
2017-02-15 23:34 ` [PATCH 3/3] Add frame pointer unwinding for aarch64 Mark Wielaard
2017-02-15 23:34 ` [PATCH 2/3] Add frame pointer unwinding as fallback on arm Mark Wielaard
2017-02-15 23:34 ` [PATCH 1/3] Add frame pointer unwinding as fallback on x86_64 Mark Wielaard
2017-02-16 9:13 ` frame unwinding patches Ulf Hermann
2017-04-03 9:00 ` Milian Wolff [this message]
2017-04-03 9:03 ` Ulf Hermann
2017-04-03 21:14 ` Mark Wielaard
2017-04-07 10:27 ` Mark Wielaard
2017-04-11 10:16 ` Ulf Hermann
2017-04-19 19:48 ` Mark Wielaard
2017-04-20 9:26 ` Ulf Hermann
2017-04-25 12:50 ` Mark Wielaard
2017-04-25 12:54 ` [PATCH 1/5] Revert "Optionally allow unknown symbols in the backtrace tests" Mark Wielaard
2017-04-25 12:50 ` [PATCH 2/5] tests: Add core backtracegen chec and regenerate ppc32 backtrace test files Mark Wielaard
2017-04-25 13:04 ` Ulf Hermann
2017-04-25 12:55 ` [PATCH 3/5] Add frame pointer unwinding as fallback on x86_64 Mark Wielaard
2017-04-25 13:05 ` Ulf Hermann
2017-04-25 12:56 ` [PATCH 4/5] Add i386 frame pointer unwinder Mark Wielaard
2017-04-25 13:38 ` Ulf Hermann
2017-04-25 12:56 ` [PATCH 1/5] Revert "Optionally allow unknown symbols in the backtrace tests" Ulf Hermann
2017-04-25 13:11 ` [PATCH 5/5] Add frame pointer unwinding for aarch64 Mark Wielaard
2017-04-25 21:55 ` Ulf Hermann
2017-04-25 22:13 ` Mark Wielaard
2017-04-25 22:23 ` Ulf Hermann
2017-04-26 15:24 ` Mark Wielaard
2017-04-27 14:02 ` Ulf Hermann
2017-04-27 14:29 ` Mark Wielaard
2017-04-27 14:35 ` Ulf Hermann
2017-04-27 15:09 ` Mark Wielaard
2017-04-27 15:42 ` Ulf Hermann
2017-05-03 8:46 ` Mark Wielaard
2017-04-26 15:20 ` frame unwinding patches Ulf Hermann
2017-04-03 21:23 ` Jan Kratochvil
2017-04-04 7:40 ` Milian Wolff
2017-04-04 7:55 ` Jan Kratochvil
2017-04-04 8:25 ` Ulf Hermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3915502.JGE1jdPxOT@milian-kdab2 \
--to=mail@milianw.de \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
--cc=ulf.hermann@qt.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).