From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 8922B385802F for ; Fri, 14 Apr 2023 15:26:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8922B385802F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A0710302BB02 for ; Fri, 14 Apr 2023 17:26:32 +0200 (CEST) Received: by r6.localdomain (Postfix, from userid 1000) id 749673402D8; Fri, 14 Apr 2023 17:26:32 +0200 (CEST) Message-ID: <39ea13d43ab7c607fa1f79fc1e3b2d36b186b6e1.camel@klomp.org> Subject: Re: [PATCH] backends: Check results for NULL early in dwarf_peeled_die_type From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Fri, 14 Apr 2023 17:26:32 +0200 In-Reply-To: <20230406150424.476494-1-mark@klomp.org> References: <20230406150424.476494-1-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Thu, 2023-04-06 at 17:04 +0200, Mark Wielaard wrote: > Calling dwarf_peeled_die_type with a NULL results pointer is an error, > check early that result is not NULL so dwarf_formref_die and > dwarf_peel_type won't try to set the NULL Dwarf_Die. >=20 > * backends/libebl_CPU.h (dwarf_peeled_die_type): Move check > for results =3D=3D NULL to start of function. Pushed, Mark