From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by sourceware.org (Postfix) with ESMTPS id E6AF53853809 for ; Fri, 25 Mar 2022 11:17:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6AF53853809 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f47.google.com with SMTP id a17so8839303edm.9 for ; Fri, 25 Mar 2022 04:17:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version; bh=MtfmVt3o0z8Tud66SwXIUWm+HDwVKwbeEbO7q2gJCwA=; b=SmSHww8xoFg1tkEKKJyXuyXLQjdeq1ofbRTeVa+iKTWIBOTHkEOr6dB4RqJq4TWk/B PWRP8VcoU5Z2XWUjzXTOnyMZ4Vb4KIYq9QCzf7rYwi0v0vo30JZTrXLS3tI2RSHPwPM3 8geWKGQP3AlfqMO8ITCz18oRmmEZYgljQoxurIz/n3fsZyYOyXvWaUsDQOjO1Zqeoglh /AFDKdBHqyWVatZl/6+YZ6g/xSQbWYeT29S8elesSzPsKX8+6MUfmPEF/ChUkaMqzGiV DoXibhwM7JLVTFbJX3HK0+7chgS6BId8f/3Va6eGnMoOEj8qwuCg7x0duUHt3/ig1Tpl 5eBA== X-Gm-Message-State: AOAM531l7KL/4MxP3NA53tkMZhA1qXw+QmvlGvJC2AUJWKMd/gq7oY90 9zQ7FaH7w3D34ji2g7JQK6K7/61AWhI= X-Google-Smtp-Source: ABdhPJznyo6N9tHX9B9DN0ZyOAXSYe4Y0UbDQn8NQU1iaAPxAwfz7SmYSPPa+F46wh89nbecmqT97Q== X-Received: by 2002:a05:6402:d4:b0:418:7193:da1 with SMTP id i20-20020a05640200d400b0041871930da1mr12524143edu.57.1648207063867; Fri, 25 Mar 2022 04:17:43 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id yy18-20020a170906dc1200b006d6e5c75029sm2173503ejb.187.2022.03.25.04.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 04:17:43 -0700 (PDT) Message-ID: <3ad724af194ed4b05d539f0807d77ae7955371df.camel@debian.org> Subject: Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note From: Luca Boccassi To: Mark Wielaard , elfutils-devel@sourceware.org Date: Fri, 25 Mar 2022 11:17:41 +0000 In-Reply-To: <20220324231438.350551-1-mark@klomp.org> References: <20211119003127.466778-1-luca.boccassi@gmail.com> <20211121194318.105654-1-luca.boccassi@gmail.com> <40a5de54f089f344697ece88e11eb41e526462ac.camel@gmail.com> <17e1d554c9a52598d2c7d27e7a40f17381285ba5.camel@klomp.org> <20220324231438.350551-1-mark@klomp.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-cHUBK7ibu0bvC1YkLIqG" User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 11:17:47 -0000 --=-cHUBK7ibu0bvC1YkLIqG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2022-03-25 at 00:14 +0100, Mark Wielaard wrote: > > I haven't forgotten about this. The glibc elf.h change has been > > integrated now. But when I wanted to resync with the elfutils > > libelf/elf.h version I noticed something that look like ABI > > breakage: > > https://sourceware.org/pipermail/libc-alpha/2021-December/133589.html > >=20 > > I am trying to get a response to that before syncing and > > integrating > > your patch. >=20 > Sorry, I didn't like the answer I got. Basically this is ABI > breakage, > it is just that the old constants were never really used, so some > have > simply been renamed or given different constant values. Sigh. >=20 > That of course is not a good reason to then forget about your > patch. Apologies. >=20 > I took the elf.h update separately. Tweaked your patch a little and > added a patch of my own to make elflint recognize the new note type. >=20 > =C2=A0=C2=A0[PATCH 1/3] libelf: Sync elf.h from glibc. > =C2=A0=C2=A0[PATCH 2/3] libebl: recognize FDO Packaging Metadata ELF note > =C2=A0=C2=A0[PATCH 3/3] elflint: Recognize NT_FDO_PACKAGING_METADATA No problem at all, change looks good, thanks for following up. > I saw Fedora 36 now has these new package notes. Sadly they omit the > debugInfoUrl field. Which makes them less useful imho. Do you happen > to know why that wasn't included? Not sure, I think the Fedora-side tooling was there already before we added this to the spec, so it was simply not synced. I'll follow-up and ask to get it included - might be too late for F36 unfortunately (not sure new archive-wide rebuilds are going to happen), but if it gets approved it should be there for F37. I have included the field in the first PoC that uses the spec in Debian, for the systemd packages: $ readelf --notes /usr/lib/systemd/systemd | grep Packaging Packaging Metadata: {"type":"deb","os":"debian","name":"systemd","archi= tecture":"amd64","version":"250.4-1","debugInfoUrl":"https://debuginfod.deb= ian.net"} --=20 Kind regards, Luca Boccassi --=-cHUBK7ibu0bvC1YkLIqG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCSqx93EIPGOymuRKGv37813JB4FAmI9pNUACgkQKGv37813 JB6pIw//fHie4wh7x7CbhAJiI6OAm3lO3UfzvZ6nDrX0QTulyOuIhbBir+tmsiJi PC7JBqnnimp05nHg6VNjnfBuOQOffhMT5RFubjuDcFTlNK6OFnk3Gc3M4anFzXBs Z8kq60/PHeZKOjqtHYhzEvHkWa4v+buj3Mw6VuEISm/eK3LDv7KSJJGTun8Sfs1B A5So+qqOZpOp1IecF8TskkwElSz7Tz3QjzzSrbJempXXBXmYdu5WT9pVRNSE8G0s Izdc3rojfldnkisOATlvHBINHPan32pFa7hMbbJJAtBvhQarAb/EQyI8abZ9tVgX BxTMnrWOqSjsBGjVnPAhNCwY4XXPGMMZ/kc9IUOA1nKCjA8/bfBySBpRtI2A1lia Uwn5UtZphaM1id/R/w2QY2X1z5WXmy3rRUz85FUUEbRma3qBOdkoBTeHOr/CR2WW xKqdywryiDltsIFMQflHhQUEkJ7Yun5ReZXcY4u0Yp1W1XuBNghryKygx03+8R2L 0je5+QnDeez11lHVR5CcyOdlJbB3X0g7BVSvJewI3S1nl+uMr4cOMLeno1GLvU4L 2Ps1DrIz62UiUgcRgCyTj122lHCN5UkXkuRBG20ZPB8pJbmYPDUOV0wCnKpuwve9 HldvzYPEajAn6WD69HVL++6mUpAE8yEWnau2VhHr5S6k7YgGqGQ= =myqz -----END PGP SIGNATURE----- --=-cHUBK7ibu0bvC1YkLIqG--