From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id AB2043850211 for ; Thu, 20 Oct 2022 16:07:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AB2043850211 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id DF0063000648; Thu, 20 Oct 2022 18:07:18 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 53F584000D8C; Thu, 20 Oct 2022 18:07:18 +0200 (CEST) Message-ID: <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> Subject: Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec' From: Mark Wielaard To: "Frank Ch. Eigler" , luoyonggang@gmail.com Cc: elfutils-devel@sourceware.org Date: Thu, 20 Oct 2022 18:07:18 +0200 In-Reply-To: <20221019194930.GC24703@redhat.com> References: <20220920084307.1696-1-luoyonggang@gmail.com> <20220920084307.1696-2-luoyonggang@gmail.com> <20221019194930.GC24703@redhat.com> Content-Type: multipart/mixed; boundary="=-0SwzpqOzYshURjDu6Sng" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3039.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-0SwzpqOzYshURjDu6Sng Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Wed, 2022-10-19 at 15:49 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > I really want this to be merged :) ping Frank, > > as this would stop me clone elfutils on windows >=20 > If it doesn't break "make rpm" (or at least rpm -ts > elfutils*.tar.bz2), > it's fine. make rpm doesn't work because of: rpmbuild -ts --sign elfutils-0.187.tar.bz2 error: rpmbuild --sign is no longer supported. Use the rpmsign command instead! make: *** [Makefile:971: rpm] Error 1 Maybe just remove the --sign? But then, with the rename, you'll get: rpmbuild -ts elfutils-0.187.tar.bz2 error: Found more than one spec file in elfutils-0.187.tar.bz2 make: *** [Makefile:971: rpm] Error 1 So maybe we just should rename them to .specfile? That is what the attached patch does, plus some other cleanups. - We forgot to include the hello3.specfile - Remove the --sign from rpmbuild - escape the % in spec comments That makes make rpm work out of the box without warnings. Does it also help the windows git thing? Cheers, Mark --=-0SwzpqOzYshURjDu6Sng Content-Disposition: inline; filename="0001-Rename-hello-2-3-.spec.-hello-2-3-.specfile.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Rename-hello-2-3-.spec.-hello-2-3-.specfile.patch"; charset="UTF-8" RnJvbSBmN2JkMzMxMzI2YTAzMTA4MDk1Yjc1OTNiYjQ4ZDc0ODI2OTA1MDFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBZb25nZ2FuZyBMdW8gPGx1b3lvbmdnYW5nQGdtYWlsLmNvbT4K RGF0ZTogVHVlLCAyMCBTZXAgMjAyMiAxNjo0MzowMSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJl bmFtZSAnaGVsbG97MiwzfS5zcGVjLicgLT4gJ2hlbGxvezIsM30uc3BlY2ZpbGUnCgpUaGVzZSBm aWxlbmFtZXMgYXJlIGludmFsaWQgb24gd2luMzIuCldlIGRvbid0IHdhbnQgdG8gaW5jbHVkZSBt dWx0aXBsZSAuc3BlYyBmaWxlcyBmb3IgbWFrZSBycG0uCnJwbWJ1aWxkIC0tc2lnbiBpcyBub3Qg c3VwcG9ydGVkIGFueW1vcmUuCkFsc28gaW5jbHVkZSBoZWxsbzMuc3BlY2ZpbGUgaW4gRVhUUkFf RElTVC4KRXNjYXBlIHNvbWUgbWFjcm9zIGluIHRoZSBlbGZ1dGlscy5zcGVjLmluIGZpbGUgY29t bWVudHMuCgpTaWduZWQtb2ZmLWJ5OiBZb25nZ2FuZyBMdW8gPGx1b3lvbmdnYW5nQGdtYWlsLmNv bT4KU2lnbmVkLW9mZi1ieTogTWFyayBXaWVsYWFyZCA8bWFya0BrbG9tcC5vcmc+Ci0tLQogQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDQg KysrKwogTWFrZWZpbGUuYW0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8IDIgKy0KIGNvbmZpZy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCA0ICsrKysKIGNvbmZpZy9lbGZ1dGlscy5zcGVjLmluICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCA2ICsrKy0tLQogdGVzdHMvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDkgKysrKysrKysrCiB0ZXN0cy9NYWtl ZmlsZS5hbSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMyArKy0KIHRl c3RzL2RlYnVnaW5mb2QtcnBtcy97aGVsbG8yLnNwZWMuID0+IGhlbGxvMi5zcGVjZmlsZX0gfCAw CiB0ZXN0cy9kZWJ1Z2luZm9kLXJwbXMve2hlbGxvMy5zcGVjLiA9PiBoZWxsbzMuc3BlY2ZpbGV9 IHwgMAogOCBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQog cmVuYW1lIHRlc3RzL2RlYnVnaW5mb2QtcnBtcy97aGVsbG8yLnNwZWMuID0+IGhlbGxvMi5zcGVj ZmlsZX0gKDEwMCUpCiByZW5hbWUgdGVzdHMvZGVidWdpbmZvZC1ycG1zL3toZWxsbzMuc3BlYy4g PT4gaGVsbG8zLnNwZWNmaWxlfSAoMTAwJSkKCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggNjA2MjQxODMuLjJiZjk5YzcxIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysr IGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNyBAQAorMjAyMi0xMC0yMCAgTWFyayBXaWVsYWFyZCAg PG1hcmtAa2xvbXAub3JnPgorCisJKiBNYWtlZmlsZS5hbSAocnBtKTogUmVtb3ZlIC0tc2lnbi4K KwogMjAyMi0wOS0xMyAgQWxla3NlaSBWZXRyb3YgIDx2dnZ2dnZAZ29vZ2xlLmNvbT4KIAogCSog TkVXUyAobGliZHdmbCk6IEFkZCBkd2ZsX3JlcG9ydF9vZmZsaW5lX21lbW9yeS4KZGlmZiAtLWdp dCBhL01ha2VmaWxlLmFtIGIvTWFrZWZpbGUuYW0KaW5kZXggODY0MzMxMmEuLmU5MmUwNWMyIDEw MDY0NAotLS0gYS9NYWtlZmlsZS5hbQorKysgYi9NYWtlZmlsZS5hbQpAQCAtNDQsNyArNDQsNyBA QCBkaXN0Y2hlY2staG9vazoKIAljaG1vZCAtUiB1K3cgJChkaXN0ZGlyKQogCiBycG06IGRpc3QK LQlycG1idWlsZCAtdHMgLS1zaWduIGVsZnV0aWxzLUBQQUNLQUdFX1ZFUlNJT05ALnRhci5iejIK KwlycG1idWlsZCAtdHMgZWxmdXRpbHMtQFBBQ0tBR0VfVkVSU0lPTkAudGFyLmJ6MgogCiBpZiBH Q09WCiAKZGlmZiAtLWdpdCBhL2NvbmZpZy9DaGFuZ2VMb2cgYi9jb25maWcvQ2hhbmdlTG9nCmlu ZGV4IDEyNjVmMzk5Li40YzcxNjRlNSAxMDA2NDQKLS0tIGEvY29uZmlnL0NoYW5nZUxvZworKysg Yi9jb25maWcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNyBAQAorMjAyMi0xMC0yMCAgTWFyayBXaWVs YWFyZCAgPG1hcmtAa2xvbXAub3JnPgorCisJKiBlbGZ1dGlscy5zcGVjLmluOiBFc2NhcGUgJSBp biBjb21tZW50cy4KKwogMjAyMi0wOC0xNyAgTWFydGluIExpc2thICA8bWxpc2thQHN1c2UuY3o+ CiAKIAkqIGRlYnVnaW5mb2Quc2VydmljZTogQWRkIG5ldyBkZWJ1Z2luZm9kLnN5c2NvbmZpZwpk aWZmIC0tZ2l0IGEvY29uZmlnL2VsZnV0aWxzLnNwZWMuaW4gYi9jb25maWcvZWxmdXRpbHMuc3Bl Yy5pbgppbmRleCA1NDU5OTE1OS4uMzI4MmRlMjYgMTAwNjQ0Ci0tLSBhL2NvbmZpZy9lbGZ1dGls cy5zcGVjLmluCisrKyBiL2NvbmZpZy9lbGZ1dGlscy5zcGVjLmluCkBAIC0yNjMsMTggKzI2Mywx OCBAQCBmaQogJWRpciAle19pbmNsdWRlZGlyfS9lbGZ1dGlscwogJXtfaW5jbHVkZWRpcn0vZWxm dXRpbHMvZWxmLWtub3dsZWRnZS5oCiAle19pbmNsdWRlZGlyfS9lbGZ1dGlscy9rbm93bi1kd2Fy Zi5oCi0jJXtfaW5jbHVkZWRpcn0vZWxmdXRpbHMvbGliYXNtLmgKKyMlJXtfaW5jbHVkZWRpcn0v ZWxmdXRpbHMvbGliYXNtLmgKICV7X2luY2x1ZGVkaXJ9L2VsZnV0aWxzL2xpYmR3LmgKICV7X2lu Y2x1ZGVkaXJ9L2VsZnV0aWxzL2xpYmR3ZmwuaAogJXtfaW5jbHVkZWRpcn0vZWxmdXRpbHMvbGli ZHdlbGYuaAogJXtfaW5jbHVkZWRpcn0vZWxmdXRpbHMvdmVyc2lvbi5oCi0jJXtfbGliZGlyfS9s aWJhc20uc28KKyMlJXtfbGliZGlyfS9saWJhc20uc28KICV7X2xpYmRpcn0vbGliZHcuc28KICV7 X2xpYmRpcn0vcGtnY29uZmlnL2xpYmR3LnBjCiAKICVmaWxlcyBkZXZlbC1zdGF0aWMKICV7X2xp YmRpcn0vbGliZHcuYQotIyV7X2xpYmRpcn0vbGliYXNtLmEKKyMlJXtfbGliZGlyfS9saWJhc20u YQogCiAlZmlsZXMgbGliZWxmCiAlbGljZW5zZSBDT1BZSU5HLUdQTFYyIENPUFlJTkctTEdQTFYz CmRpZmYgLS1naXQgYS90ZXN0cy9DaGFuZ2VMb2cgYi90ZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGVh MWRmM2QuLjMxZjRkMGU0IDEwMDY0NAotLS0gYS90ZXN0cy9DaGFuZ2VMb2cKKysrIGIvdGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjItMDktMjAgIFlvbmdnYW5nIEx1byAgPGx1 b3lvbmdnYW5nQGdtYWlsLmNvbT4KKworCSogTWFrZWZpbGUuYW0gKEVYVFJBX0RJU1QpOiBSZW1v dmUgZGVidWdpbmZvZC1ycG1zL2hlbGxvMi5zcGVjLgorCUFkZCBkZWJ1Z2luZm9kLXJwbXMvaGVs bG97MiwzfS5zcGVjZmlsZS4KKwkqIHRlc3RzL2RlYnVnaW5mb2QtcnBtcy9oZWxsbzIuc3BlYy46 IFJlbmFtZWQgdG8uLi4KKwkqIHRlc3RzL2RlYnVnaW5mb2QtcnBtcy9oZWxsbzIuc3BlY2ZpbGU6 IC4uLnRoaXMuCisJKiB0ZXN0cy9kZWJ1Z2luZm9kLXJwbXMvaGVsbG8zLnNwZWMuOiBSZW5hbWVk IHRvLi4uCisJKiB0ZXN0cy9kZWJ1Z2luZm9kLXJwbXMvaGVsbG8zLnNwZWNmaWxlOiAuLi50aGlz LgorCiAyMDIyLTEwLTE2ICBNYXJrIFdpZWxhYXJkICA8bWFya0BrbG9tcC5vcmc+CiAKIAkqIGR3 ZmwtcmVwb3J0LW9mZmxpbmUtbWVtb3J5LmM6IEluY2x1ZGUgY29uZmlnLmggZmlyc3QuCmRpZmYg LS1naXQgYS90ZXN0cy9NYWtlZmlsZS5hbSBiL3Rlc3RzL01ha2VmaWxlLmFtCmluZGV4IGY2ODBk M2UxLi5jZWQ0YTgyNiAxMDA2NDQKLS0tIGEvdGVzdHMvTWFrZWZpbGUuYW0KKysrIGIvdGVzdHMv TWFrZWZpbGUuYW0KQEAgLTU2Niw3ICs1NjYsOCBAQCBFWFRSQV9ESVNUID0gcnVuLWFyZXh0cmFj dC5zaCBydW4tYXJzeW10ZXN0LnNoIHJ1bi1hci5zaCBcCiAJICAgICBkZWJ1Z2luZm9kLXJwbXMv ZmVkb3JhMzEvaGVsbG8zLWRlYnVnc291cmNlLTEuMC0yLng4Nl82NC5ycG0gXAogCSAgICAgZGVi dWdpbmZvZC1ycG1zL2ZlZG9yYTMxL2hlbGxvMy10d28tMS4wLTIueDg2XzY0LnJwbSBcCiAJICAg ICBkZWJ1Z2luZm9kLXJwbXMvZmVkb3JhMzEvaGVsbG8zLXR3by1kZWJ1Z2luZm8tMS4wLTIueDg2 XzY0LnJwbSBcCi0JICAgICBkZWJ1Z2luZm9kLXJwbXMvaGVsbG8yLnNwZWMuIFwKKwkgICAgIGRl YnVnaW5mb2QtcnBtcy9oZWxsbzIuc3BlY2ZpbGUgXAorCSAgICAgZGVidWdpbmZvZC1ycG1zL2hl bGxvMy5zcGVjZmlsZSBcCiAJICAgICBkZWJ1Z2luZm9kLXJwbXMvcmhlbDYvaGVsbG8yLTEuMC0y Lmk2ODYucnBtIFwKIAkgICAgIGRlYnVnaW5mb2QtcnBtcy9yaGVsNi9oZWxsbzItMS4wLTIuc3Jj LnJwbSBcCiAJICAgICBkZWJ1Z2luZm9kLXJwbXMvcmhlbDYvaGVsbG8yLWRlYnVnaW5mby0xLjAt Mi5pNjg2LnJwbSBcCmRpZmYgLS1naXQgYS90ZXN0cy9kZWJ1Z2luZm9kLXJwbXMvaGVsbG8yLnNw ZWMuIGIvdGVzdHMvZGVidWdpbmZvZC1ycG1zL2hlbGxvMi5zcGVjZmlsZQpzaW1pbGFyaXR5IGlu ZGV4IDEwMCUKcmVuYW1lIGZyb20gdGVzdHMvZGVidWdpbmZvZC1ycG1zL2hlbGxvMi5zcGVjLgpy ZW5hbWUgdG8gdGVzdHMvZGVidWdpbmZvZC1ycG1zL2hlbGxvMi5zcGVjZmlsZQpkaWZmIC0tZ2l0 IGEvdGVzdHMvZGVidWdpbmZvZC1ycG1zL2hlbGxvMy5zcGVjLiBiL3Rlc3RzL2RlYnVnaW5mb2Qt cnBtcy9oZWxsbzMuc3BlY2ZpbGUKc2ltaWxhcml0eSBpbmRleCAxMDAlCnJlbmFtZSBmcm9tIHRl c3RzL2RlYnVnaW5mb2QtcnBtcy9oZWxsbzMuc3BlYy4KcmVuYW1lIHRvIHRlc3RzL2RlYnVnaW5m b2QtcnBtcy9oZWxsbzMuc3BlY2ZpbGUKLS0gCjIuMTguNAoK --=-0SwzpqOzYshURjDu6Sng--