From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20170 invoked by alias); 28 Apr 2017 11:21:21 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 20158 invoked by uid 89); 28 Apr 2017 11:21:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ikDrRV/a49tED4fYdtS4S/q9tgZUbVpmp1Sm9hrUFN0=; b=KjtHo4VYyFXeKO9IsyEDEx04DmKY7cCfqqrOpiMxlLnULOsFIoARZNW0Dat7VRZzbGfyO9z02am0lKFibJvgFxQ4agX5BydV2ffim9ErRZt8sNAmXHclL+IeBrAe3qMzTDnaIxLBbbvIO4HaM9u9ZqmXRiyn7t5bYYwvfnZITxw= Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io; From: Ulf Hermann Subject: [PATCH] Check if rpath is supported before setting it To: Message-ID: <3c173d54-893d-3c91-5065-ac32d5794b9a@qt.io> Date: Mon, 01 May 2017 14:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: HE1PR09CA0047.eurprd09.prod.outlook.com (2603:10a6:7:3c::15) To AMSPR02MB230.eurprd02.prod.outlook.com (2a01:111:e400:8022::17) X-MS-Office365-Filtering-Correlation-Id: 02009b0e-f2e3-48c4-e02e-08d48e28b088 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:AMSPR02MB230; X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB230;3:B/SsH9H3Pk83VkL+hFVHXvXj1sj+TEGill84QgHZku9IPGofMVCkRh3isH/KdKZPMhq09T2vTaqDU7X9fA1Cx6r81qU41ppDsbYEZVDVS7ScOLa8iQt7UmBtZbO99BHxEvwrmP0ikHd3Pbx6BVlo2ljHjyW7hDuu5AsEbxhiwl7jkgC4d0fiIlnBF2JfhneuVoWbxbwqtA612liqhFh29XnKL0c6gUi+Aqkf68y3N3SDU8KiO2tSK+vykLbyyp1MvkqB4ekkJrVbkiwDFr1PWcC0BhcZ3B1lUb8XMY98Mv16KrDLQmMWaYc5jQBJ6YZSplxF4TGHzqfXRpFBEgS3Jw==;25:Y3J8ftpxJUjWgEqLh2i6teDgmHDclFJ5yVPGBPO1LjBhcJ+fxCkKE4fF7TXKR8QwHVzZVQJZLGlpLIhXq6gdmzah8hEzgDKo4jxogIAzKs0sETTOSfacn3zulqdnXwGDPmXct++sQNzwOW33d7uP21Q5zdNlq3PmUVLzMOeqDo9HFtLZjlWu9gUirMbYyJQGjR5SkHXbv4poz9yn6sj7ebF9D6fC4EpS6Ib1LawvfUp5nlHgu/zI36rwIuCs+4sANiUib4uBuPJHaq4w2tJwUMtOCtOverPY8A3DFjcrFqU+e7IZ7pjwnRrBsoXmToPq0lkdsYEgeYeNR23iGcpBo8me8eDF8zZ8TpXaTXZZF9Yyhn+dRiy7gx+XJ9vMfNVPJpieJcDshphK6u124aYhfJnY7ZEs7inx4xUapPNpZ69ACrA/aS87UAXeAagiD6+ftiUtXttxubgykNiYBpJUHw== X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB230;31:uzk3qtN7Ys/L9vhVoGOVm3i4afIJ0gst7CmTI8lOJpagkH3zkRWu+7eD6AXauZ10b9e5fPKEORnWfT4k85kVzPlelyWELN8IxU5ui0xyY/KX+1Kk15Tgv/n+n4ZyZGWFxCgL2efg5LiGiO/e6R/z3b9yTcSJD0S55JWsdQYNJztZMIrghygtXnapXJFsWgTAHYevcjkA4GRh4HAYzslXFjwsVywOni5bAE7SiaXsOeHcCpvEJbM43n2WnZt/2MNr6KnwgyGAghM8VIQBSI8OoQ==;20:BzkJ6XDViv2UAaKRY7RlOrGHAUPCBQxxydV8M3UmneM7mYUOjO0R7hszcE6t42CUF38buJUVnVcyr33gOnA0MlHmxrzoWZuBnR3JCijSrz6mQYpO5VEgpCZsoNEj/1NbU8Vo5fBe9ulMwHJd6Tix4giSoePoqb62GTaB+pdsytmIhwVocmc3zCOFIsQtSCDZfwXFZiysEzZAB1W87gHfvl0Q0ScEran1FBztFZhjkGgQsZq2YzV8VdwjNvyexg3a X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(6072148);SRVR:AMSPR02MB230;BCL:0;PCL:0;RULEID:;SRVR:AMSPR02MB230; X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB230;4:2qFpYUY7veD/EMx7XGhBdhZ6c4toKwUG613zaHxWVt+w38B9lI9XkgSglhnZQYAzuT6oInOkRWEnVC/62kXW1OJpTfZUenbI6wUeK3+rtJ6Hm0ITRGPsIgtlnWdSiutN3IKnDeYhO9ITAWCrgjryZxwiXcixXXdb/1DPCLQSTw7xAq3y8qF7TMb/r8jnhOKZXK6IjWaoh3YOOgCLZDtSc8YOcfV0gX1VrqPV4DIPLE1MOmKR3jNiqxDZuPpXRhnckC5QbB3IuDDfUxm01IlvbisQU961RIWCD1brq2JeZWz8+8T69FlT9t9x4w792aZBY+GlR+md416/9A9VSfRQn5LZWmzCNEQS1+ZMbXtNidIcMNgf3w0qlshuZMZzZRXQEPuFcJScuMoJuBpy/uRPkDnFVmI1nc+rfbGVYN81d+1DSMi5TvizfXPFE9n8RJGh+ssXNJddL4k0p82C5F2NkI6RcJZBTyP0RFJiCsK3zTJ15NSy4TjeXksPv30/gW9cL49yTk3hdbWdcRCjBpmPcOWlXecRyHDTjRoRBtWf54+OSnfXUoilwyZRUIojG5VE3xcJj1n/PZOknPShH19af8Qh276SvaLICS9Wa1ljbfnmpNG6TEMWlY+FszWvw+/4dFbVIaBEIAHMJXzqFIE85UX/VnfZI7IlmZxtdZqk/BgrQKkJgEaZMspW11Wpw1Lh/VXt911/Q9FfgSYxFdN/LKA8a5UWrwE+QLCWtPeRu62K1IjRvmLH+d/LQJYCESGmJIg5xIzWNHYqSwKDYIzFfoPaF7WmveQKxAN6a7FRZOw= X-Forefront-PRVS: 029174C036 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39840400002)(39400400002)(39410400002)(39450400003)(377424004)(230700001)(33646002)(110136004)(38730400002)(42186005)(31686004)(2351001)(66066001)(65956001)(47776003)(25786009)(3846002)(50986999)(189998001)(4001350100001)(8676002)(81166006)(2906002)(54356999)(6116002)(6486002)(77096006)(23676002)(53936002)(74482002)(6916009)(65826007)(5660300001)(31696002)(36756003)(305945005)(83506001)(7736002)(86362001)(50466002);DIR:OUT;SFP:1102;SCL:1;SRVR:AMSPR02MB230;H:[10.9.78.56];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjAyTUIyMzA7MjM6TXpZdHhlL2dKeGhzUllEb2R3RWxOenFLK2pW?= =?utf-8?B?KzBnSDFpeWhzeFhVYUlxOE8zc0xPcCtWdXpnU0V2YVVFTDE1aVVLMC8wS28z?= =?utf-8?B?L25JdmhIWFpWTG0vaXhaN0JlN1ZMdi9RQTRkdEtoR2VNeTR0ZTJzV0xNNjFK?= =?utf-8?B?VlVyZ3V0MnRGUTd4Q1lLSnJFQ3RxRGNOMEVIU3VoUG9hMEc0UHZLSThNSm5m?= =?utf-8?B?ZkZlOTIwQkZ5UTNLeDJ6YlNHN1BFb0tRTG9nTEdETnJyNEticm0vNmRNMkZp?= =?utf-8?B?VXBpYWZZbjNKSHFkTVZCcmEvRURVdm9QQ1RJVjh6QmNFVnhZZVR0NVJ5d1E3?= =?utf-8?B?amtBS0JycHlxV3M4MDA0Vm9JTy9yWFJZdTZySkJ1WE9OM0lBR0d6dU94T1lp?= =?utf-8?B?TWpiNy9yTmNiQ0JDa2swUGxBMjR5ZVRMNmZVMWFJc2ZVSnljVHhlMStuNTJ3?= =?utf-8?B?RXhkdFF2TlVqVHE2NytwY2pKNGFKWjZwNHhPUUVmdzlTSTJVL1lRRTkxRlJt?= =?utf-8?B?V0c1Um1Lck5wbS9FRGJVditIa1VNdWsvQ3JoRjZXQjN1N08wRUNPbXBOcWdS?= =?utf-8?B?WmhyZS9xaHMrSDZqeXBuRU40NXZkcks4ZmNKUkw2WnBnRmwvZnFrRGhIS01U?= =?utf-8?B?YjAwR3RSYWNDbW9QZ0dyMjdPMW9TRWhJRDhKc0wxaEJxOGZmMXJuZlNDSmdS?= =?utf-8?B?dVZlLzlKSzdkRzBpM09ScmNka3pKcGtTem1PN0UwdVVpL1VENDRXV1E4OHA5?= =?utf-8?B?MGh5QnYvTm9mZ3IrU3VzRkZxUHFYbWNLK0IrQ294ZENRQ3ZDTnZNN25ZckVl?= =?utf-8?B?S3FCRHB1d3RDV0RvSWhOVDJWOHROTHM5aFRJYjlwY3FWNkRwdEM2cnMxWC82?= =?utf-8?B?LzZVbEw3Zno5dTAzL3gzamZ2MVB6VVA0eU9ETyt0UTBEOGpwcjd3TnBUUERD?= =?utf-8?B?Ulp0Qm1kRlNCYmNHbHQzUXBMQmVxZEhrcndJc0hGOGxBS3ZlZDVRemU4aEZa?= =?utf-8?B?MmZrVTRNak5CN3RXYmZsbEZycUhvTjVZU2dXdGw5NU45MzQySXZWY1JxbGN1?= =?utf-8?B?bzJweXRoZmoxQlY4bWFRZElQRkUxSWhoeFZXSk1wbjdoVkdnSEFVeEhEWG9u?= =?utf-8?B?Y3Z5RituODY2dk1rYVJGU2dVYTY1OFgwQmpUaENxNW5SRkticDU4NTgwZFZv?= =?utf-8?B?KzB0bks2amxIVHpLUzNJNVZSN2dEQ21VNFFoeU0yVzk3TVhoMm9YQWxIYjJQ?= =?utf-8?B?NzhoRFc2U1FUUXhNN2xrMFhjOTRrZ0IxTHYxTjA0ZG5JSXRnVkFIOFRhN2hZ?= =?utf-8?B?MnVQZUxTZFh4ZFZxL3dnU2tZdC9Cb0hKQXVQL0dLcEw3VURneEhyc0R6cWp2?= =?utf-8?B?TjJjeTNOVEJmSTBVVG5xVU1HT0FaazhmUWNyVUNTTmcrMk85cSszUHVtbi9n?= =?utf-8?B?TmlJUTZqbUJRbGZidmVlTHVadUNwdk9SWmdsVnpKM1VIakVTYy85VVh1L1Fs?= =?utf-8?B?cmRnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB230;6:zobenaEmADBGVeIlP+DrmFvTOxI8+L7GSyfMZ4nsFQ61Z2KvkVOrBNFOLe+xuYcGvozFZsDApPecqAIKRYaAOJTHI+Kkm9QxFXaHecT3Jl8o9pk6RvpuDeuX2exECNbFbvZkkr8swFs8vBFNlyAKCfpo2uBO71M/NNt4IvZ91vyqtvjqKkIv+OFZP/kfNUohM4atiPIDJbjlX7Qs1GrQvqCDXP6xeYSK9+Fs1NoER3iGPiDjx/0ISJUuhOt1k8EQe9aOR5YMhxaidjteNdzR2vc8q0kSoDX/pvM6hH6PF6qPs2rWLbEInRbIASAeNRmg25Z+7wUvqsvOMIC7TWNCM9olUibCkdlakOHnZv7cIXkNomnq/G4MVEMIsNSu5L0CqkAfWU7l+OaCFZ5aI2shPN4zJUp2eJzZ1zsBtCKL+Iqbq3xCJP6bC4xwsnBweQaSbqGPuVvWJDIOS8G858TJuvkXc7UAb8bcizsmVzmCVwTZMvhvYVI17Rkh0DXj0Qs28qtxr23sks/xw6PVcK/8Ig==;5:gwruaOElJ/U34epfBDrU8KF385wKQj8XccyZX89LrePc+yQ+qg5zU7hPJQ+H5An44x1oonygEPa45XEL45qg3hVr/RNc6tDG1GPYlve03R+ckvMUSbT+yhaRyILP5l0nZ7HubJ1Y4MWw7lrg8wrU5A==;24:UaVUlFK6r7hKiAsBL+eKsdRBstUR8phLfK1HiEgjoLyzZww+UtzYd8/EBCMGdccNP6pW+yp0b+ECMAWgJJ53CeOdqO0HDALO121OOZVuaPo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AMSPR02MB230;7:nK3efMYQsmIeFKJITO9/ZVnE4Uy+/iDNrKHI4JHVg5MPoy9uw8B4tjXaJKuZ0+z8aWP9EpXMQsgDDslRkmjGyeZunIjnBjYFOZpKWIQJ4/FjwqwYTs5UA9qCCS5E/FHj+/yV7VYWPyFJa7IMUsxs6KPkCER/CglLbtjgxGHGqQ6rDx7ldM/Ddmvx/XorGyPlFmKAkzJLZWjxB3fFohdqWVe5f1W1uB34NaOY3kR/Ez1fEzQXz6pc8NDWsnIOwNiDCJfsFGUZsB7e55bFGQ1NK8DKE2k2ZVhvsyBX3xVJwHXS36EJOIJ0PKhmfHDYSEc1VlI9+MNw2X71nD6gJewMFg== X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2017 11:21:17.5335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR02MB230 X-SW-Source: 2017-q2/txt/msg00125.txt.bz2 Some systems don't have rpath. In that case the backends need to be made available by some external mechanism. Warn about it. Signed-off-by: Ulf Hermann --- ChangeLog | 5 +++++ configure.ac | 12 ++++++++++++ libdw/ChangeLog | 5 +++++ libdw/Makefile.am | 9 +++++++-- 4 files changed, 29 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 01f88f3..e5b74fb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2017-04-28 Ulf Hermann + + * configure.ac: Check if the linker supports -rpath and output a + warning if it doesn't. + 2017-04-27 Ulf Hermann * configure.ac: Check if the compiler supports diff --git a/configure.ac b/configure.ac index efcd3c0..b943547 100644 --- a/configure.ac +++ b/configure.ac @@ -204,6 +204,18 @@ fi AC_SUBST([dso_LDFLAGS]) +AC_CACHE_CHECK([for rpath support], ac_cv_rpath, [dnl +save_LDFLAGS="$LDFLAGS" +LDFLAGS="$save_LDFLAGS -Wl,--enable-new-dtags,-rpath,/foo/bar" +AC_LINK_IFELSE([AC_LANG_PROGRAM()], ac_cv_rpath=yes, ac_cv_rpath=no) +LDFLAGS="$save_LDFLAGS" +]) +if test "$ac_cv_rpath" = "no"; then + AC_MSG_WARN([rpath is not supported. libdw will not automatically + find the ebl backends.]) +fi +AM_CONDITIONAL(RPATH, test "$ac_cv_rpath" = "yes") + AC_CACHE_CHECK([for __thread support], ac_cv_tls, [dnl # Use the same flags that we use for our DSOs, so the test is representative. # Some old compiler/linker/libc combinations fail some ways and not others. diff --git a/libdw/ChangeLog b/libdw/ChangeLog index 79c3898..45303d6 100644 --- a/libdw/ChangeLog +++ b/libdw/ChangeLog @@ -1,3 +1,8 @@ +2017-02-28 Ulf Hermann + + * Makefile.am: If the linker doesn't support -rpath, don't try to set + it. + 2017-02-27 Ulf Hermann * libdwP.h: Use attribute_hidden. diff --git a/libdw/Makefile.am b/libdw/Makefile.am index 31f7012..055e3f1 100644 --- a/libdw/Makefile.am +++ b/libdw/Makefile.am @@ -99,6 +99,12 @@ $(srcdir)/known-dwarf.h: $(top_srcdir)/config/known-dwarf.awk $(srcdir)/dwarf.h mv -f $@.new $@ endif +if RPATH +PKG_RPATH = -Wl,--enable-new-dtags,-rpath,$(pkglibdir) +else +PKG_RPATH = +endif + libdw_pic_a_SOURCES = am_libdw_pic_a_OBJECTS = $(libdw_a_SOURCES:.c=.os) @@ -115,8 +121,7 @@ libdw.so$(EXEEXT): $(srcdir)/libdw.map libdw_pic.a ../libdwelf/libdwelf_pic.a \ # The rpath is necessary for libebl because its $ORIGIN use will # not fly in a setuid executable that links in libdw. $(AM_V_CCLD)$(LINK) $(dso_LDFLAGS) -o $@ -Wl,--soname,$@.$(VERSION) \ - -Wl,--enable-new-dtags,-rpath,$(pkglibdir) \ - -Wl,--version-script,$<,--no-undefined \ + -Wl,--version-script,$<,--no-undefined $(PKG_RPATH) \ -Wl,--whole-archive $(filter-out $<,$^) -Wl,--no-whole-archive\ -ldl -lz $(intl_LDADD) $(zip_LIBS) $(libgnu) @$(textrel_check) -- 2.1.4