From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id AEB153858C50 for ; Thu, 9 Feb 2023 13:17:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEB153858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 99D8830067CA; Thu, 9 Feb 2023 14:17:56 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id 5BE803401F7; Thu, 9 Feb 2023 14:17:56 +0100 (CET) Message-ID: <3dc5ba6f8159291d61124a528eccb9cc3c076536.camel@klomp.org> Subject: Re: [PATCH v2 3/7] readelf: Fix set but not used parameter From: Mark Wielaard To: Ilya Leoshkevich Cc: elfutils-devel@sourceware.org Date: Thu, 09 Feb 2023 14:17:56 +0100 In-Reply-To: <20230208195226.144143-4-iii@linux.ibm.com> References: <20230208195226.144143-1-iii@linux.ibm.com> <20230208195226.144143-4-iii@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ilya, On Wed, 2023-02-08 at 20:52 +0100, Ilya Leoshkevich wrote: > clang complains: >=20 > readelf.c:12205:72: error: parameter 'desc' set but not used [-Werror= ,-Wunused-but-set-parameter] > handle_bit_registers (const Ebl_Register_Location *regloc, const void= *desc, > = ^ >=20 > Mark Wielaard says: >=20 > It is never really used since as far as I can see we don't have any > backend with a core register sets where a register doesn't have a > number of bits which isn't a multiple of 8 (only ia64 has some 1 > bit registers, but those don't seem part of the core register set). >=20 > If we do accidentally try to handle such a register having an abort > is also not very nice. Lets just warn and return/continue. >=20 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D30084 >=20 > Co-developed-by: Mark Wielaard > Signed-off-by: Ilya Leoshkevich Thanks, pushed. Mark