From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 81DD93858401 for ; Tue, 31 Aug 2021 11:38:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 81DD93858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 717C6300061B; Tue, 31 Aug 2021 13:38:02 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 64B26413CE32; Tue, 31 Aug 2021 13:38:01 +0200 (CEST) Message-ID: <3e385a62b34066da3152cf9746c02705f3d9736c.camel@klomp.org> Subject: Re: [PATCH v2] configure.ac: rework gnu99 ext check to allow clang From: Mark Wielaard To: Adrian Ratiu , elfutils-devel@sourceware.org Cc: manojgupta@chromium.org Date: Tue, 31 Aug 2021 13:38:01 +0200 In-Reply-To: <20210830154313.2775441-1-adrian.ratiu@collabora.com> References: <20210830154313.2775441-1-adrian.ratiu@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2021 11:38:18 -0000 Hi Adrian, On Mon, 2021-08-30 at 18:43 +0300, Adrian Ratiu wrote: > It is true that Clang does not support all gnu99 extensions [1], > but not all of them are used in the codebase and over time there > have been code cleanup efforts to improve Clang support. >=20 > For example after commit 779c57ea ("readelf: Pull advance_pc() > in file scope") there are no more nested function declarations > and elfutils now builds fine with Clang. >=20 > So in the interest of enabling Clang builds we remove the only > remaining blocker: the configure checks for nested functions and > variable length arrays which are also unused. >=20 > Considering mixed decls and code is also part of c99 standard, > the entire check becomes redundant and we can just replace > AC_PROG_CC -> AC_PROG_CC_C99. >=20 > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=3D24964 > Signed-off-by: Adrian Ratiu Thanks for reworking the patch. Pushed. Thanks, Mark