From: "Timm Bäder" <tbaeder@redhat.com>
To: Navin P <navinp0304@gmail.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 14/14] segment_report_module: Inline consider_phdr() into only caller
Date: Fri, 13 Nov 2020 08:41:07 +0100 [thread overview]
Message-ID: <470904a2-efef-f525-df60-9e4fcb3454a3@redhat.com> (raw)
In-Reply-To: <CALO2TqLTvYMEU7Ee0zPRNiS3n7XJtmj8PUdjbG4DRLiztTo4pg@mail.gmail.com>
On 12/11/2020 17:52, Navin P wrote:
> Hi,
> I already have a patch that makes elfutils compile with clang. Since
> you are working
> this will be of use to you. I've attached the patch since it is big.
>
> Here are some of the changes
> 1. All functions at file scope have static qualifier so that no
> collison with other files.
> 2. Non global variables declared in the outer function should be
> passed as pointer variable
> in the new outer file scope function whenever they are assigned in
> the nested function. The
> argument addition in new functions are at the end.
>
> 3. With the applied patch above , gcc passes all 220 tests where
> clang fails 3 tests which
> is due to llvm_addrsig (change in libelf/elf.h ) and other 2 tests
> are error related to
> .rela.eh_frame.
Thanks, Navin. Has this been proposed for inclusion in elfutils? What's
the status on that? Or are you just keeping this locally?
Looking at the patch, I'm not really a fan of a few of those changes,
from a code point of view. consider_phdr() takes 35 arguments now
for example.
Do you have more information on the test failures? Are they caused by
LLVM/clang bugs?
Thanks,
Timm
next prev parent reply other threads:[~2020-11-13 7:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 15:03 Removing gnu99 constructs from elfutils Timm Bäder
2020-11-12 15:03 ` [PATCH 01/14] segment_report_module: Get rid of variable-length arrays Timm Bäder
2020-11-18 23:04 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 02/14] segment_report_module: Pull segment_read into file scope Timm Bäder
2020-11-18 23:18 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 03/14] segment_report_module: Remove nested finish() function Timm Bäder
2020-11-19 11:18 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 04/14] segment_report_module: Remove nested release_buffer() function Timm Bäder
2020-11-19 11:24 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 05/14] segment_report_module: Pull finish_portion() info file scope Timm Bäder
2020-11-19 11:48 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 06/14] segment_report_module: Pull read_portion() into " Timm Bäder
2020-11-12 15:04 ` [PATCH 07/14] segment_report_module: Use a struct for build id information Timm Bäder
2020-11-12 15:04 ` [PATCH 08/14] segment_report_module: Pull consider_notes() into file scope Timm Bäder
2020-11-12 15:04 ` [PATCH 09/14] segment_report_module: Get rid of nested final_read() function Timm Bäder
2020-11-12 15:04 ` [PATCH 10/14] segment_report_module: Use one loop for p32/p64 arrays Timm Bäder
2020-11-12 15:04 ` [PATCH 11/14] segment_report_module: Inline read_phdr() into only caller Timm Bäder
2020-11-12 15:04 ` [PATCH 12/14] segment_report_module: Unify d32/d64 loops Timm Bäder
2020-11-12 15:04 ` [PATCH 13/14] segment_report_module: Inline consider_dyn() into only caller Timm Bäder
2020-11-12 15:04 ` [PATCH 14/14] segment_report_module: Inline consider_phdr() " Timm Bäder
2020-11-12 16:52 ` Navin P
2020-11-13 7:41 ` Timm Bäder [this message]
2020-11-13 8:00 ` Navin P
2020-11-13 12:38 ` Removing gnu99 constructs from elfutils Mark Wielaard
2020-11-13 14:09 ` Timm Bäder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470904a2-efef-f525-df60-9e4fcb3454a3@redhat.com \
--to=tbaeder@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=navinp0304@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).