From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 3EB203858409 for ; Tue, 14 Feb 2023 14:25:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3EB203858409 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 418C430067DA; Tue, 14 Feb 2023 15:25:25 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id DA525340341; Tue, 14 Feb 2023 15:25:24 +0100 (CET) Message-ID: <4a08df1535efb0994e4548663d3cc10b59e5a74c.camel@klomp.org> Subject: Re: [PATCH v3 4/4] configure: Add --enable-sanitize-memory From: Mark Wielaard To: Ilya Leoshkevich , "Frank Ch . Eigler" Cc: elfutils-devel@sourceware.org Date: Tue, 14 Feb 2023 15:25:24 +0100 In-Reply-To: <20230213164551.550400-5-iii@linux.ibm.com> References: <20230213164551.550400-1-iii@linux.ibm.com> <20230213164551.550400-5-iii@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3029.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ilya, On Mon, 2023-02-13 at 17:45 +0100, Ilya Leoshkevich wrote: > Add support for clang Memory Sanitizer [1], which detects the usage of > uninitialized values. While elfutils itself is already checked with > valgrind, checking code that depends on elfutils requires elfutils to > be built with MSan. >=20 > MSan is not linked into shared libraries, and is linked into > executables statically. Therefore, unlike the other sanitizers, MSan > needs to be configured fairly early, since we need to drop > -D_FORTIFY_SOURCE [2], -Wl,-z,defs and --no-undefined. >=20 > Disable a few tests that run for more than 5 minutes due to test files > being statically linked with MSan. Although I wasn't able to test this locally it looks all good. I did check the _FORTIFY_SOURCE and like flags are still normal and no tests are skipped without --enable-sanitize-memory. Pushed. Thanks, Mark