Hi, On Sat, 2022-12-17 at 05:19 +0800, 罗勇刚(Yonggang Luo) wrote: > On Fri, Oct 28, 2022 at 7:35 PM Mark Wielaard wrote: > > > > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel > > wrote: > > > Because all source in libebl #include , so #include > > > in > > > libeblP.h is enough, there is multiple memory-access.h file, so > > > use > > > relative path to > > > include it properly, > > > > I am not a fan of the relative path trick, especially if there it > > is > > clear only one is every needed. You also use it for other files, > > why? > > I am respect the original code > looks at > https://github.com/sourceware-org/elfutils/blob/master/libdwfl/core-file.c#L31 I see. But I rather fix that than do the same in new files. The attached patch does that so no relative paths are needed in #include statements. Cheers, Mark