Re: [PATCH] Update .gitignore file

Re: [PATCH] Update .gitignore file

[Florian Weimer]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

On 04/15/2014 07:55 PM, Mike Frysinger wrote:

> i have no problem with encouraging people to build out of tree (i love that
> functionality).  sometimes though, it's easier to just build in tree to do
> quick tests.  i also don't think it's a big deal to support, or to just take
> patches tweaking the gitignore file even if people themselves don't want to
> maintain it.

I don't really care either way.  The current hints (.gitignore contents, 
INSTALL instructions) point towards in-tree builds.  But now I'm 
building out-of-tree.

> might be easier to keep these lists in src/.gitignore or tests/.gitignore.
> i'm fine with either.

I think this would make sense if we want to complete the listing of 
auto-generated files.

So which way do we want to go?  Remove all ignored files only generated 
during an in-tree build, or add the missing auto-generated files from 
such a build?

-- 
Florian Weimer / Red Hat Product Security Team

Re: [PATCH] Update .gitignore file

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 3274 bytes --]

On Tue 15 Apr 2014 14:34:42 Mark Wielaard wrote:
> On Mon, 2014-04-14 at 11:12 +0200, Florian Weimer wrote:
> >  .gitignore | 99
> >  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file
> >  changed, 99 insertions(+)
> 
> Hmmm. This is all for building with srcdir == builddir isn't it?
> I really don't like that. IMHO we should advise people to always build
> with srcdir != buildir. But apparently I am in the minority. Mike
> Frysinger (added to CC) also keeps trying to push something similar
> every couple of months. Last here:
> https://lists.fedorahosted.org/pipermail/elfutils-devel/2014-January/thread.
> html#3682
> 
> Are you really sure this is a good idea?

i have no problem with encouraging people to build out of tree (i love that 
functionality).  sometimes though, it's easier to just build in tree to do 
quick tests.  i also don't think it's a big deal to support, or to just take 
patches tweaking the gitignore file even if people themselves don't want to 
maintain it.

> If so could you double check that your lists are equal?

if you want to merge Florian's version, i'd be happy to rebase

> > +/src/addr2line
> > +/src/ar
> > +/src/elfcmp
> > +/src/elflint
> > +/src/findtextrel
> > +/src/ld
> > +/src/ldlex.c
> > +/src/ldscript.c
> > +/src/ldscript.h
> > +/src/make-debug-archive
> > +/src/nm
> > +/src/objdump
> > +/src/ranlib
> > +/src/readelf
> > +/src/size
> > +/src/stack
> > +/src/strings
> > +/src/strip
> > +/src/unstrip
> > +/tests/*.log
> > +/tests/*.trs
> > +/tests/addrcfi
> > +/tests/addrscopes
> > +/tests/alldts
> > +/tests/allfcts
> > +/tests/allregs
> > +/tests/arextract
> > +/tests/arls
> > +/tests/arsymtest
> > +/tests/asm-tst1
> > +/tests/asm-tst2
> > +/tests/asm-tst3
> > +/tests/asm-tst4
> > +/tests/asm-tst5
> > +/tests/asm-tst6
> > +/tests/asm-tst7
> > +/tests/asm-tst8
> > +/tests/asm-tst9
> > +/tests/backtrace
> > +/tests/backtrace-child
> > +/tests/backtrace-data
> > +/tests/backtrace-dwarf
> > +/tests/dwarf-getmacros
> > +/tests/dwarf-getstring
> > +/tests/dwfl-addr-sect
> > +/tests/dwfl-bug-addr-overflow
> > +/tests/dwfl-bug-fd-leak
> > +/tests/dwfl-bug-getmodules
> > +/tests/dwfl-bug-report
> > +/tests/dwfl-report-elf-align
> > +/tests/dwfllines
> > +/tests/dwflmodtest
> > +/tests/dwflsyms
> > +/tests/early-offscn
> > +/tests/ecp
> > +/tests/find-prologues
> > +/tests/funcretval
> > +/tests/funcscopes
> > +/tests/get-aranges
> > +/tests/get-files
> > +/tests/get-lines
> > +/tests/get-pubnames
> > +/tests/hash
> > +/tests/line2addr
> > +/tests/low_high_pc
> > +/tests/md5-sha1-test
> > +/tests/msg_tst
> > +/tests/newfile
> > +/tests/newscn
> > +/tests/rdwrmmap
> > +/tests/rerequest_tag
> > +/tests/saridx
> > +/tests/scnnames
> > +/tests/sectiondump
> > +/tests/show-abbrev
> > +/tests/show-die-info
> > +/tests/showptable
> > +/tests/test-elf_cntl_gelf_getshdr
> > +/tests/test-flag-nobits
> > +/tests/test-nlist
> > +/tests/typeiter
> > +/tests/typeiter2
> > +/tests/update1
> > +/tests/update2
> > +/tests/update3
> > +/tests/update4
> > +/tests/varlocs

might be easier to keep these lists in src/.gitignore or tests/.gitignore.  
i'm fine with either.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] Update .gitignore file

[Florian Weimer]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

On 04/15/2014 02:34 PM, Mark Wielaard wrote:
> On Mon, 2014-04-14 at 11:12 +0200, Florian Weimer wrote:
>> ---
>>   .gitignore | 99 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 99 insertions(+)
>
> Hmmm. This is all for building with srcdir == builddir isn't it?

Indeed.

> I really don't like that. IMHO we should advise people to always build
> with srcdir != buildir.

Oh, it's a valid position.  But based on the .gitignore file, that 
wasn't obvious to me at all because it covers *some* of the generated 
files, but not all of them.  I'll propose a cleanup in the other 
direction, removing unnecessary entries that are not needed with srcdir 
!= builddir, and adding a comment that you should build in a separate 
directory.

-- 
Florian Weimer / Red Hat Product Security Team

Re: [PATCH] Update .gitignore file

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 3182 bytes --]

On Mon, 2014-04-14 at 11:12 +0200, Florian Weimer wrote:
> ---
>  .gitignore | 99 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 99 insertions(+)

Hmmm. This is all for building with srcdir == builddir isn't it?
I really don't like that. IMHO we should advise people to always build
with srcdir != buildir. But apparently I am in the minority. Mike
Frysinger (added to CC) also keeps trying to push something similar
every couple of months. Last here:
https://lists.fedorahosted.org/pipermail/elfutils-devel/2014-January/thread.html#3682

Are you really sure this is a good idea?
If so could you double check that your lists are equal?

Thanks,

Mark

> diff --git a/.gitignore b/.gitignore
> index 1eda00b..7740453 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -15,6 +15,7 @@
>  .deps
>  .glimpse_*
>  =*
> +/version.h
>  INSTALL
>  Makefile
>  Makefile.in
> @@ -36,7 +37,105 @@ config/ylwrap
>  configure
>  elfutils.spec
>  libcpu/*_dis.h
> +/libcpu/*.mnemonics
> +/libcpu/*_gendis
> +/libcpu/*_lex.c
> +/libcpu/*_parse.[ch]
> +/libcpu/i386_parse.h
> +/lib*/*.so*
>  libdw/known-dwarf.h
> +/po/POTFILES
> +/po/en@boldquot.insert-header
> +/po/en@quot.insert-header
> +/po/remove-potcdate.sed
> +/po/stamp-po
>  po/en@boldquot.po
>  po/en@quot.po
> +/src/addr2line
> +/src/ar
> +/src/elfcmp
> +/src/elflint
> +/src/findtextrel
> +/src/ld
> +/src/ldlex.c
> +/src/ldscript.c
> +/src/ldscript.h
> +/src/make-debug-archive
> +/src/nm
> +/src/objdump
> +/src/ranlib
> +/src/readelf
> +/src/size
> +/src/stack
> +/src/strings
> +/src/strip
> +/src/unstrip
> +/tests/*.log
> +/tests/*.trs
> +/tests/addrcfi
> +/tests/addrscopes
> +/tests/alldts
> +/tests/allfcts
> +/tests/allregs
> +/tests/arextract
> +/tests/arls
> +/tests/arsymtest
> +/tests/asm-tst1
> +/tests/asm-tst2
> +/tests/asm-tst3
> +/tests/asm-tst4
> +/tests/asm-tst5
> +/tests/asm-tst6
> +/tests/asm-tst7
> +/tests/asm-tst8
> +/tests/asm-tst9
> +/tests/backtrace
> +/tests/backtrace-child
> +/tests/backtrace-data
> +/tests/backtrace-dwarf
> +/tests/dwarf-getmacros
> +/tests/dwarf-getstring
> +/tests/dwfl-addr-sect
> +/tests/dwfl-bug-addr-overflow
> +/tests/dwfl-bug-fd-leak
> +/tests/dwfl-bug-getmodules
> +/tests/dwfl-bug-report
> +/tests/dwfl-report-elf-align
> +/tests/dwfllines
> +/tests/dwflmodtest
> +/tests/dwflsyms
> +/tests/early-offscn
> +/tests/ecp
> +/tests/find-prologues
> +/tests/funcretval
> +/tests/funcscopes
> +/tests/get-aranges
> +/tests/get-files
> +/tests/get-lines
> +/tests/get-pubnames
> +/tests/hash
> +/tests/line2addr
> +/tests/low_high_pc
> +/tests/md5-sha1-test
> +/tests/msg_tst
> +/tests/newfile
> +/tests/newscn
> +/tests/rdwrmmap
> +/tests/rerequest_tag
> +/tests/saridx
> +/tests/scnnames
> +/tests/sectiondump
> +/tests/show-abbrev
> +/tests/show-die-info
> +/tests/showptable
> +/tests/test-elf_cntl_gelf_getshdr
> +/tests/test-flag-nobits
> +/tests/test-nlist
> +/tests/typeiter
> +/tests/typeiter2
> +/tests/update1
> +/tests/update2
> +/tests/update3
> +/tests/update4
> +/tests/varlocs
>  stamp-h1

[PATCH] Update .gitignore file

[Florian Weimer]

[-- Attachment #1: Type: text/plain, Size: 2373 bytes --]

---
 .gitignore | 99 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 99 insertions(+)

diff --git a/.gitignore b/.gitignore
index 1eda00b..7740453 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,6 +15,7 @@
 .deps
 .glimpse_*
 =*
+/version.h
 INSTALL
 Makefile
 Makefile.in
@@ -36,7 +37,105 @@ config/ylwrap
 configure
 elfutils.spec
 libcpu/*_dis.h
+/libcpu/*.mnemonics
+/libcpu/*_gendis
+/libcpu/*_lex.c
+/libcpu/*_parse.[ch]
+/libcpu/i386_parse.h
+/lib*/*.so*
 libdw/known-dwarf.h
+/po/POTFILES
+/po/en@boldquot.insert-header
+/po/en@quot.insert-header
+/po/remove-potcdate.sed
+/po/stamp-po
 po/en@boldquot.po
 po/en@quot.po
+/src/addr2line
+/src/ar
+/src/elfcmp
+/src/elflint
+/src/findtextrel
+/src/ld
+/src/ldlex.c
+/src/ldscript.c
+/src/ldscript.h
+/src/make-debug-archive
+/src/nm
+/src/objdump
+/src/ranlib
+/src/readelf
+/src/size
+/src/stack
+/src/strings
+/src/strip
+/src/unstrip
+/tests/*.log
+/tests/*.trs
+/tests/addrcfi
+/tests/addrscopes
+/tests/alldts
+/tests/allfcts
+/tests/allregs
+/tests/arextract
+/tests/arls
+/tests/arsymtest
+/tests/asm-tst1
+/tests/asm-tst2
+/tests/asm-tst3
+/tests/asm-tst4
+/tests/asm-tst5
+/tests/asm-tst6
+/tests/asm-tst7
+/tests/asm-tst8
+/tests/asm-tst9
+/tests/backtrace
+/tests/backtrace-child
+/tests/backtrace-data
+/tests/backtrace-dwarf
+/tests/dwarf-getmacros
+/tests/dwarf-getstring
+/tests/dwfl-addr-sect
+/tests/dwfl-bug-addr-overflow
+/tests/dwfl-bug-fd-leak
+/tests/dwfl-bug-getmodules
+/tests/dwfl-bug-report
+/tests/dwfl-report-elf-align
+/tests/dwfllines
+/tests/dwflmodtest
+/tests/dwflsyms
+/tests/early-offscn
+/tests/ecp
+/tests/find-prologues
+/tests/funcretval
+/tests/funcscopes
+/tests/get-aranges
+/tests/get-files
+/tests/get-lines
+/tests/get-pubnames
+/tests/hash
+/tests/line2addr
+/tests/low_high_pc
+/tests/md5-sha1-test
+/tests/msg_tst
+/tests/newfile
+/tests/newscn
+/tests/rdwrmmap
+/tests/rerequest_tag
+/tests/saridx
+/tests/scnnames
+/tests/sectiondump
+/tests/show-abbrev
+/tests/show-die-info
+/tests/showptable
+/tests/test-elf_cntl_gelf_getshdr
+/tests/test-flag-nobits
+/tests/test-nlist
+/tests/typeiter
+/tests/typeiter2
+/tests/update1
+/tests/update2
+/tests/update3
+/tests/update4
+/tests/varlocs
 stamp-h1
-- 
1.9.0