From: Richard Henderson <rth@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH 2/3] Simplify and inline get_uleb128 and get_sleb128
Date: Tue, 22 Apr 2014 08:58:25 -0700 [thread overview]
Message-ID: <535691A1.2020905@redhat.com> (raw)
In-Reply-To: 53569021.9040104@redhat.com
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
On 04/22/2014 08:52 AM, Josh Stone wrote:
> The trick in the original was that "(typeof (var)) __s.i" would extend
> the sign from the 7th bit, which I don't your mask will do.
Yes, that was another cut/paste error.
Not a great batting average this morning... ;-)
> So in total:
>
> struct { signed int i:7; } __s = { .i = __b };
> (var) |= (typeof (var)) __s.i * ((typeof (var)) 1 << ((nth) * 7));
>
> Better?
Yes, that's what I had in mind.
r~
next reply other threads:[~2014-04-22 15:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 15:58 Richard Henderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-24 9:49 Mark Wielaard
2014-04-23 22:32 Petr Machata
2014-04-23 21:54 Mark Wielaard
2014-04-23 20:29 Petr Machata
2014-04-23 19:01 Josh Stone
2014-04-23 18:51 Richard Henderson
2014-04-23 18:32 Petr Machata
2014-04-23 15:27 Richard Henderson
2014-04-23 10:17 Petr Machata
2014-04-22 22:04 Mark Wielaard
2014-04-22 15:52 Josh Stone
2014-04-22 15:03 Richard Henderson
2014-04-22 15:01 Richard Henderson
2014-04-22 14:55 Mark Wielaard
2013-12-12 22:23 Petr Machata
2013-12-12 19:06 Josh Stone
2013-12-12 12:13 Petr Machata
2013-12-11 1:35 Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535691A1.2020905@redhat.com \
--to=rth@redhat.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).