From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id A99C5385E006 for ; Fri, 27 Mar 2020 00:13:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A99C5385E006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7BC67300D947; Fri, 27 Mar 2020 01:13:05 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 618B04000C89; Fri, 27 Mar 2020 01:13:05 +0100 (CET) Message-ID: <53baf558b0fd95968d6e8c739307fb7489b9fa83.camel@klomp.org> Subject: Re: patch PR25583: debuginfod bsdtar for deb From: Mark Wielaard To: "Frank Ch. Eigler" , elfutils-devel@sourceware.org Date: Fri, 27 Mar 2020 01:13:05 +0100 In-Reply-To: <20200325145747.GA8051@redhat.com> References: <20200325145747.GA8051@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2020 00:13:08 -0000 Hi Frank, On Wed, 2020-03-25 at 10:57 -0400, Frank Ch. Eigler via Elfutils-devel wrot= e: > Author: Frank Ch. Eigler > Date: Wed Mar 25 10:55:53 2020 -0400 >=20 > PR25583: debuginfod: prefer bsdtar to dpkg for .deb handling > =20 > It turns out a bsdtar subshell can do the job of dpkg-deb. > bsdtar comes from/with libarchive so it should be available > everywhere. The patch itself looks correct. And it is a win for non-deb based systems since the bsdtar dependencies are already there. But for .deb based systems it is more likely they already have dpkg installed, while bsdtar might be a separate install/package. And it still needs to spawn an external process. I looked at the buildbot workers and none had bsdtar installed. I have installed it now on the i386, debian/fedora/centos-x86_64, arm32 and arm64 workers and have requested it to be installed on the s390x and ppc64[le] workers. I am not against this patch, but I do wonder if it should not try to fall back on dpkg if bsdtar isn't installed. Cheers, Mark