public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Missing newline for: elfcompress -t zlib-gnu a.out -force
@ 2022-11-28 13:03 Martin Liška
  2022-11-28 14:43 ` Mark Wielaard
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Liška @ 2022-11-28 13:03 UTC (permalink / raw)
  To: elfutils-devel; +Cc: Mark Wielaard

Hey.

Fixes:
./src/elfcompress -t zlib-gnu a.out -force
[28] .zdebug_aranges unchanged, already GNU compressed[29] .zdebug_info unchanged, already GNU compressed[30] .zdebug_abbrev unchanged, already GNU compressed[31] .zdebug_line unchanged, already GNU compressed[32] .zdebug_str unchanged, already GNU compressed[33] .zdebug_line_str unchanged, already GNU compressed[34] .zdebug_rnglists unchanged, already GNU compressed

to:
./src/elfcompress -t zlib-gnu a.out -force
[28] .zdebug_aranges unchanged, already GNU compressed
[29] .zdebug_info unchanged, already GNU compressed
[30] .zdebug_abbrev unchanged, already GNU compressed
[31] .zdebug_line unchanged, already GNU compressed
[32] .zdebug_str unchanged, already GNU compressed
[33] .zdebug_line_str unchanged, already GNU compressed
[34] .zdebug_rnglists unchanged, already GNU compressed

I'm going to push it as obvious, hope it's fine?

Thanks,
Martin

src/ChangeLog:

	* elfcompress.c (process_file): Add missing newline.
---
  src/elfcompress.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/elfcompress.c b/src/elfcompress.c
index 6f18e47d..51ff69d2 100644
--- a/src/elfcompress.c
+++ b/src/elfcompress.c
@@ -765,7 +765,7 @@ process_file (const char *fname)
  	      else if (verbose >= 0)
  		{
  		  if (startswith (sname, ".zdebug"))
-		    printf ("[%zd] %s unchanged, already GNU compressed",
+		    printf ("[%zd] %s unchanged, already GNU compressed\n",
  			    ndx, sname);
  		  else
  		    printf ("[%zd] %s cannot GNU compress section not starting with .debug\n",
-- 
2.38.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Missing newline for: elfcompress -t zlib-gnu a.out -force
  2022-11-28 13:03 [PATCH] Missing newline for: elfcompress -t zlib-gnu a.out -force Martin Liška
@ 2022-11-28 14:43 ` Mark Wielaard
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2022-11-28 14:43 UTC (permalink / raw)
  To: Martin Liška, elfutils-devel

Hi Martin,

On Mon, 2022-11-28 at 14:03 +0100, Martin Liška wrote:
> Fixes:
> ./src/elfcompress -t zlib-gnu a.out -force
> [28] .zdebug_aranges unchanged, already GNU compressed[29]
> .zdebug_info unchanged, already GNU compressed[30] .zdebug_abbrev
> unchanged, already GNU compressed[31] .zdebug_line unchanged, already
> GNU compressed[32] .zdebug_str unchanged, already GNU compressed[33]
> .zdebug_line_str unchanged, already GNU compressed[34]
> .zdebug_rnglists unchanged, already GNU compressed
> 
> to:
> ./src/elfcompress -t zlib-gnu a.out -force
> [28] .zdebug_aranges unchanged, already GNU compressed
> [29] .zdebug_info unchanged, already GNU compressed
> [30] .zdebug_abbrev unchanged, already GNU compressed
> [31] .zdebug_line unchanged, already GNU compressed
> [32] .zdebug_str unchanged, already GNU compressed
> [33] .zdebug_line_str unchanged, already GNU compressed
> [34] .zdebug_rnglists unchanged, already GNU compressed
> 
> I'm going to push it as obvious, hope it's fine?

Yes, obvious typo. Thanks for fixing it.

Also the buildbot arm32 failure on run-debuginfod-federation-metrics.sh 
was clearly unrelated. Another Fatal error in GNU libmicrohttpd
daemon.c:3239: Failed to remove FD from epoll set. Grmbl.
Undeterministic tests :{

Cheers,

Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-28 14:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28 13:03 [PATCH] Missing newline for: elfcompress -t zlib-gnu a.out -force Martin Liška
2022-11-28 14:43 ` Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).