From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH 07/10] debuginfod: Handle not being able to fopen interval_path.
Date: Wed, 24 Jun 2020 17:04:19 +0200 [thread overview]
Message-ID: <56d15e62857a82b8afe627b9f26e4626901183d2.camel@klomp.org> (raw)
In-Reply-To: <20200616222539.29109-7-mark@klomp.org>
Hi,
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote:
> Although we check for and/or create the interval_path right before,
> there is still a possibility that the fopen call fails. Handle that
> as if the file is unreadable.
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote:
> We need to make sure that we can always place a zero terminator at
> the end of suffix when we are copying the filename. So add one more
> char to the suffix array. And make sure that we can always add an
> extra escape character when we need to escape the current character.
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote:
> When is debuginfod_query_server is given an hexadecimal string as
> build-id build_id_len will be zero. We were checking the size of
> the build_id_bytes destination string instead of the string length
> of build_id input string. Make sure the input string is not too
> big or strcpy might overwrite then end of the build_id_bytes array.
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote:
> When allocating handle_data we should check for out of memory failures.
> Also when the allocation has succeeded make sure we always clean up by
> going to out1 on any future errors. So move the curl_multi_init call
> earlier, because that goes to out0 on failure.
Aaron was nice enough to review these debuginfod related fixes (off-
list). Pushed all 4 to master now.
Cheers,
Mark
next prev parent reply other threads:[~2020-06-24 15:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 22:25 [PATCH 01/10] backends: Make the reloc_nametable zero element an one char array Mark Wielaard
2020-06-16 22:25 ` [PATCH 02/10] libdw: Add missing FALLTHROUGH in execute_cfi Mark Wielaard
2020-06-19 12:56 ` Mark Wielaard
2020-06-16 22:25 ` [PATCH 03/10] elflint: Explicitly check and ignore elf_compress error Mark Wielaard
2020-06-19 13:48 ` Mark Wielaard
2020-06-16 22:25 ` [PATCH 04/10] libdwfl: When we find a compressed image, use that, don't search for others Mark Wielaard
2020-06-19 17:03 ` Mark Wielaard
2020-06-16 22:25 ` [PATCH 05/10] libdwfl: Flag an error if CIE return_address_register is invalid Mark Wielaard
2020-06-19 17:58 ` Mark Wielaard
2020-06-16 22:25 ` [PATCH 06/10] ar, ranlib: Call fchown before fchmod, explicitly check and ignore errors Mark Wielaard
2020-06-19 18:52 ` Mark Wielaard
2020-06-16 22:25 ` [PATCH 07/10] debuginfod: Handle not being able to fopen interval_path Mark Wielaard
2020-06-24 15:04 ` Mark Wielaard [this message]
2020-06-16 22:25 ` [PATCH 08/10] debuginfod: Make sure suffix can place zero terminator when copying filename Mark Wielaard
2020-06-16 22:25 ` [PATCH 09/10] debuginfod: Fix build_id hexadecimal length check Mark Wielaard
2020-06-16 22:25 ` [PATCH 10/10] debuginfod: Make sure handle_data can be allocated and is always freed Mark Wielaard
2020-06-19 11:43 ` [PATCH 01/10] backends: Make the reloc_nametable zero element an one char array Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d15e62857a82b8afe627b9f26e4626901183d2.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).