From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: Noah Sanci <nsanci@redhat.com>, elfutils-devel@sourceware.org
Subject: Re: PR: 25978
Date: Thu, 08 Jul 2021 17:04:28 +0200 [thread overview]
Message-ID: <579416e4b2be929fe44005a6273b8444d62ba37c.camel@klomp.org> (raw)
In-Reply-To: <20210708131220.GB31689@redhat.com>
Hi,
On Thu, 2021-07-08 at 09:12 -0400, Frank Ch. Eigler wrote:
> > If they are portions of the full fdcache shouldn't there be a check
> > in the code that the specified fdcache_prefetch_fds and
> > fdcache_prefetch_mbs aren't larger than fdcache_fds and fdcache_mbs? Or
> > maybe they should be given as percentages?
>
> We've iterated on a couple of ways of representing & controlling this.
> The code makes the lru and prefetch caches separate, in that they have
> separate limits and separate metrics. So there is no requirement for
> the prefetch one to be smaller than the other.
Aha, yes, that does look like how the code actually works. Lets make
sure the documentation matches that description (or at least remove the
phrase "portion of").
Cheers,
Mar
prev parent reply other threads:[~2021-07-08 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 18:24 Noah Sanci
2021-07-08 13:07 ` Mark Wielaard
2021-07-08 13:12 ` Frank Ch. Eigler
2021-07-08 15:04 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579416e4b2be929fe44005a6273b8444d62ba37c.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
--cc=nsanci@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).