From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 1FB603854177 for ; Mon, 31 Oct 2022 13:29:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1FB603854177 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=wildebeest.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=wildebeest.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 054933061FA1; Mon, 31 Oct 2022 14:29:45 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 2BCA040216A6; Mon, 31 Oct 2022 14:29:44 +0100 (CET) Message-ID: <586fbfd512763e539f0d06e8ffa308da34be5368.camel@wildebeest.org> Subject: Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec' From: Mark Wielaard To: "Frank Ch. Eigler" , luoyonggang@gmail.com Cc: elfutils-devel@sourceware.org Date: Mon, 31 Oct 2022 14:29:43 +0100 In-Reply-To: <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> References: <20220920084307.1696-1-luoyonggang@gmail.com> <20220920084307.1696-2-luoyonggang@gmail.com> <20221019194930.GC24703@redhat.com> <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Thu, 2022-10-20 at 18:07 +0200, Mark Wielaard wrote: > So maybe we just should rename them to .specfile? > That is what the attached patch does, plus some other cleanups. > - We forgot to include the hello3.specfile > - Remove the --sign from rpmbuild > - escape the % in spec comments >=20 > That makes make rpm work out of the box without warnings. > Does it also help the windows git thing? I pushed this. Please let me know if it works for you. Thanks, Mark