From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5596 invoked by alias); 22 Feb 2017 16:45:35 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 127953 invoked by uid 89); 22 Feb 2017 16:45:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=fts, excited X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kY2NYf9CF9HJzN2Ajf83Dx5ilEJPY1RUDmBnCnpW4bA=; b=Tl+KNt+stc4JaEWBJrnXelADaUJQzh+TvJW7NB4NSOrLUYzqSisKkBseKACEzjab6Y0rwhzuoNNsQr/JprQBguLRwP/hkL/BFaXqIekm5TDacNMBzqhkdHtTnEJZxoW6pvj43qCiUKQhKPMKVZ4ASNW8u3vPOOJ/SqXoAyuHtlU= Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io; Subject: Re: [PATCH] Check for existence of asprintf and vasprintf To: elfutils-devel@sourceware.org References: <4efb45a7-3035-67eb-d61e-62e795afd881@qt.io> <20170222144004.GV28432@vapier> <3716c28b-6478-ee4d-50cf-0ef43e8196f3@qt.io> <20170222163249.GW28432@vapier> From: Ulf Hermann Message-ID: <59040cc2-f681-7610-5115-9a7c6c94b6c9@qt.io> Date: Wed, 22 Feb 2017 16:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170222163249.GW28432@vapier> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: AM5PR0901CA0024.eurprd09.prod.outlook.com (2603:10a6:203:16::34) To DB5PR0201MB1863.eurprd02.prod.outlook.com (2603:10a6:0:32::21) X-MS-Office365-Filtering-Correlation-Id: a2c6b850-a671-4677-0216-08d45b422ca4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB5PR0201MB1863; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;3:0Jy9eo30K0TlZE4SD0bgbg6ZT2XH93XkHAePg/Fv+XAd31LQ/oHsiz2yaN/bW7ThMTzljcVgAN8jwcEicxyRnudrpsyqJAUOMO2h/uWicJmLd/D2X3Nwsmc44NMm6W0CRTQgpyD0gcyYNRvmgkLvmtPjaNO8o5dm4f9BZhE3fhCtbkayqkUhy3ZioNCJU3tE3C0xYsvQZmcfocIsgMesDthPXgBBqPIy17QmiXsKbI2oEQ29uReYXu/KXfWnunvpK1bzRWKu0wzHqR6xRp/pBA==;25:KnS3oP32ekYlRe+6R7jQRDivfjkEwm03I7pTDtHOs85JiAagg6FPpwHTzH6roG2yDlnPSXcY8+wq5AUCa99iMWfeVhDA050CcnEt0i72qG+v8kvdf5uRRiBxx/IHfJRFCf28ebo1OmL/vDi79wrRNQTP9d4D99q6/PrjvRvi7mu4x/A4C+Ed2WU2rFxjWRv+kX3t9jslbt0RawZ/RZr+H/bwFnkjEAIQ5giOD1i0RAZA7AHAb2FxCHoSIeaqnh0asDV6Q1NEtv89/q1LVHo5qT891SPIFCaDpNJcpV6bKjTq65LLIGTAtnDCHDTw7GxhjajEuoR3htYo7MEZHQdNEkclN8bguuL0en9/Wdsw7MMo6/qayJgbKjp/OaqU7NJyCl6I8OkLWMMbystMJh+FgQrlujdT8epKUdCnasCphLjxlzZx/GCHT2LpnOCEegcSkNT8T2hk85yh8LheSNYSuw== X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;31:ikKXwWhPS5+k0X6Txl+rMprjugUCp24FrIvksbc8Vs1OpewGQpq+K40nOzzCfZLw7uSZACRMChAZycFY56ckjkhlOR0wjMHXFLQ6m9e0ZUDiO8UPEDxmpZvlAaEVvk0fJjGTSF7p2uEVAU5Fb5k9J9JMNGYcUhMu3iuNPfhZIney0rZcSL8P36tdEtziqBYe4lzK47AtF7o4e7jYp50F0LA4hBUMHhLWsUodzfDNUutlTEeDDicZyw++eiiI2Z6ExFSPpX7FaBQm3S5yZ1ZIaHHo5yzL2dCNPhnnPHTGgNc=;20:Djcwel+pCmiEHtsatxKBVbKl+j5scVqt0tr4Uw95Y1xfN0fITZTPFUPH7GYHVOZ6yddIzuQYkpY5+W2i+M45OrBxPhhI+Y4UhFNdvfZ9OJ8qQbGGM8Q1NNFTUBHtsHvUfAr4AM4QFmu1Cm6VFjVc+GaMmhM4aQJ5GGyLax1hVc6y1aXyLdI7IhLzFetPxxfpk2kqO2ARCVjmTszwqwVHYd0o1MJDMmTqPU5jqGyS+dFbbzqhKlXJTm93RMObflsY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(20161123558025)(6072148);SRVR:DB5PR0201MB1863;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0201MB1863; X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;4:YIpocWXSu9fv4mS9joKV3Bxls7ZRS/tbGbxiaQtGegU7l/noQZV6W4Ff5UbdMFO/64q6ZGFmFqZqksBgAoUNZc24aKO6yCVzGw14NTTWHjbfC6YR3TVtrTrxYg3FTaTj2i+dxWDJ5yAT+GM+iHh0DbDHhM+RTsdYr3B3PI/CwOCTzoZ4+3ZbdUeZNyrgZE6LjARkg5r2TytVfsF3mQSGthjPbBEEhRYK4dMjYDFCKEWuCjFHnzQhnPsVarzENw6ie4IfK9rankZB6sgD+5BauuSLJqE4ZAu0hzkk+XK5x69e5x+SktmJA4chIpcOoxtpye/tcYMsGhlgLEwK6rl46TT0xllZq7zb5zVWolFDB3GR1m88v3TtDK4HPKTTKjWPv0/ELk4OJQsCf0A71ovfoQItGi0h5IGYEtUoWZRdQ5rxuuiV50CQM+E7NPvuADDExoT9nLFNDg5XKlRgd7xQRmDlgYp2Bkaibqqtg23Eo3dX05eRwZK629WevAaASwmHkLcu56ocFQ308Rbm7yiXgbH+pkjIK4LmHcqS3hJJBrjE8+a2NwiaQPwGrToINWSUhf0nuJJ3uWsUwuMbI6sFZOGu7T7gq3zL2FOzbpLq9/A= X-Forefront-PRVS: 022649CC2C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(42186005)(7736002)(230700001)(2351001)(92566002)(53936002)(4001350100001)(2906002)(38730400002)(93886004)(50986999)(76176999)(50466002)(305945005)(83506001)(2950100002)(54356999)(6916009)(77096006)(23676002)(110136004)(5660300001)(450100001)(6486002)(66066001)(31696002)(47776003)(3846002)(31686004)(36756003)(6116002)(64126003)(8676002)(33646002)(74482002)(6246003)(2361001)(229853002)(86362001)(81166006)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR0201MB1863;H:[10.9.78.69];FPR:;SPF:None;MLV:nspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjAyMDFNQjE4NjM7MjM6ejBaa28yMkcrOE5QWDI4bHkvM2MrVXJG?= =?utf-8?B?NUhaSHRRRFJEZkhWb2lGaVlEeUh0b2NtVXlWaytOQTQ3cy9tekpOSU5wSTNJ?= =?utf-8?B?aitBTGhWTy9EN3U2bk41bmU2K3pILzJ0NHkwbXlycHRrYWhSc2pGYVVoQldi?= =?utf-8?B?WlFyZytiM296Ymk2NG9kMFZMczB6YlM0RGh6YlR2VG4rT2F5bFJ4bFQ4TzE3?= =?utf-8?B?ZFBWb3ZZSDFueld2YmtyNlVKK3ZXVVlpQ1EwZnhTeTF4N0FnRU1KVHBzYXpH?= =?utf-8?B?NHVLYlkwVW1LRFkycllSSTRCR08xSDZyMng3bmRVcEJnZ3ExMXJYZnNXSlVn?= =?utf-8?B?NzhYK01mS3JqY1FacVNGV1dXM0k4ZUprMXNuSXJjcWt2NXF4L2kxWFRzMGsx?= =?utf-8?B?YnNoVXZIaFVtcnVyalNmQkhrem9YcXdsazhtTCtCblV5S21vNHpIenZTQ3dw?= =?utf-8?B?VEU1RXA4Ty9zaEpVUHlvOU1DUnZ0ZzdPaTNGM0NCVjhKRU5HWHJVYitUOUMz?= =?utf-8?B?QTViQmdrVmlUYjZlQSt0TWxyRTFHby96L3NhcksxTlMxa0tqWnpvNE43cWtS?= =?utf-8?B?Yk1pbVFBZUxid0Y2RGVKWEVIcmpZbW9GRUVvWEkzeXBaSFJVdnFlNVVqOUZ2?= =?utf-8?B?UGI2ci93TUtpWEVEUURmTmZrNTZ0cEgza3lUcW1FNVFlT211bEM4TWdSbGNY?= =?utf-8?B?azNNenFJQ2RrRjd1R2J0SnJJMitVckZZSnQ1YWFsbFFoa01FcXVZNmxXUGdq?= =?utf-8?B?VFl0S1QyWFBoUmswQUxYeHlXOVUzQnZhM3NOc0lBU3lCVTAzV3ZaK2xveUJk?= =?utf-8?B?UjBXQ2NwOWt4OFlTWXh4b1VIQ204V0RaQWxjQkhVS0YwWHN6eG1FaWNQMGN2?= =?utf-8?B?RXJqNHVsTXRuang1dk82QVFaVlduMDQ2anlCUktGZjVhM2tJdHVMNm5uTEtB?= =?utf-8?B?NHcvczZDZXQ1S0xadEtRTDhoa1Z4SHBWTVRZaWJlbmphUDVHVEdwN2FzQ3Jt?= =?utf-8?B?dVJ3eFFnREVOTmRzUEhwOWt6Q3I5aEFNR3dNN29TYWVZc2taWUduRHE3RkhC?= =?utf-8?B?Qk5PV2I0aXI4NnZDZlFqa0Q4OFZyTCtyM2F2OEVmOGJuYy9rYmNCczFDKytz?= =?utf-8?B?bkdiODFUREJYemRLcFFCQU56TzFjekJ5WUduMU5aMms1emUrS29JYUNFZ3g1?= =?utf-8?B?R3M4aGtDaWV6anI1S1ptTVFmTXZlSXRESTFuazF0SVh2aWFSUDN0dFBwWDJk?= =?utf-8?B?R3B0QXNBcGNXQWlYd1FhRFprZGdZeGd1WXFzVk1WL0hjTGZ4VG1QMHRlVTUx?= =?utf-8?B?R3ZVS3UxcnVja0QwY3UzeUNjV2JXZ3JkRFFHR3prYzh5WlZTNkhzQ0NzcEpT?= =?utf-8?B?Z2FRby9TcGdBcm4vTW4vSWd0aDhVS1RHN21SZmc5Y1BQMXVIYzJPWXk1Nkdl?= =?utf-8?B?TmhwL2ZFVU92Sk93WElRV1Q4aXFFRlZiRG9BNGpGR2NoOHZFK0pSdVJtT01Z?= =?utf-8?B?TTJmeThJYmFrNWpFYVEzOTdpYk0rS0hvSzVFT2VQbmlaMWdIek9ZRDE1NVE0?= =?utf-8?Q?COx?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;6:krGBypzBleTX9D3IRmR4KusOv+3vQj4nGAIJfM+bftU0ibs+qKjwJs5Tj6LvJJ3zi0SIF7gPGM22QHps0AAWycNyjG41KfI52mduSpuWb8nR/gXFEBgalOs4kr0VES6GMZOQIfq9WrXpXfmIVraeUaMXJ9sqdJf8FLl4kWASh5mhEod3xSh6q14p5faHFs0LCid2RmA2pxLELY2pyKi3N+VZoVLeT2wrU5a1L/k56R808G8+ym5JUOJ2LevkDThtb9eXci5guvOtHVU4l4SCcAHIgj+oMYs04rN9Fhqt+zHLxnXf9GrCFnq/VCtTY74M+jHaEylmaTW0FtnvlnHXYkvyl9JGHIa70h0WqK2EOouRmbpi1uB3jkEbe+pRU9eTFyQfMBoDhy/jwHcva0j6/g==;5:MdFFrbWp7ikbFf5gIM+DBp0dZvDc7BqlK4ioT5/zgDX2Migv8TKIqhx5jg7A2sn9/Mj9CxLzngY6PdAY4F1H9t1uIl2vtGG6xlFa0ecScWla4GLBWz6GCRUnPblCbZXu3L5rwBV+minq0dTbur8Ndg==;24:kNo5yevVw69EZM5eGTODZmB5l1V+Daq7DOYEuL5UhtB/sM0sIX+XQbRwyKSh4eVtopI8KN0F8/MwYY5vTWRU2itm6qZds0HpIsB6hjYLYts= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB5PR0201MB1863;7:u6prDVS7uJIflyYp4JqYNsh9LD2SN19USRb5gvxvMIi5wNRfNZSJxgv5canIH338GSQVdm9u18DsL4K5cwJsCgbEkKLUwQ0eanPtEfkCBlFs3MmMQPIr7idBKO5lbC8kYj83e4Ox9GUsciLCcFHtOFtfUmnSNWGXM/plMaHrXWL9sUjEoariQDfOZWdgOi7yiWXlVCm4xLIcd+J2/4GCK1gqEfuNaJW7Yb/oWxMRaybOLo2pVaquFf7lVcNWJ8F8hWtHt4lJJYvtRPtoPVKILoogRAk5KiupNEJGhVQguRVaYApfvpVu6RBBIpAN5THJ+p/OPUOnG4wfvzwnKptaHA== X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2017 16:45:13.9736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0201MB1863 X-SW-Source: 2017-q1/txt/msg00075.txt.bz2 > imo, elfutils shouldn't be growing these fallback implementations itself. > if you want to do this stuff, use gnulib instead. > > then there is no ifdef hell in the source files, and you don't have to > worry about testing whether the ifdef's are correct because gnulib did > it all for you. OK, so I won't post any more patches with replacement functions. I don't like the idea of using gnulib because the gnulib implementations are generally more complex and in order to maintain them I would have to track gnulib in addition to elfutils. Also I would have to review the licenses for each import. This is not something I'm excited to do for a few 3-line functions. But OK, I will consider it. What about switching off functionality if certain conditions aren't met? For example the patch that allows us to build libelf and libdw if argp is not available. Are such changes acceptable? I have something similar for obstack, and possibly for fts. Ulf