public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "Yu, Mingli" <mingli.yu@windriver.com>
To: Mark Wielaard <mark@klomp.org>
Cc: <elfutils-devel@sourceware.org>, <ldv@altlinux.org>
Subject: Re: [PATCH v2] skip the test when gcc not deployed
Date: Fri, 24 May 2019 07:12:00 -0000	[thread overview]
Message-ID: <5CE79A80.4030608@windriver.com> (raw)
In-Reply-To: <20190524070312.GD2818@wildebeest.org>



On 2019年05月24日 15:03, Mark Wielaard wrote:
> Hi,
>
> On Fri, May 24, 2019 at 02:47:25PM +0800, Yu, Mingli wrote:
>>> On Tue, May 21, 2019 at 03:33:06PM +0800, mingli.yu@windriver.com wrote:
>>>> Skip the tests which depend on gcc when
>>>> gcc not deployed.
>>>
>>> What exactly are you trying to do?
>>> When would you run make check without having gcc installed?
>>
>> Thanks Mark!
>> I just run the check without having gcc installed, and of cource no compiler
>> installed in my test env.
>
> I don't think that is a realistic test environment for testing the
> elfutils libraries. You have to have the tools to create various ELF
> files and DWARF data to properly test things work correctly.

Yes, we use elfutils in cross compile env, one works as build host which 
we build all the packages and of course gcc installed on the build host 
and another as target which only deployed the necessary packages which 
we have build on the build host.
And this is the case we just run the test on the target.

I think it make sense to check the gcc and make it skip if the cases 
depends on gcc.

Thanks,

>
> Cheers,
>
> Mark
>

      reply	other threads:[~2019-05-24  7:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  7:01 [PATCH] tests: check gcc mingli.yu
2019-05-21  7:25 ` Dmitry V. Levin
2019-05-21  7:34   ` [PATCH v2] skip the test when gcc not deployed mingli.yu
2019-05-23 11:28     ` Mark Wielaard
2019-05-24  6:41       ` Yu, Mingli
2019-05-24  7:03         ` Mark Wielaard
2019-05-24  7:12           ` Yu, Mingli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CE79A80.4030608@windriver.com \
    --to=mingli.yu@windriver.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=ldv@altlinux.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).